mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Joe Perches <joe@perches.com>, alsa-devel@alsa-project.org
Cc: tiwai@suse.de, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com,
	vkoul@kernel.org, broonie@kernel.org, jank@cadence.com,
	Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [alsa-devel] [PATCH 1/3] soundwire: fix style issues
Date: Thu, 4 Apr 2019 14:37:05 -0500	[thread overview]
Message-ID: <52a3a4a0-c81c-3daf-78b3-7668b621ecf1@linux.intel.com> (raw)
In-Reply-To: <98050a8abfdd9ec015d4de846b276cf046115e3f.camel@perches.com>

Thanks for the review Joe,

@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave 
*slave)

>>   		mutex_unlock(&slave->bus->bus_lock);
>>   		if (dev_num < 0) {
>>   			dev_err(slave->bus->dev, "Get dev_num failed: %d",
>> -								dev_num);
>> +				dev_num);
> You could also add the missing terminating '\n' to these formats like:
>
>   			dev_err(slave->bus->dev, "Get dev_num failed: %d\n",
>
Yes indeed, I just fixed that tools reported, but that is a miss. Will 
fix with a v2 (hopefully with other comments).

-Pierre


  reply	other threads:[~2019-04-04 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 18:22 [PATCH 0/3] soundwire: code cleanup Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 1/3] soundwire: fix style issues Pierre-Louis Bossart
2019-04-04 19:28   ` Joe Perches
2019-04-04 19:37     ` Pierre-Louis Bossart [this message]
2019-04-04 18:22 ` [PATCH 2/3] soundwire: bus: remove useless initializations Pierre-Louis Bossart
2019-04-04 18:22 ` [PATCH 3/3] soundwire: stream: remove useless initialization of local variable Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52a3a4a0-c81c-3daf-78b3-7668b621ecf1@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=joe@perches.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®