From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE7E257D for ; Mon, 20 Jan 2025 07:45:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359117; cv=none; b=hCSdN9bVYa820jbOzVWV4dABuVKEXJVOVcEGgKUD28IxgVL1+wsUP9AVfJsrxo3hMTggeS5XHqBhC+X1wQdF3HJCE5Btt8mHwyo+AmB2Pr91QmC2bUaO5k0fxXEoRO8Q1uLW6xX9GAx6ikd9NYf71PcuMu2NyBwkl8Bcjqm5f8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359117; c=relaxed/simple; bh=81i0HYpn3tcv/Y6J2Li4Ftkn+DOI4UAA0/Sv6Xif0GU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lzEW0jQVXuR105LvmsPLN+qxbkg1PIIIk0cN9bUy2MzLeN+wmYgohSattfohn4kU4kYtagXoiDY+Vj2iCLJ1Z8Y9EjPnm8q2EFEBHQWwFFqyNj4BlJeozQjhvlewrt0iSr5mFp+3lmgMBpiYR4Vtdt6KTmklv+IPDKdVSp0l0rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BXQtmIZf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BXQtmIZf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737359114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ElOuSTTZEFaFvEWF+0enicKVOtWt5Iuh94BDpIXb40Q=; b=BXQtmIZfhm9+bXRkApI+QBZZ+5qGGiKa9smKvtEoBV3agyjcY4JxiT6Qjrqe1WTPj5ri2X zkuYYgZCQ+8V8p6ySi7PuPz1ljWsa3y2suM3CGP3YoeI8wtlruFdhCM5GMRXLQKIQ6d+bA jY9BCDjiS/5niaZzIHa2VrOvo4WtRbg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-2eVjFci9P6KUjTzATnEQ1Q-1; Mon, 20 Jan 2025 02:45:11 -0500 X-MC-Unique: 2eVjFci9P6KUjTzATnEQ1Q-1 X-Mimecast-MFC-AGG-ID: 2eVjFci9P6KUjTzATnEQ1Q Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43673af80a6so32584265e9.1 for ; Sun, 19 Jan 2025 23:45:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737359111; x=1737963911; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ElOuSTTZEFaFvEWF+0enicKVOtWt5Iuh94BDpIXb40Q=; b=I8niRcbPikQVqaIB9lMHqx2TVsp1PHal2cCh9Nx7kfRavjS1BEUGlyR0a6+g+h3hKU fr1s3t+mty71Xf/EYnSTTPT8Mv0/2uvc1ZORBmfRco6HESgfu+KzcjPM1GvM9ECVuCtB AgFqEJIMyjSDwEYA2okzf91M1V/A8PhbWxaqScAGl727lH5YocurMYrEk21YHGnFr/tH 0M1bY8m95a4UgNh+/lQy99Meb20tu5THYj7Da5LtYBJRuymThGg0gT+3ZC8UDNf+x6BX X4XMHFJcM7dC+lsZmRTtXBjZItjWLxnkj1Cn7pF1e9v4VjX/m2d06rZDXX0YkO9L2Z3q LxZA== X-Forwarded-Encrypted: i=1; AJvYcCUkbN7nyqQamhSjUjrtiVlQ42rmEKWfN8KWs6bwKy7nuS8KdDbLo5OmPkjDk5Djb2YVp8IR8HyFBR54678=@vger.kernel.org X-Gm-Message-State: AOJu0Yyyd3AnkAu5INimfo4mdkbbBbM7PVYhxZLFkNJRIlpBJFnBuLS3 GCvngEfhFezQgnhYAzMdhcg4X3mMgfQ6Jgf+DymcgcZEZgD/3CIJzeKsIYQkJEc6zu55FVzj+oA 2S1CqSqpYfiVwIjBFkwpFbYI8hNkFREHnEMLK91MqWbG3jOJIXZD7Tx3QGlSRlQ== X-Gm-Gg: ASbGncstx478JvnaxQrPuebuGMiQhwShm43yRUtbw1eNw75CmyDnMvaIVWsneHx5kM9 1cMdnguqRjm2iMGk65b6+rpjHQc7lIekAk702iR5Q5nVRmqyzfIifgcstta1Vck9lPVKazx3qjf k6sgyds6xY4bzl8AFdltasMO5fsPaH3Fnfq11ADeucB3aODGYAEQ4vqjp+F37u59DK1QE7Khxp3 sg/GfFK7f4Zf11OT5LbrCzFB3Gv8KXhuOuz12RUs/tLjewlYehjjFe0U4R6xPTtIFN7mtY2TwNz lcxGnWAaSvsrbdIk3xphqNbcTjV5g5CZ9MecKf7UoHP+q6KKj5r9HBYk3X0w3RMVsSbkrKYdImA 1znwU/2a7QQOf5OM3XprvYA== X-Received: by 2002:a05:600c:b8c:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438912d2c48mr112151295e9.0.1737359110731; Sun, 19 Jan 2025 23:45:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMAfAkjyq6M0tHuZOndmrAYDvTyGnP5uOZqrRz4DRX0zAGhk5zAEd3DrsGYoH450s+6I6nAg== X-Received: by 2002:a05:600c:b8c:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438912d2c48mr112150665e9.0.1737359110362; Sun, 19 Jan 2025 23:45:10 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74ac712sm186030105e9.12.2025.01.19.23.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jan 2025 23:45:09 -0800 (PST) Message-ID: <52a45aa6-1554-4cb8-b8df-da601c4e18ca@redhat.com> Date: Mon, 20 Jan 2025 08:45:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/mmap: allow MAP_DROPPABLE | MAP_PRIVATE in mmap() To: Lance Yang , akpm@linux-foundation.org Cc: 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, Jason@zx2c4.com, Mingzhe Yang References: <20250120012607.4808-1-ioworker0@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250120012607.4808-1-ioworker0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.01.25 02:26, Lance Yang wrote: > Currently, mmap() fails with `-EINVAL` when both MAP_DROPPABLE and > MAP_PRIVATE are specified. This behavior might be inconsistent, as the > implementation of MAP_DROPPABLE under the hood already includes the > semantics of MAP_PRIVATE. So, IMO, whether MAP_PRIVATE is explicitly > specified or not, it should work as expected. > > For example, when mmap() is called with `MAP_DROPPABLE | MAP_ANONYMOUS`, > it creates a private anonymous mapping. Users can verify this behavior > via `/proc/self/smaps`, where the resulting VMA is marked with the `dp` > (MAP_DROPPABLE) flag, and the `Private_*` fields confirm private memory > semantics. The output for a 2MiB mapping with these flags might look like: Note that "Private_" in the stats has *nothing* to do with MAP_PRIVATE. > > ``` > f433ace00000-f433ad000000 rw-p 00000000 00:00 0 > Size: 2048 kB > KernelPageSize: 4 kB > MMUPageSize: 4 kB > Rss: 2048 kB > Pss: 2048 kB > Pss_Dirty: 2048 kB > Shared_Clean: 0 kB > Shared_Dirty: 0 kB > Private_Clean: 0 kB > Private_Dirty: 2048 kB > Referenced: 2048 kB > Anonymous: 2048 kB > ... > VmFlags: rd wr mr mw me nr wf dd dp > ``` > > This patch changes mmap() to allow the combination of `MAP_DROPPABLE | > MAP_PRIVATE`. For mmap(), at least one of MAP_PRIVATE or MAP_SHARED could > be explicitly specified, regardless of the combination with other `MAP_*` > flags. > > Fixes: 9651fcedf7b9 ("mm: add MAP_DROPPABLE for designating always lazily freeable mappings") "How about we just say that VM_DROPPABLE really is something separate from MAP_PRIVATE or MAP_SHARED.. And then we make the rule be that VM_DROPPABLE is never dumped and always dropped on fork, just to make things simpler." [1] [1] https://lore.kernel.org/linux-mm/CAHk-=wi=XvCZ9r897LjEb4ZarLzLtKN1p+Fyig+F2fmQDF8GSA@mail.gmail.com/ So, nack from my side. -- Cheers, David / dhildenb