mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wayne Chang <waynec@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	Thierry Reding <treding@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"heikki.krogerus@linux.intel.com"
	<heikki.krogerus@linux.intel.com>, Ajay Gupta <ajayg@nvidia.com>,
	"kishon@ti.com" <kishon@ti.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"balbi@kernel.org" <balbi@kernel.org>,
	"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	Jui Chang Kuo <jckuo@nvidia.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sing-Han Chen <singhanc@nvidia.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding
Date: Tue, 25 Oct 2022 08:02:09 +0000	[thread overview]
Message-ID: <52ae737e-eb4f-9eb7-8b79-d58251062276@nvidia.com> (raw)
In-Reply-To: <20221024145446.GA1763588-robh@kernel.org>

Thanks for the review.
All the changes will be updated in the next patchset except the 
power-domain-name.

On 10/24/22 22:54, Rob Herring wrote:
> External email: Use caution opening links or attachments
> 
> 
>> +description:
>> +  The Tegra XHCI controller supports both USB 2.0 HighSpeed/FullSpeed and
>> +  USB 3.1 SuperSpeed protocols.
>> +
>> +maintainers:
>> +  - Wayne Chang <waynec@nvidia.com>
>> +
> 
> Ref to usb-xhci.yaml? Or usb-hcd.yaml.
> 
It should be usb-xhci.yaml. thanks.

>> +  power-domain-names:
>> +    items:
>> +      - const: xusb_host
>> +      - const: xusb_ss
> 
> Drop 'xusb_'.

The properties are constant and we use the name to get the power domain.

	tegra->genpd_dev_host = dev_pm_domain_attach_by_name(dev, "xusb_host");
	
	tegra->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "xusb_ss");
	
we might not be able to drop the xusb_

thanks,
Wayne.


  reply	other threads:[~2022-10-25  8:02 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  7:41 [PATCH 00/11] Enable USB host and device functions on Jetson Wayne Chang
2022-10-24  7:41 ` [PATCH 01/11] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support Wayne Chang
2022-10-25 23:24   ` Rob Herring
2022-11-03 10:36     ` Wayne Chang
2022-10-24  7:41 ` [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding Wayne Chang
2022-10-24 13:30   ` Rob Herring
2022-10-24 15:58     ` Jon Hunter
2022-10-24 14:54   ` Rob Herring
2022-10-25  8:02     ` Wayne Chang [this message]
2022-10-28  2:19       ` Krzysztof Kozlowski
2022-10-28  9:25         ` Jon Hunter
2022-10-28 11:07           ` Jon Hunter
2022-10-28 11:30             ` Thierry Reding
2022-11-03 10:24               ` Wayne Chang
2022-10-24  7:41 ` [PATCH 03/11] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver Wayne Chang
2022-10-26  1:07   ` Rob Herring
2022-10-26  7:13   ` Jon Hunter
2022-10-28 12:31     ` Thierry Reding
2022-10-28 12:42       ` Jon Hunter
2022-10-28 14:07         ` Thierry Reding
2022-11-03 10:47           ` Wayne Chang
2022-10-24  7:41 ` [PATCH 04/11] arm64: tegra: Enable XUSB host and device on Jetson AGX Orin Wayne Chang
2022-10-28  2:23   ` Krzysztof Kozlowski
2022-10-28  9:33     ` Jon Hunter
2022-10-28 11:27       ` Krzysztof Kozlowski
2022-10-28 11:34         ` Jon Hunter
2022-10-28 12:38         ` Thierry Reding
2022-10-28 21:48           ` Krzysztof Kozlowski
2022-10-24  7:41 ` [PATCH 05/11] usb: typec: ucsi_ccg: Add OF support Wayne Chang
2022-10-24  7:41 ` [PATCH 06/11] usb: typec: ucsi_ccg: Replace ccgx to well-known regex Wayne Chang
2022-10-24  8:01   ` Heikki Krogerus
2022-10-24  8:29     ` Felipe Balbi
2022-10-24  8:46       ` Heikki Krogerus
2022-10-25  7:26         ` Wayne Chang
2022-10-24  7:41 ` [PATCH 07/11] i2c: nvidia-gpu: " Wayne Chang
2022-11-01 15:07   ` Jon Hunter
2022-11-03 11:36     ` Wayne Chang
2022-10-24  7:41 ` [PATCH 08/11] phy: tegra: xusb: Disable trk clk when not using Wayne Chang
2022-11-05 14:58   ` Vinod Koul
2022-11-07 10:37     ` Wayne Chang
2022-10-24  7:41 ` [PATCH 09/11] phy: tegra: xusb: Add Tegra234 support Wayne Chang
2022-10-28 12:56   ` Thierry Reding
2022-11-03 11:42     ` Wayne Chang
2022-11-05 15:01   ` Vinod Koul
2022-11-07 10:36     ` Wayne Chang
2022-10-24  7:41 ` [PATCH 10/11] usb: host: xhci-tegra: Add Tegra234 XHCI support Wayne Chang
2022-10-28 13:39   ` Thierry Reding
2022-11-01 14:53     ` Jon Hunter
2022-11-03 11:35       ` Wayne Chang
2022-10-24  7:41 ` [PATCH 11/11] usb: gadget: tegra-xudc: Add Tegra234 support Wayne Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52ae737e-eb4f-9eb7-8b79-d58251062276@nvidia.com \
    --to=waynec@nvidia.com \
    --cc=ajayg@nvidia.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jckuo@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=singhanc@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome