From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D755C433F5 for ; Tue, 11 Oct 2022 18:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbiJKSW4 (ORCPT ); Tue, 11 Oct 2022 14:22:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230184AbiJKSWQ (ORCPT ); Tue, 11 Oct 2022 14:22:16 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E13554E872; Tue, 11 Oct 2022 11:21:56 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29BHS2eO006350; Tue, 11 Oct 2022 18:21:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=s9yL9XN4mdu0+kB2rqewwOMU2LIwOmtCD9qnW0X47X4=; b=FwaEuSTNv2RexXUfcC7TMuvDhp0rNZBsAk3gt8lspmkcl8nyt15PPyQqWc3aFulSpveK KCSrsBS9LJsL/D8PqTrtjpuJX72wj0AcO6jdZEnIlxbAKhBonHa85eCNevSBDYVkogvl liye0rwqjhsixe0XG3AnIwPRrdVNAXbAC8ZaKa+U55RAM2n2FgchaszJ6bj+OC5tSWti oJdodSZs0REGsppq577pvKBghuA5AUfRIG8yNfiWpZc8Rj/Ekb0Kyf/ML8+vMPY92KXb nmNAtjymVB+bgq5yic0kTFLdFxooTw0sp7FTbUCq0XA/zDKrY4WGNKzuAR1D7L8FQt5L Sw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3k4rwy3ut6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Oct 2022 18:21:38 +0000 Received: from nasanex01b.na.qualcomm.com (corens_vlan604_snip.qualcomm.com [10.53.140.1]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 29BILbS3025883 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Oct 2022 18:21:37 GMT Received: from [10.134.65.5] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 11 Oct 2022 11:21:37 -0700 Message-ID: <52b07662-666a-2fc7-cb18-a9d294f7ae9b@quicinc.com> Date: Tue, 11 Oct 2022 11:21:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 03/13] gunyah: Common types and error codes for Gunyah hypercalls Content-Language: en-US To: Greg Kroah-Hartman CC: Bjorn Andersson , Arnd Bergmann , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , "Will Deacon" , Catalin Marinas , , , , References: <20221011000840.289033-1-quic_eberman@quicinc.com> <20221011000840.289033-4-quic_eberman@quicinc.com> From: Elliot Berman In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: e2_qyRN_h6iSjZQF8XQNSSuCOXasgtQK X-Proofpoint-GUID: e2_qyRN_h6iSjZQF8XQNSSuCOXasgtQK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-11_08,2022-10-11_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 mlxlogscore=833 phishscore=0 lowpriorityscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210110107 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2022 12:21 AM, Greg Kroah-Hartman wrote: > On Mon, Oct 10, 2022 at 05:08:30PM -0700, Elliot Berman wrote: >> Add architecture-independent standard error codes, types, and macros for >> Gunyah hypercalls. >> >> Signed-off-by: Elliot Berman >> --- >> MAINTAINERS | 1 + >> include/asm-generic/gunyah.h | 74 ++++++++++++++++++++++++++++++++++++ >> 2 files changed, 75 insertions(+) >> create mode 100644 include/asm-generic/gunyah.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index ef6de7599d98..4fe8cec61551 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8886,6 +8886,7 @@ L: linux-arm-msm@vger.kernel.org >> S: Supported >> F: Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml >> F: Documentation/virt/gunyah/ >> +F: include/asm-generic/gunyah.h >> >> HABANALABS PCI DRIVER >> M: Oded Gabbay >> diff --git a/include/asm-generic/gunyah.h b/include/asm-generic/gunyah.h >> new file mode 100644 >> index 000000000000..64a02dd3b5ad >> --- /dev/null >> +++ b/include/asm-generic/gunyah.h > > Why not include/linux/gunyah.h? Why asm-generic? This is not an > architecture. > My idea here is to differentiate between code that interacts with hypercalls and code that uses the abstractions provided on top of those hypercalls. include/asm-generic/gunyah.h contains architecture-independent definitions for hypercalls. Hypercalls are architecture-specific. For instance, I wanted to avoid a header file that mixes the definitions for the message-queue mailbox with the hypercall definitions that the message-queue mailbox driver itself uses. I can put it all in include/linux/gunyah.h and delineate with some clear comments, but I initially felt it would be better to have separate header file. Thanks, Elliot