mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Lizhe <sensor1010@163.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
	alexandre.torgue@foss.st.com, rmk+kernel@armlinux.org.uk,
	vladimir.oltean@nxp.com, maxime.chevallier@bootlin.com,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Support gpio high-level reset for devices requiring it
Date: Tue, 8 Jul 2025 19:34:07 +0200	[thread overview]
Message-ID: <52b71fe7-d10a-4680-9549-ca55fd2e2864@lunn.ch> (raw)
In-Reply-To: <20250708165044.3923-1-sensor1010@163.com>

On Tue, Jul 08, 2025 at 09:50:44AM -0700, Lizhe wrote:
> some devices only reset when the GPIO is at a high level, but the
> current function lacks support for such devices. add high-level
> reset functionality to the function to support devices that require
> high-level triggering for reset

You can probably specify this in DT:

reset-gpios = <&qe_pio_e 18 GPIO_ACTIVE_LOW>;

The gpio core will then flip the meaning of

gpiod_set_value_cansleep(reset_gpio, 1);

such that a value of 1 will become low, 0 will become high.

     Andrew

  reply	other threads:[~2025-07-08 17:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 16:50 Lizhe
2025-07-08 17:34 ` Andrew Lunn [this message]
     [not found]   ` <5c7adfef.1876.197ece74c25.Coremail.sensor1010@163.com>
2025-07-09  4:26     ` Russell King (Oracle)
     [not found]       ` <5bb49dc0.6933.197ee28444e.Coremail.sensor1010@163.com>
2025-07-09 11:11         ` Russell King (Oracle)
     [not found]           ` <4cfb4aab.9588.197eefef55f.Coremail.sensor1010@163.com>
2025-07-09 14:29             ` Russell King (Oracle)
     [not found]               ` <2352b745.a454.197efeef829.Coremail.sensor1010@163.com>
2025-07-09 17:01                 ` Andrew Lunn
2025-07-09 17:41                 ` Russell King (Oracle)
2025-07-09 12:54     ` Andrew Lunn
2025-07-08 17:40 ` Russell King (Oracle)
     [not found]   ` <2588871d.189d.197ece7c486.Coremail.sensor1010@163.com>
2025-07-09  4:25     ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52b71fe7-d10a-4680-9549-ca55fd2e2864@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sensor1010@163.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®