From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932748AbcHXRzV (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Aug 2016 13:55:21 -0400
Received: from merlin.infradead.org ([205.233.59.134]:34898 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755788AbcHXRzT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Aug 2016 13:55:19 -0400
Subject: Re: [PATCH -next] sound: rockchip: fix build when SPI is not enabled
To: LKML <linux-kernel@vger.kernel.org>,
        moderated for non-subscribers <alsa-devel@alsa-project.org>,
        Takashi Iwai <tiwai@suse.de>
References: <14691987-ab74-96c4-de5d-8caa06e94d3f@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Bard Liao <bardliao@realtek.com>, Oder Chiou <oder_chiou@realtek.com>
From: Randy Dunlap <rdunlap@infradead.org>
Message-ID: <52b8a769-e582-d9d7-403a-e49a59067786@infradead.org>
Date: Wed, 24 Aug 2016 10:55:08 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <14691987-ab74-96c4-de5d-8caa06e94d3f@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/22/16 11:32, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors found in rt5514 drivers when SPI is not enabled.
> 
> Fixes these build errors:
> ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
> ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:	Bard Liao <bardliao@realtek.com>
> Cc:	Oder Chiou <oder_chiou@realtek.com>
> ---
>  sound/soc/rockchip/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This builds without errors, but if you always want to have the SPI
> interface available in this driver, change the first "depends" to
> include "&& SPI_MASTER".

Please drop this patch.  The comment above is the correct thing to do
and I am sending a patch with that change.


> --- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
> +++ linux-next-20160822/sound/soc/rockchip/Kconfig
> @@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
>  	select SND_SOC_MAX98357A
>  	select SND_SOC_RT5514
>  	select SND_SOC_DA7219
> -	select SND_SOC_RT5514_SPI
> +	select SND_SOC_RT5514_SPI if SPI_MASTER
>  	help
>  	  Say Y or M here if you want to add support multiple codecs for SoC
>  	  audio on Rockchip RK3399 GRU boards.
> 


-- 
~Randy