From: Ziqi Chen <quic_ziqichen@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>, <quic_asutoshd@quicinc.com>,
<quic_cang@quicinc.com>, <quic_nguyenb@quicinc.com>,
<mani@kernel.org>, <stanley.chu@mediatek.com>,
<adrian.hunter@intel.com>, <beanhuo@micron.com>,
<avri.altman@wdc.com>, <junwoo80.lee@samsung.com>,
<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: print trs for pending requests in MCQ mode
Date: Wed, 15 Mar 2023 15:31:10 +0800 [thread overview]
Message-ID: <52bd8c2d-31f6-1f69-1d83-cf21ee66aec8@quicinc.com> (raw)
In-Reply-To: <bde102c7-ab4f-a301-072f-8d6b7acde8a8@acm.org>
sure
Best Regards,
Ziqi
On 3/15/2023 2:09 AM, Bart Van Assche wrote:
> On 3/14/23 04:16, Ziqi Chen wrote:
>> +static bool ufshcd_print_tr_iter(struct request *req, void *priv)
>> +{
>> + struct scsi_device *sdev = req->q->queuedata;
>> + struct Scsi_Host *shost = sdev->host;
>> + struct ufs_hba *hba = shost_priv(shost);
>> +
>> + if (!IS_ERR_OR_NULL(hba))
>> + ufshcd_print_tr(hba, req->tag, *(bool *)priv);
>
> I think that the "if (!IS_ERR_OR_NULL(hba))" code can be removed safely.
> Otherwise this patch looks good to me.
>
> Thanks,
>
> Bart.
prev parent reply other threads:[~2023-03-15 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:16 Ziqi Chen
2023-03-14 18:09 ` Bart Van Assche
2023-03-15 7:31 ` Ziqi Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52bd8c2d-31f6-1f69-1d83-cf21ee66aec8@quicinc.com \
--to=quic_ziqichen@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®