From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4111E242936 for ; Wed, 5 Mar 2025 13:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741180639; cv=none; b=nOAMINycqDdSQcxeGAqccn0owANqNVeL1St8gU1iqiHJs7eQs5Zr8YClg5ct7j6KNd8ep9H09+IGVtyX7Q0770SP3N17KANoaVr3pvcaO4Q0HG93j+ztNOSTp8nbZea3PjZuBm4RYLvPq4zJ4SSzyMMDtB/BjdoAxEqZ2KLtO6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741180639; c=relaxed/simple; bh=2kxHOADdMaBJ2diMMR7f3Fz/guxN2SEgJZkgoL6/lJw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uOQ5PvmhRquJ+Xt6Ze3mJIM5Mk3TXVyrfLLI7Bibh/cU9sbArnu36GQhoq4LAth+ys9CYhmFM8rnQpkM1XGt2p7ZUldDKk/gZ9FzkAul/DEItyNrBjnjU43lUw0CZ/X/Nk9eMokYja+rK1KqC2G6FOEd47GrlzvvkzJkujT7FTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=Nr2dnttS; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="Nr2dnttS" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-390f5f48eafso2434737f8f.0 for ; Wed, 05 Mar 2025 05:17:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1741180635; x=1741785435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6N01sDPWZVW3FIPmf2JkMC4QdlVlUkWYnKGuNikmOwk=; b=Nr2dnttSS5udPt5LBLeFCEjM99AKV1stfi4dhqppWSZ9Bk0OUfaTSaYjcBGhDK2N3y RGDBS6VR+ePFZDhNm1TglpB44ynyavh8DwTP4xOh17G31cFD01wxLIikEV0W4PY3jtgO N5hCxA7HUpvjKYllwKsQktZL0fJcQR11PR2UeEvP5wMDrQ7mH0eu7ISkArs/thzo6T3r NuvtMTwWDMBAsY3Hnq1zv3dYwGfe1VwPBO4FkzQOTrqnA8CwE6qf07Ivblzc+6u85OqQ f+uk1LY3Cxj22qsz2EeZ5wwqC27JlrkOJwLbEzW7LpJZbD9ij3GqRLdwuTxqlwwqq6MO b5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741180635; x=1741785435; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6N01sDPWZVW3FIPmf2JkMC4QdlVlUkWYnKGuNikmOwk=; b=M+dHjV9xNBiFewWKs5OcbHGGE3IGKnRrjVIru3OlMhnmSK3a1c6c5uOx79lqVmXcck ELLDghxjo1mL7Tzi5pvuR4lIfEbRSvvzmt3Aa3B39T0i/Wx6vNul1CR2BuoOjXxvP4hb Cg8mAysv21S4hTp8WyhT0AM5PHc0Iod0yPP1hA+Vee2gay9j78JWk7oGASfb8KhmoeyC xUVWxo986rWX9mlrb3BjEhs7RpeyRnQbanFlFX/EFOL2Hbo0o8gl2FWFQzg7h2JmPDSn 3V4Vqh9JSm0HMnKl24Kfb1Teic7wnmoS9OLLpay6qHw3KSsJd3JKT/oDYl3jccHjftiU iguA== X-Forwarded-Encrypted: i=1; AJvYcCVNaemIrXu+FbvQt9aedXqrjsPrLjTZBaD6+sa5dKgVDW6oiyNE0E8j6JKfEqkJ/CAj3HFSHurim6SdwYY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbc1+YVQ8AGBPzVw7sSc0ex7dYQzmPerxocHEfAcr3hmOPbadX 6w6oca9E7FnB5JtRY3h8eLnN0O35qzyTQkVOEu6UHs211S/+LtUjQiUasomv4Pc= X-Gm-Gg: ASbGncvi8jdwkGoCW9JfkRmUVDiNCQVG0sKTqdkkCmCxlV1puLOzsEph6cYzDvEPovF XaRIXq0jEYjr1IHsBAPp8g8JUxB+Nqpkz6ZzlMiPAFooHt+uC2NqYX4S0DvOvCIs8TyN+arju/W 608cZkt+Hs/wYo/2tgTt8FQA04CghqImk79VqE0s3ptKbxj69fCRctAHK9sABIMzwVds5fHVN7r rT8rZC0TkoJjG6u/jELMJJYZ4M10U+NV+JNyhgk9QCP7mg4ggMKTDU+KbUQbq8GWL+IVmDq1Gfy 5uia0HV5IOEDwdu2bSsQUVkhmNi4BFAgoZgZ/SzcnLJQhwdQw4JeaNcO6gKOu79jvlRnuvHhvoj SAQuI X-Google-Smtp-Source: AGHT+IHRg0l/1N8uHFnYb4bX5yYHlChPZNy+86wJV5dCxTO5VpvzzPCHs43ZAYtx/q1KNZyZRo48PQ== X-Received: by 2002:a05:6000:1844:b0:390:de59:470d with SMTP id ffacd0b85a97d-3911f760290mr2386582f8f.24.1741180635465; Wed, 05 Mar 2025 05:17:15 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1:6b84:f104:e1bf:5d7? ([2001:67c:2fbc:1:6b84:f104:e1bf:5d7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b7dcfsm21291872f8f.55.2025.03.05.05.17.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 05:17:14 -0800 (PST) Message-ID: <52bdddf9-99e0-4b87-8bae-c0a8f32beba8@openvpn.net> Date: Wed, 5 Mar 2025 14:17:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 20/24] ovpn: implement key add/get/del/swap via netlink To: Sabrina Dubroca Cc: netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Shuah Khan , ryazanov.s.a@gmail.com, Andrew Lunn , Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Xiao Liang References: <20250304-b4-ovpn-tmp-v21-0-d3cbb74bb581@openvpn.net> <20250304-b4-ovpn-tmp-v21-20-d3cbb74bb581@openvpn.net> <07c73e1d-3c9c-46c7-92cd-28d728929d18@openvpn.net> <71c1db26-f147-4578-89ae-c5b95da0ec9a@openvpn.net> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/03/2025 11:11, Sabrina Dubroca wrote: > 2025-03-05, 02:00:21 +0100, Antonio Quartulli wrote: >> On 05/03/2025 00:09, Sabrina Dubroca wrote: >>> 2025-03-04, 13:11:28 +0100, Antonio Quartulli wrote: >>>> On 04/03/2025 13:00, Sabrina Dubroca wrote: >>>>> 2025-03-04, 01:33:50 +0100, Antonio Quartulli wrote: >>>>>> int ovpn_nl_key_new_doit(struct sk_buff *skb, struct genl_info *info) >>>>>> { >>>>> ... >>>>>> + pkr.slot = nla_get_u8(attrs[OVPN_A_KEYCONF_SLOT]); >>>>>> + pkr.key.key_id = nla_get_u16(attrs[OVPN_A_KEYCONF_KEY_ID]); >>>>>> + pkr.key.cipher_alg = nla_get_u16(attrs[OVPN_A_KEYCONF_CIPHER_ALG]); >>>>> >>>>> >>>>> [...] >>>>>> +static int ovpn_nl_send_key(struct sk_buff *skb, const struct genl_info *info, >>>>>> + u32 peer_id, enum ovpn_key_slot slot, >>>>>> + const struct ovpn_key_config *keyconf) >>>>>> +{ >>>>> ... >>>>>> + if (nla_put_u32(skb, OVPN_A_KEYCONF_SLOT, slot) || >>>>>> + nla_put_u32(skb, OVPN_A_KEYCONF_KEY_ID, keyconf->key_id) || >>>>>> + nla_put_u32(skb, OVPN_A_KEYCONF_CIPHER_ALG, keyconf->cipher_alg)) >>>>> >>>>> That's a bit inconsistent. nla_put_u32 matches the generated policy, >>>>> but the nla_get_u{8,16} don't (and nla_get_u16 also doesn't match "u8 >>>>> key_id" it's getting stored into). >>>>> >>>>> [also kind of curious that the policy/spec uses U32 with max values of 1/2/7] >>>> >>>> From https://www.kernel.org/doc/html/next/userspace-api/netlink/specs.html#fix-width-integer-types >>>> >>>> "Note that types smaller than 32 bit should be avoided as using them does >>>> not save any memory in Netlink messages (due to alignment)." >>>> >>>> Hence I went for u32 attributes, although values stored into them are much >>>> smaller. >>> >>> Right. >> >> What's wrong with key_id being u8 tough? > > Nothing. It would make a little bit more sense to use nla_get_u16 if > key_id was u16 (even with OVPN_A_KEYCONF_KEY_ID defined as U32), or to > use nla_get_u8 for u8, but here it was just 3 different int sizes and > that triggered my "uh? what?" :) > >> I am a bit reluctant to change all key_id fields/variables to u32, just >> because the netlink APIs prefers using u32 instead of u8. >> >> Keeping variables/fields u8 allows to understand what values we're going to >> store internally. > > Sure. > >> And thanks to the netlink policy we know that no larger value will be >> attempted to be saved, even if the field is actually u32. > > Yes. > Ok :) Then I'll make sure they all use nla_get/put_u32, but will still store the key_id in a u8 field. Cheers! -- Antonio Quartulli OpenVPN Inc.