From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B0B279DAB for ; Fri, 5 Dec 2025 13:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764941387; cv=none; b=rObLCdcWoHkK6NgxMvoRZd5Nfhu/yxiNn2HZeZjQ0tpSB44prFXB1QZC3X6VY0IxVaMZz6mZQ4lXCd0kMFOiG2zxR8LfkKJQ7MfTdkZEo96sA0RauH99tdZePKOKYFfRte0trY6VOMysp/R0wxA0BPGRtQBbOQimRfhglB5t2LQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764941387; c=relaxed/simple; bh=lMD0geLhMWwBjmPbwnuotf/6RYiunY2kr22lC3lDCVM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gx2JNoNSIgjA329cZB8LOwu8+TwsFiDYuKHiWmk5woPe3MbNjhpX87IVnz5Fpexm8tYjf0VIvTUHLnyx72CqQ/JMJdutokAtR9Pea6QlRsSwFQpULp79/qiKlNeEekHduonrJ5DNwEgE7MIExRYturOgYOvMZfDJsH2UHuyo5uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=XpGPZZ/B; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="XpGPZZ/B" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47796a837c7so17685955e9.0 for ; Fri, 05 Dec 2025 05:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1764941381; x=1765546181; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G2XKwF1tFHUTe/3BcysjTIbJPfnPNZwymG6gCY/PH54=; b=XpGPZZ/Bu98zdlngT9go11qNMM+gjJeYDuFS/vTSPq+kZotuEqdx7XTSmsHKXP7m1N 4JrX3XrPYB+K3Hrd8IGP68xXgCovNsudsWwvhLo/Ih7GYclqRBt3Npcwp5PMnvv9Bbqq InunpcZVoAtn+5wFgaMY4E3QtVsfe17yD3DNBXCys3DTwiELMqyYLVsEU0lOsPoQhcSS WCZijO+CqM9dcurvyN3zgQWKtyx5NUkA8NnnLETSwNN8MupE61f9z22rYg9eDIu6U03W ewUBpMJ7R5SZltmAWM0YgTmv4vL4+KdIkEjP6to5zd9KJmB2VSuVqBiMCdjLWABkJT3v UUmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764941381; x=1765546181; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G2XKwF1tFHUTe/3BcysjTIbJPfnPNZwymG6gCY/PH54=; b=uJlmQICWu98Ha8WPYCErH4tOBzRU9AysE6HN4WXYVw/EaP6m/Z2zseFaTA57GI2lR7 R447JJaF8bWsdA/neMBovaq7Z7Yym1jgq7Tn2vyy++iZtY5XTl4l//LdcpUbQza1VHAY FLoIKHNc/sALoPBNVAvSn+MSw2LgmkdPgdRjUmHbN4wgP99jboReGxck+yoaars/LXZq gj6GvEemupVkAuBiOofvoCFS2lXmg82Tvrg8/aDQ5O9YiybTQkkI1Zav57I1oxTcmxBO Zf5o7Ek2aAVaYCLEZdqwj+EyrhTpipdjWhnN+j2js84kKrr0SaC07qiDkHHMxlrf6S6A PNtA== X-Gm-Message-State: AOJu0YyFdZUqgflLJUL/D9y/BnO9BklOTFdpr+FUEdS3lza5khZ7udkw 0KSnReVZEYduN85jiml4zkEWXpKuSNFQw3wi1MiCvAGJxYT06mxfM9iHDry1UNKgnvo= X-Gm-Gg: ASbGnctRJ9Z1C/Jn53WuwIzUOndQotAdkhcMzPqYa6Bp3toPWm7CyEFyfjtepBAKN3F iTgwAAxW+a/m2Z9aa99/4314tx9bqh0DVnweysaP4+lKaehthwriughvPaYFpGvAqV6dl150hG9 fJnW2nrDS+X+A0Ea3thb2JMj9FxvA1IZbZZuTsBcocBY6qBe6m2U6q6cNHhmXHwU0oYNvta49gU jVFpp9z6F0/0HRzS2k3B/fuHmLbHX/FaNtMBHeZAVR9b+mzv81Ox9j2/o94oRpawmTcH9cWjvIh j9TZtVIBor9QjavLA7L2xdtPZK/pCkUGELqEZ9yf7K6N9SRYjTXbIAwgBpoGIAzgLjGPD3Y48yN Pj++5dq4M9E+objahf0NNFJ30MRB+hLHGw44xtM8ngIR3sY/kK1pnoL6vwold4FPrnx3/mL+htN PleitqbPZpsXnXWxS1xNKfwvIKvN7IQA== X-Google-Smtp-Source: AGHT+IHCBGIKMPaxyPuOHAAMy4JxJUA4bh99G9ixBJSlUqhfJgQ2QT/Jji31cTOq+5Ty1JeVupv1FQ== X-Received: by 2002:a05:600c:c87:b0:477:aed0:f3fd with SMTP id 5b1f17b1804b1-4792aef1be4mr92200315e9.8.1764941380713; Fri, 05 Dec 2025 05:29:40 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479311ece7asm83759545e9.12.2025.12.05.05.29.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 05:29:40 -0800 (PST) Message-ID: <52bf094a-a656-4bef-bb22-f903578ecf9b@tuxon.dev> Date: Fri, 5 Dec 2025 15:29:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] reset: rzg2l-usbphy-ctrl: Add suspend to RAM support To: Biju Das , "p.zabel@pengutronix.de" Cc: "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Claudiu Beznea References: <20251110132715.724084-1-claudiu.beznea.uj@bp.renesas.com> <19fda177-6c11-45d6-9dab-3f75edceda4e@tuxon.dev> <50937606-46fd-4202-ad4b-9ede5bff76fc@tuxon.dev> From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/5/25 13:55, Biju Das wrote: > Hi Claudiu, > >> -----Original Message----- >> From: Biju Das >> Sent: 05 December 2025 10:57 >> Subject: RE: [PATCH v2 0/2] reset: rzg2l-usbphy-ctrl: Add suspend to RAM support >> >> >> Hi Claudiu, >> >>> -----Original Message----- >>> From: Claudiu Beznea >>> Sent: 05 December 2025 10:47 >>> Subject: Re: [PATCH v2 0/2] reset: rzg2l-usbphy-ctrl: Add suspend to >>> RAM support >>> >>> >>> >>> On 12/5/25 12:17, Biju Das wrote: >>>> >>>> >>>>> -----Original Message----- >>>>> From: Claudiu Beznea >>>>> Sent: 05 December 2025 10:00 >>>>> To: Biju Das ; p.zabel@pengutronix.de >>>>> Cc: linux-kernel@vger.kernel.org; >>>>> linux-renesas-soc@vger.kernel.org; >>>>> Claudiu Beznea >>>>> Subject: Re: [PATCH v2 0/2] reset: rzg2l-usbphy-ctrl: Add suspend >>>>> to RAM support >>>>> >>>>> Hi, Biju, >>>>> >>>>> On 12/5/25 10:53, Biju Das wrote: >>>>>> >>>>>> >>>>>> Hi Claudiu, >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Claudiu Beznea >>>>>>> Sent: 04 December 2025 18:26 >>>>>>> Subject: Re: [PATCH v2 0/2] reset: rzg2l-usbphy-ctrl: Add suspend >>>>>>> to RAM support >>>>>>> >>> >>> From my previous experience with suspend/resume implementations, I can >>> say restoring the system in failure cases in suspend/resume or not, is >>> up to the subsystem maintainer. So, I'll let Philipp to decide how he wants to go with it in this >> driver. >>> >> >> Agreed. >> >>> They are still supporting suspend to idle, where power is maintained, >>> right? Shouldn't we cover this case? >> >> Yes, I agree. Probably best thing is zero failures, if there is a failure in suspend path, the same >> device will fail in similar fashion, and the system never enters suspend state. >> >> So, report the failure and debug and fix the issue. > > FYI, On your resume path, if the below call fails, then there is a pm imbalance for next suspend(). > > ret = pm_runtime_resume_and_get(dev); > > Similarly, if reset_assert() fails for a shared reset. Wouldn't be the same if there will be no failure path code? Thank you, Claudiu