From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
l.stach@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
laurent.pinchart@ideasonboard.com, marex@denx.de,
paul.elder@ideasonboard.com, aford173@gmail.com,
Markus.Niebel@ew.tq-group.com, alexander.stein@ew.tq-group.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
Date: Wed, 13 Jul 2022 10:29:22 +0200 [thread overview]
Message-ID: <52c0d236-49c6-7c31-abd8-2a083ca7ef8c@linaro.org> (raw)
In-Reply-To: <20220713063653.2584488-3-peng.fan@oss.nxp.com>
On 13/07/2022 08:36, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse
> the i.MX8MM VPU blk ctrl yaml file. And add description for the items.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml | 93 ++++++++++++++++---
> include/dt-bindings/power/imx8mp-power.h | 4 +
> 2 files changed, 86 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> index 26487daa64d9..d05930f61f95 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml
> @@ -28,24 +28,15 @@ properties:
>
> power-domains:
> minItems: 4
> - maxItems: 4
This is not correct. maxItems must stay, but you could drop minItems,
prefferrably in separate patch.
>
> power-domain-names:
> - items:
> - - const: bus
> - - const: g1
> - - const: g2
> - - const: h1
> + minItems: 4
maxItems instead
>
> clocks:
> minItems: 3
> - maxItems: 3
Same error...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-13 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 6:36 [PATCH V2 0/6] imx: add i.MX8MP hdmi blk ctrl hdcp/hrv and " Peng Fan (OSS)
2022-07-13 6:36 ` [PATCH V2 1/6] dt-bindings: power: imx8mp-power: add HDMI HDCP/HRV Peng Fan (OSS)
2022-07-13 6:36 ` [PATCH V2 2/6] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Peng Fan (OSS)
2022-07-13 8:29 ` Krzysztof Kozlowski [this message]
2022-07-13 9:03 ` Peng Fan
2022-07-13 9:11 ` Krzysztof Kozlowski
2022-07-13 9:15 ` Peng Fan
2022-07-13 6:36 ` [PATCH V2 3/6] soc: imx: add i.MX8MP HDMI blk ctrl HDCP/HRV Peng Fan (OSS)
2022-07-13 6:36 ` [PATCH V2 4/6] soc: imx: imx8m-blk-ctrl: add i.MX8MP VPU blk ctrl Peng Fan (OSS)
2022-07-13 6:36 ` [PATCH V2 5/6] arm64: dts: imx8mp: add vpu pgc nodes Peng Fan (OSS)
2023-03-27 5:06 ` [PATCH] " Greg Ungerer
2023-03-27 10:01 ` Peng Fan
2023-03-27 13:23 ` Greg Ungerer
2023-03-28 2:15 ` Peng Fan
2023-03-28 2:34 ` Greg Ungerer
2022-07-13 6:36 ` [PATCH V2 6/6] arm64: dts: imx8mp: add VPU blk ctrl node Peng Fan (OSS)
2022-07-16 7:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c0d236-49c6-7c31-abd8-2a083ca7ef8c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=aford173@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=paul.elder@ideasonboard.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®