From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdFPQGt (ORCPT ); Fri, 16 Jun 2017 12:06:49 -0400 Received: from mail-eopbgr30118.outbound.protection.outlook.com ([40.107.3.118]:52299 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750986AbdFPQGr (ORCPT ); Fri, 16 Jun 2017 12:06:47 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH v3 6/7] asm-generic: add KASAN instrumentation to atomic operations To: Dmitry Vyukov , mark.rutland@arm.com, peterz@infradead.org, mingo@redhat.com, will.deacon@arm.com, hpa@zytor.com References: <116e9ee125e74b1fbb35244c845cec1a5ec89355.1496743523.git.dvyukov@google.com> Cc: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org From: Andrey Ryabinin Message-ID: <52c19a08-0aaa-8ed3-1bca-782bf9cfbe90@virtuozzo.com> Date: Fri, 16 Jun 2017 19:08:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <116e9ee125e74b1fbb35244c845cec1a5ec89355.1496743523.git.dvyukov@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: DB6PR0202CA0009.eurprd02.prod.outlook.com (2603:10a6:4:29::19) To AM4PR0801MB2722.eurprd08.prod.outlook.com (2603:10a6:200:14::24) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PR0801MB2722: X-MS-Office365-Filtering-Correlation-Id: 69ea98f9-4a4e-4929-1308-08d4b4d1a8bb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:AM4PR0801MB2722; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0801MB2722;3:6sgulaZ9/0+r4dQ0uC7nQ/Xr8X/oZWi+Uuk6I7gw4ihw5YyF8SnCbaXr+SIjpRk18bCxogp3U4He3osI0367UPSyAE0LelDtWQJqes8rTe9GTteEGSn+gIvVdsyagdUqG319/M5WIpfWrRBU/MDY7eCfqSmOS4HaM2Ljel2NF6RIqJ61gBhdj6x0yyCTr/QW17Oq/+1w7eMeqn3GiYQeU5yywcm/OCN0tm/K/NEB/LPLTkdqQXl8Vb7aK9G8siy+wQtFbiuSuVDSCGuNdwKt0rEE0EPb1l8qH+nGpRPp8ct0QCIsgoHE62xBLNIADgnPIR8EPe0aKq4g/CffmC3G7w==;25:K7Xb8gp5Yey2yADkfwesvL8tANw6E4ntdVOeME2mxs4a8y8t4oCRIxmOhWis7zg8xpXucIo1Os1qKcHcLdb8L/Dt+1SHJuDZw7A/t2uNJ6wdI9Hbk2Rj7iUBpY1e8Maw5h7NuDtOdpPEMBlVgSqFkV/Bly+dhksY+TpKq66HVLWEScOP4h7JvlciDaDhyVrR9LgpR1d6sfBpnihjE1eQvVVkUF94v00ym164hBxv8YqGmDlAmZD5B+C/OnIcmAI3eChEHjJv/PfTOCyJlJYszUpnBYH+mLmx2Ky/hW4KKypXJPDRiLVszvwRDLxZBIvb3qFFNZndvqN91LxljTWkYXeRyk6U4ltPuoCVR2U97FZfG5BJmYi5osHZpx9jptHHdDMuWpoq1NNMjTtJbITKmMK6xDzurAUqT9Al/klQVGiFoljxJ0PyA54QgOxXtkbWV1/+bKtsR5qRi6OdvY2OjjZvI6obnMuf1jebDzYeiZA= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0801MB2722;31:bzWnykDkuQL6V8ppHTASJl814ipo9/HiILaUacq831LLM4dh8SvHh0AzOnV7N7xMx8cJKiOE6S08OGFEm3A8lEea6fEPoUkS8iaYz+EB9tYgcfTbNQyLCIW5SZ0+i47ONaG8QQ1TqjuTYJVHUZGbC6u5MCRAY7THecF/0n7U+7rTeVXcRFegHoPSqKGq2un6vrgIYeVqfRAOKCKlso8eMNTWZCm6e97tm67GB5xmvJn5KsRA0rMw9xr7WJnlbcLtqErzkMsqQfaxbXLO2ceBIA==;20:kie7UVeHK9nGobR03Qtp3aad2fA3CjsNFk3qswUGMGdKjDETMKgHUzU30hPL3dbECZbDo8LtrXKsdkI+RVuCzOiqQQOWKqd4eHJJae2XcaidaEuGgb0N6vnEEhxRAvYO+sBUv6clQRUtr13pkxA9ex50W9g2ZT/ucFgzNMjfdV84s6lxkPl4cnTirnjRKozQ164MdF/CqpKbd3R5prbd/FUoOVsNFl2WWABlOONXVt5RSRKUpPHUKr3xfMB/wGDlOC6Ogy/6WtemL4qu8hsjHhJaEs//xkN6jEvQloiJ6aFJqZLAaheX2b7pmGCxnGXKqodPPwMbLJvs2/EH3h/1c4M9K3B3fNjWqH7+pLfreh3iRzUIusaymAtu49MnrKgc3iTdYSatCfwhSyWlRAqinX7HQHl7VP+hB+Kk9hxkuSY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(215639381216008)(180628864354917)(9452136761055)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4PR0801MB2722;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4PR0801MB2722; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0801MB2722;4:iEwhHF8DeZc8xlTrp93C60+Yms9UwmkhO7q5?= =?Windows-1252?Q?H9JjovIXGipQgNl9zG6exDbAUprstFq6jI95MW30dmyxuQCX14B9wyRm?= =?Windows-1252?Q?jKJsor0wf3j4GQZVmNsCQPfdYfxnigpijkJqsu1wMoltfmxwPuPRWdR3?= =?Windows-1252?Q?U79EdrfMnB6s0XUlcR6cu+XTcJJUjSvp7t23cQOXpjZdrNns+89JyVbP?= =?Windows-1252?Q?FX6SkISqV3t+am1hPvlA8EU8ViKQefcywenz+yHAdoOpbXlWNIpY54xv?= =?Windows-1252?Q?1u9E2F8YgHkk4Nc+ZPaJXmkIys2+RqtG7oKCUObFG5ECyYkJTa8bdP4T?= =?Windows-1252?Q?Ae1E2yJti4a63pUCKgX5WRsXPJWdLX6kPkKr6qi6zFJn5jQBHQoS7GBz?= =?Windows-1252?Q?5nVul/Ukp45mW6Xeml8edyApjRztBi0f3FEbqEFskuvjsArq6xxMkk/n?= =?Windows-1252?Q?DIJVugHxt5ABW4DwgYHYu19pvVi1ZyJPOeE9Qldtd1X8+Ae+Ogn3b2MG?= =?Windows-1252?Q?w6ZwXneaVkBeglz8sZwKOdfAQItPXBzr6JPUNUfAQyjBcqTB/a03bcMX?= =?Windows-1252?Q?Jj+JOp9zg0Xkhr4UL1lhl9fW0PIX1zWi84rNUfEFjPVkm+Uj26QHVUMy?= =?Windows-1252?Q?BxJXGfLGJDDNO8mkN9wQQCi4razOlpQOwtBLvhQWOe61v+CbnNpiUaVR?= =?Windows-1252?Q?7QC3K50BozaA7O4tIDNFUK6nSKL/+x47mB0d6DbSGNxphte7dvPjJVVG?= =?Windows-1252?Q?mEBHUKP4Tbf+rC5ZwhA8IWTLdNj+JhfmK+p7PPm8ssO+cFy4KPHs3vbf?= =?Windows-1252?Q?v1OOf7aits2EGo5o0K4U2nx3NCanz5ZeA5dqDhE3f+sjALGjTaZ60sqV?= =?Windows-1252?Q?5fMmDs3/zuaTFpvYcD5y7yPjMhobExOZ3M4yRBF378MSTDwTM92VG6R3?= =?Windows-1252?Q?RkNJS388zG64uXVLRvU/qWuhlyqyACPwJJLY7ymWsQVjeSvMUVhkgHGA?= =?Windows-1252?Q?yBqtzCOm32SYoEYYxDjK72qpmBSMrMjklVNdu5ikpxdxjzXBMyoJDOuC?= =?Windows-1252?Q?Qn0bVYfHhEO5iJa5lkrklARQka7l+Fp56V+0aEsbupdhPWuYs+DvONHR?= =?Windows-1252?Q?1XdCqb/qi/JuSXX4/77AZ7HNCvL37C0uKek2yQ+VNyxWN5S03gAKQqDT?= =?Windows-1252?Q?Afmb6nlk1ckLhv5w2zCFhxHnXIcGtuGZvoVSJqBLgYLxR/8YB7wPWL6N?= =?Windows-1252?Q?EQTmriSuo+dNo+SPu4yrg1tRCEOk8RKNGKs3MkV1nNjIcztMWmgFDC4a?= =?Windows-1252?Q?Ak7rAsjRlx2kvLIYoPOCDqa6cEJJgwQDob7JCrscuK8WFwO/Dwr58zRx?= =?Windows-1252?Q?Ryp0spOWWMPNjnCcCChdmA7N66ImMoBQGw=3D=3D?= X-Forefront-PRVS: 0340850FCD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39830400002)(39410400002)(39450400003)(39400400002)(24454002)(377454003)(478600001)(8676002)(2950100002)(65826007)(86362001)(81166006)(66066001)(31686004)(47776003)(42186005)(31696002)(230700001)(23746002)(6486002)(77096006)(229853002)(50466002)(5660300001)(2906002)(305945005)(53936002)(110136004)(38730400002)(7416002)(7736002)(64126003)(33646002)(6116002)(6246003)(3846002)(189998001)(50986999)(4326008)(4001350100001)(83506001)(53546009)(25786009)(76176999)(54356999)(36756003);DIR:OUT;SFP:1102;SCL:1;SRVR:AM4PR0801MB2722;H:[172.16.25.12];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0801MB2722;23:vxdob6yY4cdnmfT9bpKLWxgpgPh3tRX+bV+?= =?Windows-1252?Q?ERj5GSc+MVd4Jq0T5zsaAlVA9k++1VBnLWmhMrX1Uidv13+5ih0hwBjK?= =?Windows-1252?Q?+o3dp+fJX7P/fLNlPWp2IYVP1HfuZpmQjZkDnkMpo6opuZ5pchWqyWr8?= =?Windows-1252?Q?VWftFPB2xkUmAmQb5S4wQKP3+pYZhER+Xnw3ijQHf4nLeAd2TRGR0eGC?= =?Windows-1252?Q?vXMJhoIHsmuTlWpE3jLMeMMkdWO5SPlclI3Tm8PNYTVZ4Se/Xai4adZX?= =?Windows-1252?Q?+QBJXH2048/+rP74HLTsLqtUKGnAPnonDPp/SCjfq+vIvvnUewLc1Ga+?= =?Windows-1252?Q?CjNTRxbLx9tAqxwvBjhXPCCpASjgu3VC0a2xgTfxTgbYzIteBxk2U/mz?= =?Windows-1252?Q?gssDe7ItAZccObSuT41m5Sc4YNsejLM8YvgHwTmFRlQ3FDYv9u383nJT?= =?Windows-1252?Q?tnfOU/pk9CkFgGzjtqsdYkODW/abhgA8RovFVqeA0Oviwxz7kmor7qun?= =?Windows-1252?Q?3zFiN62DO55DZYTwcIK/o29zqYahUcZPnfNSwSY3IbWrYtY8q85mwycT?= =?Windows-1252?Q?YHT4T+UnNBX+wX1JhPsL0x/69E9taqmWyJtdKBOK2nEoe58WFdg/hMCv?= =?Windows-1252?Q?rxuEjINtlYMWJavLjUzyngM960W5UxGK7GV44a+T1zprHYJdyZK0zSwq?= =?Windows-1252?Q?TrhenQaJkaBaZBaBDqqPzz0wjeiU0y+231aslKO/cB5+kgQiIcXtHJgX?= =?Windows-1252?Q?0VGuncw1mhbTlvlwvFeTWQgT39KG7dPHGjDE/BbcrOWri0vM9jnWHpHV?= =?Windows-1252?Q?r8LKNjChkY8EmePrD1I4c5+i+NtiPFHO188VMwLH3IqKZ+N5C4i2MglE?= =?Windows-1252?Q?T2LsZXwDn9x6z7lTpAuFkdidM69YysmnNEL5c6rp2qF2KLI3jrE2cGmy?= =?Windows-1252?Q?oF8vQwBJoICx1MoU1Z0WuCbh9D8FxDmz7RkXp4z4NerjN+sBxkBjY+aD?= =?Windows-1252?Q?DiL/rXesjciepYhS5Ngzo+ceJmFXfKHS0OeeOGf7ZPKC+P19WCTN/lBs?= =?Windows-1252?Q?91ohAXcmJM5CZBXjXET2J6Ho9C5e+QcfZE3WL0gdwf1L2lRZCRDA1Aye?= =?Windows-1252?Q?sEQf8soLBEN9rKgomzrYL3beynCzKKxxVU3MwC69nF6vYw+LxMf6Bwk4?= =?Windows-1252?Q?KoVBxtPi3LIhYKOv3+J7ORhBpKqCDARiZV4+stzblrPWrB4Np0eZeGj6?= =?Windows-1252?Q?g7NlHk62PD+AwZuhaxAy6Rqf6WT4uFtC5q+89uZrbn2fxGAJ3xI+fb/i?= =?Windows-1252?Q?kfn4saAiRcasJez6pUFqaffQr3Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0801MB2722;6:qB/Azh02zHPicXljMU/sGeqH2NgyJQ4tJMq1?= =?Windows-1252?Q?lJa0gXAywh88lb5Q5XXQOm1ivJAshKdn5ewT5CtSAZ65Bq2EZy1zH7lN?= =?Windows-1252?Q?K8wIFS3rLmyKXEnC/MbcLLbNGi6rzfJNfeHq4foOm/nQclwzV/QX+nkn?= =?Windows-1252?Q?lxUEIK4BHWJZ/B5hcGL8BSMTWEnqaT8Mw3MEzL3z6A3+AzOfRGFJ0ste?= =?Windows-1252?Q?vokeTs0Wf1EV2BEDLM5D/t2h49J/jxV3S8ltou8Wergr8AOnWCnYLkEC?= =?Windows-1252?Q?paa44UctIT2bvpH6Jj8xokwoZair0zs00/BsMNLad0Wm3afY4FolFpal?= =?Windows-1252?Q?TrwTPoBRkGSBvqCgxf3cAVXJkUTnN+uZEe0Fuxtz+tX4eUYP9yiWy/G3?= =?Windows-1252?Q?brmfckEUTzkox3sX53XDyCsu9X9NxLfnPUXnVuFsViE1l56HIruAZwLW?= =?Windows-1252?Q?MkrepaNO1cK5QiCBq53RKznzNQhQyJGomxQm7JlJ4Aso/SFSS+Bnvvlj?= =?Windows-1252?Q?Qu1kWAYmdKyNUqhaLAlFT1WmWy4GH9kYtihOm2y5DWFfVCj0KU/1HLwv?= =?Windows-1252?Q?7Zi7oVRE4lMFrFQvNAw4mbuhVc6lFZrfwx5jhyZYksa6A9HzDEFB0PvY?= =?Windows-1252?Q?1HpVKtOdhhMqHuFcB5IuE1S1oA8k3j84XTiHphg55a1DpBp/CdRT9qgP?= =?Windows-1252?Q?THXx2nUrX5WU/+goDyouP2dFDw/89Vf5yghyZhr2QkjDFEgFfpoipqHr?= =?Windows-1252?Q?OZrB6qq1V6qPlh/aTX8thkr9uAdT7cwDnyTKa/2nLL8JV6Okn4f+pFpp?= =?Windows-1252?Q?DeAVv+3BdW4bnZ2XuMcIYrbhzCHkiOPYPrJnVlRtW5Y1mHVv7izYssDI?= =?Windows-1252?Q?AyPuQOaF99sLnSCsMRa2HW+bStFAqGgZgjPlqaHUeWI7bZ82e9R/coNq?= =?Windows-1252?Q?RPZGvebiZNPajezuiR7oJtBjVj1mKfCB7Otd4jLff/KCo+9GKIPVz/qR?= =?Windows-1252?Q?1RWa56xO0R8xZLtOAc0tGZ52C/iZdk7Hj/lC7BrmqXN4vkLyXe+aMZE1?= =?Windows-1252?Q?oyOTs5PeHhgdXds=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0801MB2722;5:3GbVZRZfdw2aQiH0gWy8gF+i8/EKrLpoMKnS5/Lj9DgOGdmdOWLpw7pgFMYOdptrvVqJH4116CZD6TUhtQa9g7aJX9EfV+WzYSfGYOOQUyHTL8p1kfcqY1+iHqehFmhCXQFNBX+MwuHJoAOWsCsvrQonr91DCANtfsoyT+2L4t8wV5dp+2rpqC23dTMYDkFcqKtgavmmwgn+sxhD3xj2w2vZIXt1kSQO3BZ+uHKPvxdIHEVbAJ5SAsAmz+++JOGQdlUw2SXA9aE9iHn+ktfnh/geVJu5/zUucZaeMB09BXiFYTOkH4BiOENk2yj9mv6RUWb4Rrjw6+LPKHKZ355M8zqJOIf9ni4tQzBHITm6Y8nYk1IBanL75d23gZ5MsPazq7HAQWb1PXiA6X76SsQ3k0oUgRZ7gsQCjUIHmcohq7xu3cbeHGIJOS3nxvlUoMPruHGF0NRheMDN4EPOCC4hBc2hxKuj2FCSOroREItXODA6xoBdKEm53UoqlLZJe7eR;24:8hX2et71D+hDCaODa+rR+wOtZbNQ0XnGDBtjxUR7U2rMMSxeMEpbrdTtrADbBQMc9/2HxkSPwBUzGZICiixJTNiRkg2+hTTkYLyN0/XUlak= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR0801MB2722;7:jcd+1uoQpvtOGbt1Sa9LQLmV3UML2KinrJPCL6GDet9boTtIeceU219PeFm1TZN19oX851mYjlZdGfKYVXQgfkPxuaK/zNlMySgu48F5AQKqq43UOJYe705+JkK6KgKiuSl/B+6YjAXNTeyFlw6Mfe/MvFjjaCU/5BzVl05yz7Moadpyj21aYq1e1ekgNdoKl0et96aohvBnCh9Ar0RFxnjm4ZeWLqB8KrNHEHTbdBGXT3/roveLbnLGVgViGAWvC15uQ9fNNWozoGVCddcuTameUcXVm/N8p/LLfCPAfq8oWbJf250CGlm3eu56VS4cDka6mEjZq1rRyiJjUFcnXXAzrIO/pOHa6CGVNEagPeGNKGI4sBT0IgUZfromT0MvHb65Zgeubym5CpsojKI7Lzc120D4ARgMKLGPYu/EjgmRouLPoaGYFykCrjYnd9nVbdc9fY58X+dgheuDz+JNPAtIuiMJhOs3TcRCUPvDPoztnDdbjcQ3BMgRYMQv2Io9lMKso9OJviB8bdIOn6QNSc6/tRbUxyD99QjPbaO+ybKACLDimwWdacthlGAkW8mErvyODhj7b4OzgBwAJq8T624zbxCaRmIE4NyuO509pFc+ajbykLsPSZcgKZuXWEM8wZ/q0szuEGunS20pXeDJlKYjRTpNnBMEZoRIEgpi84Y+9wQLrL7aeou1UQAW8kZolePamyRdBDPqKvYzsOmEoYD+mUQlu7iXAS6gr2LykmNCMoqJEObSqLCYmSAN4nwV10CV4kWCvpp2JAJFeKrtxuBhg4UR98hdjPx2OgkyB+A= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0801MB2722;20:wrpEF5mseoV810/0hB1mfYn5iH0WyQKRMAxfZt+dEspRlIEZcKJSH3yuT0P5VSdc2V/xKEuD+4koUMPgYes9hncK0wGw2GadASRszWkBe8BQKg52UcI8LzZFPiHDbCWkgBOg8L7WGZd1LfFnxWH+3YBHmJURlTue8m1TLVqyVCE= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2017 16:06:32.6672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0801MB2722 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2017 01:11 PM, Dmitry Vyukov wrote: > KASAN uses compiler instrumentation to intercept all memory accesses. > But it does not see memory accesses done in assembly code. > One notable user of assembly code is atomic operations. Frequently, > for example, an atomic reference decrement is the last access to an > object and a good candidate for a racy use-after-free. > > Add manual KASAN checks to atomic operations. > > Signed-off-by: Dmitry Vyukov > Cc: Mark Rutland > Cc: Peter Zijlstra > Cc: Will Deacon , > Cc: Andrew Morton , > Cc: Andrey Ryabinin , > Cc: Ingo Molnar , > Cc: kasan-dev@googlegroups.com > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > --- Reviewed-by: Andrey Ryabinin