From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C374C4332F for ; Thu, 2 Sep 2021 22:02:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80AB460724 for ; Thu, 2 Sep 2021 22:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347362AbhIBWDp (ORCPT ); Thu, 2 Sep 2021 18:03:45 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:60398 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232827AbhIBWDo (ORCPT ); Thu, 2 Sep 2021 18:03:44 -0400 Received: from [10.172.193.212] (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 0B9CA3F042; Thu, 2 Sep 2021 22:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1630620164; bh=gsJFTztF9GceLOLBONfz4P+vNdtOnoxVKuUu34GIhYs=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=azlAvWbmqeT774jKollb4hL0VVErvYvKsaWz9nfuDtx7liu2sqSSR4h14RzzXOlic o5eg2QknVstBjiDaLl0BWJ6GWoqowQoEBTRcW2Tx87RJZkWZTwXP6YoRA9rxdy9wPx xJWGjslti7MfRAeZAEmIY8X9T8elRB8bdpKTVajHcdk4GNBLV1y62KJqngAB2yq3T4 W9DKJmlWS3pBHdDTAgvCy9zR1UtJtD6BDvD0+3B9HziYitj5Cs3B0IobSRTV8RkV9m F7oyM8L6WTdtGesuQqh70Xx5tGYB8GR6QTpUHbqr3gySTJ0FPk88qx+rAWfo6tY2FT ZVeFtdCBQhfQA== Subject: NAK: [PATCH][next] media: pvrusb2: add newline between two statements From: Colin Ian King To: Mike Isely , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210902220112.55824-1-colin.king@canonical.com> Message-ID: <52c324ad-2467-9edc-c386-bc5a086cecbc@canonical.com> Date: Thu, 2 Sep 2021 23:02:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902220112.55824-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2021 23:01, Colin King wrote: > From: Colin Ian King > > There are two statements on the same line, add a newline to clean > this up. > > Signed-off-by: Colin Ian King > --- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c > index d38dee1792e4..ca00b7fe1e7f 100644 > --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c > +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c > @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag) > enable_flag ? "enable" : "disable"); > } > pvr2_hdw_state_sched(hdw); > - } while (0); LOCK_GIVE(hdw->big_lock); > + } while (0); > + LOCK_GIVE(hdw->big_lock); > if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret; > if (enable_flag) { > while ((st = hdw->master_state) != PVR2_STATE_RUN) { > ignore, V2 being sent in a moment.