From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C32526E165 for ; Fri, 20 Feb 2026 07:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771571284; cv=none; b=NNyg0uXpbNCDKWFZMgOKxHrheZJ0gZYpcZ1BY/V/zqmHro9OLy9+ZLlAbT6xUOSYXei8vkTlQyrMRPh+G7xheB8DPEePHgaNjg3827QqaeDAus1eVw9NoLUr6DbfibZUOnH5p4loTbxQ1fKp03xDe8A4ASKGgIWD1DqkXQQYwOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771571284; c=relaxed/simple; bh=8hHq0y4yqjJXzFG++LTN+ocSd+DjIB8+315KMSLtfBs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AN35tk1a3KSjhhG9XLwdKsnLgI3Kpg+nZr+K4q/cwkFVwPuHfijhr4MnnZmKu91UULrAQuesEnYo7ZA4qq/iv2MOa1NdDDsJwaTphEj2vR6uu/ctrqOgWKyXGOL1PWKUhfoM+ZnCRQnjJxhAqmjgi+Tj/SaS7aWxaNHIsUyvwyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZjrIxvlb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GfcV1Gwo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZjrIxvlb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GfcV1Gwo" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K6Z3k34000577 for ; Fri, 20 Feb 2026 07:08:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VLhd8JXEVDO9ThhHOsBw5LfzKqFkIBqhG+HhAyr9PQo=; b=ZjrIxvlbKPwrbzop 8y5VrS3raHxn8fvIT8XkqJzMKp+XnOXx9ROFEIjdl7fVYLEgFDDj2rLFjB+TsW01 3w4YnvxJJX92pj9qsAJ2Sir+3mbWI9Sws2k9TUtXqfhRj8puLAo5Jw6y+ceUQSgR hRFWeml5UH3P8cvlbPFKnd/BAYV7JYznWAtnlQvmfHGpmgnMOcaXAoM19pa6ojVh QzCnIudZDfOuNIXcFjQ4U2PBKyKcBQb8qKo3x9NUa9lDKDCw0rWsYIn+MR4BlltK SYFic7pN2FgVeWpv4Z3rnoVQ/GpwWVsUZ5QMRVTHDjyt2ntTpVnRZT+D1nuw7ViW i4Bajg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ce2ghtxyy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 20 Feb 2026 07:08:02 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-824b19d293cso842038b3a.2 for ; Thu, 19 Feb 2026 23:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771571282; x=1772176082; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VLhd8JXEVDO9ThhHOsBw5LfzKqFkIBqhG+HhAyr9PQo=; b=GfcV1GwoVfQeuHgh4DDA4Amtic3ZEr8AzfQjVXf/5QNfVWcukA/h6ttWS9SWUIRcDs 6pmT7QEx9eL9rVpc3Vy2U0VOxa2960Z8k6grBbxJ3Zd3QSt2beJo6FYKtrsb3A//4Zhl 17ijRnc2oaMturD5fU2m0YFDE98Px8r3ZKgsWc7DIOsPdkPDgkJNK+wPqq47focU1qFA 2Wrjpx2NnSH+k/jUrqUqqHCPQ8b1VAeMnH8XE4px6Q929Fv6eqU/rliouXIp/RbVTzVW jrx3KjKRtX8+1G53fRYTVxrA0c9QEqC557ULohCO6eG8M1+oRColFtNJskJEmoHgWe6F AjOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771571282; x=1772176082; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VLhd8JXEVDO9ThhHOsBw5LfzKqFkIBqhG+HhAyr9PQo=; b=c6ONYPFLBHzNOlICR9p1M2BB/9gcPE1Jqb1TCLTo372n6zSZ2PzQpPpoy5BIKhoRaH QqkFNtHfL/2BUCNDsNrqCm1s/3J7SwUaHG19doYNkIjTgz6zvXxHoIDhbNajRm4/AJ84 uPx3QFaXwB0nizUkpathUdZ1Iq39NQYq45vtmcGjKAaR9RTrJS6bfs/Z+EKMNGuBZd/Z Uzb1IvYNioTI+ZQJU3KwitujJw1Kyc0dUcCqwSAM7NGCwynmEqm7A6Owp8SiAGO9Lo2W EIX6cd0AwcUyloVgZAHXYTEG7FTfWmbRIhSyvFLqaRnJ6Tetdd41L1y3i1Kmof5IZ4Nn Z/Sg== X-Forwarded-Encrypted: i=1; AJvYcCVml6DevgFnWuX0RmVqsSUUpOwl5ecPylerLs2jXRx80KC+c98kiu3ATIAPEuhbB0gwd51PgG/xO//Lk9A=@vger.kernel.org X-Gm-Message-State: AOJu0YwarwXj7qE5ZR04+MSXbN0bfdCKf0Ej85d6IMfogURUh/Gxr36T 0xvcbGVq+mTLkPyOeKyp5H20B49VfC2azzPf/4h/pK2mpNrOV6cmv24uhX0mUGwmkPRmCbG/zUI Bjd8Q3Hik/IhcK867z45Dqt6P5YIE9mQSkIn1PK1nXVRlSc5iPfuMxm+yP/itMMX9muQ= X-Gm-Gg: AZuq6aKFxI0AvJoUAa+IRw2A0OgE8T+ix8JrllqtLQASl4szaDTRYpvoHh9TFfa+TCU YNDn71/AZDpd99RgUJaCWoThNjl81JDM635gP9zD+8aEV0+SSjJchOZD3d/gdakmX8o6dZZxsYI AZTIvPk4dEKU8Ytb8TD/qiYsydv1y7RP0RIugHCyHGAwUO368PeABV4rwvJu2c4xKPAMJpfnyPb 0GgjZADbWvPczmXF4i2uOowwO7d6rCeML0RkUqJfXm4Ml/iuyUY8BGz7Q7kVvdsajlMuwsl/Jcc mviVL+u/8t7l/zyu/zKR5oMB3Ohj0i7wdKUi1Z2weT71viZj1F5r9EDV2h7ATWaxp6uJvpj2gS2 XLqWOZqOkWWteCUvzOGAdLKt6BiW2r/qeURZER9c+0/bgiiVabg== X-Received: by 2002:a05:6a21:3391:b0:38b:d93f:bbf5 with SMTP id adf61e73a8af0-39466eb3506mr18203653637.0.1771571281805; Thu, 19 Feb 2026 23:08:01 -0800 (PST) X-Received: by 2002:a05:6a21:3391:b0:38b:d93f:bbf5 with SMTP id adf61e73a8af0-39466eb3506mr18203638637.0.1771571281345; Thu, 19 Feb 2026 23:08:01 -0800 (PST) Received: from [10.218.41.33] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a546edsm21922234b3a.25.2026.02.19.23.07.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 23:08:00 -0800 (PST) Message-ID: <52c46cfb-891d-49db-8d84-b8994bc9ed9d@oss.qualcomm.com> Date: Fri, 20 Feb 2026 12:37:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] arm64: dts: qcom: monaco-evk: Add Mezzanine To: Bjorn Andersson Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, richardcochran@gmail.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mohd.anwar@oss.qualcomm.com, krishna.chundru@oss.qualcomm.com, monish.chunara@oss.qualcomm.com References: <20260210103821.4169-1-umang.chheda@oss.qualcomm.com> <20260210103821.4169-2-umang.chheda@oss.qualcomm.com> Content-Language: en-US From: Umang Chheda In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: T7BCIDTkdpfr27Mrz2eNelBDc93oUtdz X-Authority-Analysis: v=2.4 cv=dqzWylg4 c=1 sm=1 tr=0 ts=69980852 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=GaVuqHfzAwwAF55UOU8A:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDA2MSBTYWx0ZWRfX6XoLBGG+xiV+ 0K+BxRqev8QYSuPQLAQVLtpNtHZUAlIU4s8FeUajcawjGi3y36fsaTeoHMCOIznw3eSPGyhNEmY 3Isy0wdDiM1TgFb3qurZiOxPj/RfTXn7qOWFpsbMZzleYwupNtErgQRUGklO9ykGIhOkkzMcomU 9eEYsYSOjomH0s2eY6NG3DPwItOq8NSIU2opDXiU3EU7MwfIFCuo0TKNQftarnOjn+xpnvf+g6x of/zmkAUy4f5IumnoI0VqOwioyedTRbRpb3A0FqkrZgRgE8lUy1ckRvV36dRaim1t4Gqb01l47t XMICAAz48xaoWHJG+5w+sv1dQkdZ1kYXJwF4Zxgku8B7Ou6bAW9p0M6GWMBnLThaDxYta7ztVQR lt6unzyCRZYrX1XBs7Jtp1H12Sc0Dj+aYU3prpPyb3D9UaNiptmA2fVsM149dOQ3FVhPK3TjroP wA5AOfSlfUZ/6ca14Yg== X-Proofpoint-GUID: T7BCIDTkdpfr27Mrz2eNelBDc93oUtdz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_06,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200061 On 2/18/2026 2:26 AM, Bjorn Andersson wrote: > On Mon, Feb 16, 2026 at 01:44:40PM +0530, Umang Chheda wrote: >> Hello Bjorn, >> >> On 2/13/2026 1:33 AM, Bjorn Andersson wrote: >>> On Tue, Feb 10, 2026 at 04:08:21PM +0530, Umang Chheda wrote: >>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-mezzanine.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-mezzanine.dtso >>> [..] >>>> +&i2c15 { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>> Do we need to repeat this? It's in the top-level i2c15 definition >>> already? >> Yes this is required to be repeated in case of DTSO -- else seeing DT >> binding error if these cells are not added here. Seems the compiler is >> not looking at what is present in the Base DT first and is considering >> the default values for address and size cells and throwing error. Had >> to add similarly add for PCIe node as well to suppress binding errors. >> > Understood, no concerns then. Thanks for helping me understand. > >>>> + >>>> + status = "okay"; >>> I presume this overlay is used on top of monaco-evk.dtb, which already >>> says that status is okay. >> Ack >> >>> >>> That said, I don't see a "clock-frequency" in either node, so I presume >>> you have an error/warning in your kernel log about this. But unless you >>> have reason to change that in your overlay, I think that's a unrelated >>> patch on the monaco-evk.dts - which I would like you to send, separately. >> >> Ack, will share a separate patch to fix this issue. >> >>>> + >>>> + eeprom1: eeprom@52 { >>>> + compatible = "giantec,gt24c256c", "atmel,24c256"; >>>> + reg = <0x52>; >>>> + pagesize = <64>; >>>> + >>>> + nvmem-layout { >>>> + compatible = "fixed-layout"; >>>> + #address-cells = <1>; >>>> + #size-cells = <1>; >>>> + }; >>>> + }; >>>> +}; >>>> + >>> [..] >>>> +&tlmm { >>>> + tc9563_resx_n: tc9563-resx-state { >>>> + pins = "gpio124"; >>>> + function = "gpio"; >>>> + >>>> + bias-disable; >>>> + input-disable; >>>> + output-enable; >>>> + power-source = <0>; >>> Does these properties really match the TLMM binding? Please double >>> check. >> Double checked on this -- all the properties match the TLMM bindings. >> > I do believe the logic is binary, so input-disable == output-enable (in > contrast to the SPMI gpio binding, where those two are configured > separately). It's not listed among the valid properties for a > qcom-tlmm-state object, but perhaps I'm misremembering how the > dt-validator uses those properties Apologize for the earlier comment, I agree it applies for the SPMI GPIO. I will remove input-disable and output-enable properties and add output-high which aligns with the bindings. > > But there's no "power-source" for TLMM, you should see an "Unsupported > config parameter" in the kernel log when you try to apply this setting. Ack, This property is valid only for the SPMI GPIO and not for the TLMM GPIO. will remove this property. > > Regards, > Bjorn > >>> Regards, >>> Bjorn >>> >>>> + }; >>>> +}; >>>> -- >>>> 2.34.1 >> >> Thanks, >> Umang Thanks, Umang