From: "Wang, Sen" <sen@ti.com>
To: Wentao Liang <vulab@iscas.ac.cn>, <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<zonque@gmail.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] ASoC: ti: davinci-mcasp: Fix runtime PM imbalance in __davinci_mcasp_set_clkdiv()
Date: Wed, 16 Sep 2026 13:56:58 -0500 [thread overview]
Message-ID: <52c7da0e-a8c3-44bb-b3c5-9df082f7c7aa@ti.com> (raw)
In-Reply-To: <20260916073136.1971673-1-vulab@iscas.ac.cn>
On 9/16/2026 2:31 AM, Wentao Liang wrote:
> In __davinci_mcasp_set_clkdiv(), pm_runtime_get_sync() is called at the
> entry of the function. If an invalid div_id is provided, the function
> hits the default switch case and directly returns -EINVAL without calling
> pm_runtime_put(), resulting in a runtime PM reference leak.
>
> Add pm_runtime_put() in the default case before returning -EINVAL.
>
> Fixes: 4ed8c9b737b6 ("ASoC: McASP: add support for clock dividers")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Hi Wentao, thanks for the catch!
Manual runtime PM reference is quite tedious and results in reference
leak like you've pinpointed, maybe it's better to convert to a
guard()/ACQUIRE() based approach in the future...
Assuming you took Greg's input if you need to submit a V2:
Tested-by: Sen Wang <sen@ti.com>
prev parent reply other threads:[~2026-09-16 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 7:31 Wentao Liang
2026-09-16 7:53 ` Greg KH
2026-09-16 18:56 ` Wang, Sen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c7da0e-a8c3-44bb-b3c5-9df082f7c7aa@ti.com \
--to=sen@ti.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®