From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: kvalo@kernel.org, sebastian.reichel@collabora.com,
erick.archer@outlook.com, megi@xff.cz,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] brcmfmac: Add an error log for brcmf_sdiod_ramrw()
Date: Mon, 14 Apr 2025 11:28:17 +0200 [thread overview]
Message-ID: <52c832ab-1e67-410a-a0f0-91703d24c9c0@broadcom.com> (raw)
In-Reply-To: <20250414074232.2342-1-vulab@iscas.ac.cn>
On 4/14/2025 9:42 AM, Wentao Liang wrote:
> The function brcmf_sdio_buscore_activate() calls the function
> brcmf_sdiod_ramrw(), but does not check its return value. Log
> the error message to prevent silent failure if the function fails.
If the reset vector can not be written to device memory the firmware
will not start and we get a probe failure. While it seems useful to log
the error I suspect that the MMC/SDIO subsystem will also provide some
feedback when we can not access the memory on the device (SDIO CMD52
failure). Oh, well.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2025-04-14 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 7:42 Wentao Liang
2025-04-14 9:28 ` Arend van Spriel [this message]
2025-07-23 8:24 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c832ab-1e67-410a-a0f0-91703d24c9c0@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=erick.archer@outlook.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=sebastian.reichel@collabora.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®