From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Christian Benvenuti <benve@cisco.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
<linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Nelson Escobar <neescoba@cisco.com>,
Sagi Grimberg <sagi@grimberg.me>,
Yishai Hadas <yishaih@nvidia.com>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next 10/11] RDMA/iser: Delete useless module.h include
Date: Mon, 24 Jan 2022 02:18:27 +0200 [thread overview]
Message-ID: <52cb0f32-b705-8d60-71b4-350cc26c5a4b@nvidia.com> (raw)
In-Reply-To: <bdbf940ca5edbbc649153fa15737b779c073c498.1642960861.git.leonro@nvidia.com>
On 1/23/2022 8:02 PM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> There is no need in include of module.h in the following files.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/ulp/iser/iser_memory.c | 1 -
> drivers/infiniband/ulp/iser/iser_verbs.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c
> index 660982625488..f1fd05d8609d 100644
> --- a/drivers/infiniband/ulp/iser/iser_memory.c
> +++ b/drivers/infiniband/ulp/iser/iser_memory.c
> @@ -30,7 +30,6 @@
> * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> * SOFTWARE.
> */
> -#include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/mm.h>
> diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c
> index 8bf87b073d9b..8893bc27d8f5 100644
> --- a/drivers/infiniband/ulp/iser/iser_verbs.c
> +++ b/drivers/infiniband/ulp/iser/iser_verbs.c
> @@ -32,7 +32,6 @@
> * SOFTWARE.
> */
> #include <linux/kernel.h>
> -#include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
>
Looks good thanks,
Acked-by: Max Gurtovoy <mgurtovoy@nvidia.com>
next prev parent reply other threads:[~2022-01-24 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 18:02 [PATCH rdma-next 00/11] Delete useless module.h|moduleparam.h includes Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 01/11] RDMA/mlx5: Delete useless module.h include Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 02/11] RDMA/core: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 03/11] RDMA/hfi1: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 04/11] RDMA/mlx4: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 05/11] RDMA/mthca: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 06/11] RDMA/qib: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 07/11] RDMA/usnic: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 08/11] RDMA/rxe: " Leon Romanovsky
2022-01-24 1:19 ` Zhu Yanjun
2022-01-23 18:02 ` [PATCH rdma-next 09/11] RDMA/ipoib: " Leon Romanovsky
2022-01-23 18:02 ` [PATCH rdma-next 10/11] RDMA/iser: " Leon Romanovsky
2022-01-24 0:18 ` Max Gurtovoy [this message]
2022-01-23 18:03 ` [PATCH rdma-next 11/11] RDMA/opa: " Leon Romanovsky
2022-01-28 17:05 ` [PATCH rdma-next 00/11] Delete useless module.h|moduleparam.h includes Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52cb0f32-b705-8d60-71b4-350cc26c5a4b@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=benve@cisco.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=neescoba@cisco.com \
--cc=sagi@grimberg.me \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome