From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbdKXJzS (ORCPT ); Fri, 24 Nov 2017 04:55:18 -0500 Received: from mout.web.de ([212.227.15.14]:55240 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbdKXJzQ (ORCPT ); Fri, 24 Nov 2017 04:55:16 -0500 Subject: [PATCH 1/2] ASoC: wm8903: Delete an error message for a failed memory allocation in wm8903_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jaroslav Kysela , Liam Girdwood , Linus Walleij , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <52cba9de-be47-1518-20fc-897967686bf8@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:53:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:/CjsGOrDAAtgfofBOr7b9dNueBsgH8H/Eq8iv6bUstnjix2zKgt ygV29HkV0yflE8o9QQLYhFZ8WlutVrPgQt9K1gPhlMkRAR8J4yqmEkWUHNmtB/rQiE4XXTL pm7y+8FQOeGEgdRi1VX5S0Pkp7xgFXeMjV36QweO7P32KxV09cpCt1yNI9+KAi8thfxnJiU XNdcpis7mbmm6+lyzuZVw== X-UI-Out-Filterresults: notjunk:1;V01:K0:k7V5B0igKr8=:vET1BUg0Fud9DGJhkR/oKk 4kbvx0x3ohYaD3FeWwTnfzoRFnSZdG/RkPrH96JdvkUvyv1mN742DJktHd8roGfW/I9viLMOf cXySzUwFZ8yqS/jL4z+pPGvy4To0t5RagxEO3rs8OlL54hJoM626p1AcxnkWxnGAVfaw9ZSZA Z0Cp7lbwBJhpWqgdwjfmU0U1T9dR/Kyed0W4kvl3Xn7d7AYlmMMIvCxHVZjK/TszraSs3u0l7 Mzy/eiT36y7n80bhQNc3YgVH2A7Iv73xcDg/Ek0ncYeb6GSD92VT4tv3B6c4T9bLFGrcRqLiR +2bp1opF6hh6udjQYev1Yg5/92T2tlfgTon5qoOIEg7CC5x+/RjwfK3YzvSaThNFMhqYaNs2+ 2ooEwdOt6jmNtC3fRPyKDFD6esce0TURCvZ2Ww7s9RsV3NTzlM86whX9X0mWJYDOUkQ6g1QUf G1Zo+RvwmiGEAvBphMOYSJp2CVZcWMsJ5B3epKm7ybs/kJxPyUkvNdIf6If4+cXnTmkjhFog9 QrZXEVBOz9mk9oYndINGh0MGRwDIikr1kkOFaQesPWxuenvLjtTsOCA4ETIxct+ZjiNq7/ZO3 q8CUDJ7Cx2n0lA2FH5C+NC0nMFY6UexJc8Hgz+xIZ0Rk1nayNna8eBm00IgLzxZFgIIDOTCtK J2sFkvUvBqCx/Kb7/3NV6F5MCUXRPRJZcxo2mvpZDALy73WHCeW44MAXzR/xoYpapJsc/n5mr UW0UXCpkWeWCL4hXoNa5cYNxC8iXKjMEIsdK3BmOFTwEMixB6UacfgSPgf3HmK24Fpcezr2E2 4n/pXM/rSClxnoroiKoqO2Dg/mbA7D5Pqkk95B9lhtp6qmiN/HWN9pT+xTOK4LmnpKnf3DF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 24 Nov 2017 10:05:43 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/wm8903.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 237eeb9a8b97..51eb7d61d446 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -2020,10 +2020,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_platform_data), GFP_KERNEL); - if (wm8903->pdata == NULL) { - dev_err(&i2c->dev, "Failed to allocate pdata\n"); + if (!wm8903->pdata) return -ENOMEM; - } if (i2c->irq) { ret = wm8903_set_pdata_irq_trigger(i2c, wm8903->pdata); -- 2.15.0