mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Manivannan Sadhasivam <manisadhasivam.linux@gmail.com>,
	Can Guo <cang@qti.qualcomm.com>
Subject: Re: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c
Date: Wed, 22 Jan 2025 10:39:18 -0800	[thread overview]
Message-ID: <52d287b6-f6e4-4644-aef8-2c22bff59613@acm.org> (raw)
In-Reply-To: <20250122143605.3804506-1-avri.altman@wdc.com>

On 1/22/25 6:36 AM, Avri Altman wrote:
> +static ssize_t
> +clkgate_enable_show(struct device *dev, struct device_attribute *attr,
> +		    char *buf)
> +{

The above formatting does not conform to the Linux kernel coding style. 
Please fix this, e.g. by running git clang-format HEAD^ && git commit 
--amend on the git branch with this patch.

> +	if (kstrtou32(buf, 0, &value))
> +		return -EINVAL;
> +
> +	value = !!value;

Please use kstrtobool() instead of the above code.

Thanks,

Bart.

  parent reply	other threads:[~2025-01-22 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 14:36 Avri Altman
2025-01-22 17:12 ` Manivannan Sadhasivam
2025-01-22 17:46   ` Avri Altman
2025-01-22 18:39 ` Bart Van Assche [this message]
2025-01-23  7:31   ` Avri Altman
2025-01-23 18:37     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52d287b6-f6e4-4644-aef8-2c22bff59613@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=cang@qti.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manisadhasivam.linux@gmail.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®