From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DFCA191F92 for ; Mon, 20 Jan 2025 07:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359740; cv=none; b=ZAIVWqbLH/Ep2cvMmLYwPEqS4GlKBAhvaz6ti19muaY1YkW/ITQwfUz7m5LpCq1uxi0XidXBhuTMiJE5F2eZCc0YPE4y7EbuCgcdDbXUr2+7+nrAyzCWn9YhZrkWuv52Otxf0FjCHRtL7g42K+DJxV98+4KXtbqM6wCJA4rDpP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737359740; c=relaxed/simple; bh=bxWH3/6qfQSNTHxmIbnok3RYqqIGt5xx/k3XuI4dzxs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cQ2ciN/7LpSV0eF8jAqym4NUODCgCpsfMQQJPp31zxkoEByMpPR0c4WXFeTAB4UkzcgWN2g0gi4N7BztKCg/D7Auio5zk0bF33vMfX3czwhUr7tlM7hXGOpvBI0HazOuA5B/+rqpB+Pior1sG24FoncCw+Oj+TCnkneFlKml+0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IMQiG4QO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IMQiG4QO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737359737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a3N94IRnRI4+k4ziXJC8EQ9kVE6XhyFjtJG48xsVZzY=; b=IMQiG4QOzU2117hyHQquYNrMl7KyLbDwCAkLbKyVvxViOvRfq0IZFB+jcFZXPcrA9hlmZi 71uaEwFm38a1iwZoKcHMLVV/kG23dpKTWWMejLV76uQj8SDJiVazpmc8tIJ6eiUB6ng8/d TUJX3Ihp9QOgV5pksnApVtsIU49h0Zs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-52-2klAOVVwNQGkAvKhriWe3w-1; Mon, 20 Jan 2025 02:55:35 -0500 X-MC-Unique: 2klAOVVwNQGkAvKhriWe3w-1 X-Mimecast-MFC-AGG-ID: 2klAOVVwNQGkAvKhriWe3w Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38634103b0dso2565422f8f.2 for ; Sun, 19 Jan 2025 23:55:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737359734; x=1737964534; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=a3N94IRnRI4+k4ziXJC8EQ9kVE6XhyFjtJG48xsVZzY=; b=vVSG4XQX/FxuVI/wZRYzZAl54S7D0AYvmVdvVOkKA1MeZ9uRMF5WCqfS+vdw7BGS8b WLush3oIViedXVevZij6TN99rMNfNtzQD4dVWaOr3Oe2l1bSa4xSevFcS0thV58zJ/Mr tQ2je0Zki4P5IhAlp00UIlD2fsj2Cresd+j+uiExwE8kktEIqU0EpMP7iANPV0x4E37z 4KByBelaXZtKZWkLNeyayKxYbAZxZ1EjH7CXLgi+pCw869SSCxJowDHR1ILNSEY8xg6W wISTXKe/1plIAXjlYxwdWpyAi+gcBLXNSx5kp8yh2ZfEHFymUx7WOjvVeYBsZgxUwlRN pVKg== X-Forwarded-Encrypted: i=1; AJvYcCVgWKYOXjOMrrLAmaI0R/o9g8lHzwDK/tNQAMtxyGrfP0naA5y1eKh8GiuxubSzx3I29VSA0jhgWQ2+z/A=@vger.kernel.org X-Gm-Message-State: AOJu0YyjLATbgtZe9bjht6KjO3l2GNmpbbFJ42jpxzsV/Onk6SUqPurv 0yoDEbk34Lp5sqzkl6APaySxJne0LpC8R+/DLq/LvjjvQ1QRChKeLITLrVjhANGHlNhP0lDYmkK MltbpCGWvmeY7A/EFZ2Hf2rXxpduY4HuVP9jPbogC5SigIwP7TzjPOyg3cVCQKw== X-Gm-Gg: ASbGncti1/YVyh8Cpfr8da7kmu30zWcy4j9ZrcWQyaES96+j3oUKyc8HCo+yCmyX16c 9mo2/6rNrt5FEfP/LJc66hycqexjX3cG24b55S7phcQHWkx5X6MaZl0dCMLmLjPjOkFkEMFP0G9 +HgtocmaxjhkiCgliNoQC2s8Km7RnBAMqpGOve9ZjG7iyHcAF6mRekySV7PNoZTNZXILJqFLLYT gbXZ1PNkISB/KJBre7cgze8SnNEsfIECuGx9jBpom0iF7OmrWc/C0jby8NH22KJKorYUhFWixm7 iwJFGCQF642DD6hFedw83yJRFA6nHcCFkiuzFxY6ow5mC9u3a/e4HCAA0YedshrN7xRRiiYLuEk R0YP9vBWylnioYt0I4wKrrw== X-Received: by 2002:a5d:64e4:0:b0:386:3864:5cf2 with SMTP id ffacd0b85a97d-38bf56633cdmr9864340f8f.19.1737359734264; Sun, 19 Jan 2025 23:55:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRXGd9oCcIBlwJQQ4oYo6bcQNELzJWWu1QgMjGSdnaMQy3uGPXkFH50ojzLCsbD82fP+Jwvw== X-Received: by 2002:a5d:64e4:0:b0:386:3864:5cf2 with SMTP id ffacd0b85a97d-38bf56633cdmr9864320f8f.19.1737359733898; Sun, 19 Jan 2025 23:55:33 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf328dc08sm9491285f8f.101.2025.01.19.23.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jan 2025 23:55:32 -0800 (PST) Message-ID: <52d2b3ed-6a4b-4c44-a56f-56840ecd971c@redhat.com> Date: Mon, 20 Jan 2025 08:55:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio To: Wupeng Ma , akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, linmiaohe@huawei.com, mhocko@suse.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250116061657.227027-2-mawupeng1@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.01.25 07:16, Wupeng Ma wrote: > From: Ma Wupeng > > Commit 6da6b1d4a7df ("mm/hwpoison: convert TTU_IGNORE_HWPOISON to > TTU_HWPOISON") introduce TTU_HWPOISON to replace TTU_IGNORE_HWPOISON > in order to stop send SIGBUS signal when accessing an error page after > a memory error on a clean folio. However during page migration, anon > folio must be set with TTU_HWPOISON during unmap_*(). For pagecache > we need some policy just like the one in hwpoison_user_mappings to > set this flag. So move this policy from hwpoison_user_mappings to > unmap_poisoned_folio to handle this waring properly. > > Waring will be produced during unamp poison folio with the following log: > > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 365 at mm/rmap.c:1847 try_to_unmap_one+0x8fc/0xd3c > Modules linked in: > CPU: 1 UID: 0 PID: 365 Comm: bash Tainted: G W 6.13.0-rc1-00018-gacdb4bbda7ab #42 > Tainted: [W]=WARN > Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015 > pstate: 20400005 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : try_to_unmap_one+0x8fc/0xd3c > lr : try_to_unmap_one+0x3dc/0xd3c > Call trace: > try_to_unmap_one+0x8fc/0xd3c (P) > try_to_unmap_one+0x3dc/0xd3c (L) > rmap_walk_anon+0xdc/0x1f8 > rmap_walk+0x3c/0x58 > try_to_unmap+0x88/0x90 > unmap_poisoned_folio+0x30/0xa8 > do_migrate_range+0x4a0/0x568 > offline_pages+0x5a4/0x670 > memory_block_action+0x17c/0x374 > memory_subsys_offline+0x3c/0x78 > device_offline+0xa4/0xd0 > state_store+0x8c/0xf0 > dev_attr_store+0x18/0x2c > sysfs_kf_write+0x44/0x54 > kernfs_fop_write_iter+0x118/0x1a8 > vfs_write+0x3a8/0x4bc > ksys_write+0x6c/0xf8 > __arm64_sys_write+0x1c/0x28 > invoke_syscall+0x44/0x100 > el0_svc_common.constprop.0+0x40/0xe0 > do_el0_svc+0x1c/0x28 > el0_svc+0x30/0xd0 > el0t_64_sync_handler+0xc8/0xcc > el0t_64_sync+0x198/0x19c > ---[ end trace 0000000000000000 ]--- > > Fixes: 6da6b1d4a7df ("mm/hwpoison: convert TTU_IGNORE_HWPOISON to TTU_HWPOISON") > Signed-off-by: Ma Wupeng > Suggested-by: David Hildenbrand Your SOB should probably come last. With or without moving folio_mapped() into unmap_poisoned_folio(): Acked-by: David Hildenbrand -- Cheers, David / dhildenb