From: Adrian Hunter <adrian.hunter@intel.com>
To: "Steinar H. Gunderson" <sesse@google.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] perf intel-pt: Synthesize cycle events
Date: Wed, 23 Mar 2022 09:58:00 +0200 [thread overview]
Message-ID: <52d31321-66e1-f189-2ffc-7c93239eea74@intel.com> (raw)
In-Reply-To: <YjpFcLiCTjHZWzzA@google.com>
On 22/03/2022 23:53, Steinar H. Gunderson wrote:
> On Tue, Mar 22, 2022 at 06:32:18PM -0300, Arnaldo Carvalho de Melo wrote:
>> I saw there was some issue, should I proceed and apply this v3 patch or
>> wait for some v4?
>
> There are two issues in play:
>
> 1. PT event synth doesn't support reading inline information from DWARF
> yet, and my patch to add it runs into some problems. This is not
> relevant for this patch at all.
> 2. The results from v3 don't quite match the ones from v1, and neither
> of us are entirely sure why. My personal feeling is that the one
> from v1 are the wrong ones, but it's up to Adrian to say whether we
> want to try to investigate deeply here.
V3 is good. Please take that.
next prev parent reply other threads:[~2022-03-23 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 8:24 Steinar H. Gunderson
2022-03-22 21:32 ` Arnaldo Carvalho de Melo
2022-03-22 21:53 ` Steinar H. Gunderson
2022-03-23 7:58 ` Adrian Hunter [this message]
2022-03-25 22:07 ` Arnaldo Carvalho de Melo
2023-02-17 11:02 ` Steinar H. Gunderson
2023-02-17 14:03 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52d31321-66e1-f189-2ffc-7c93239eea74@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sesse@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®