mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>,
	<mmayer@broadcom.com>, <f.fainelli@gmail.com>,
	<ladis@linux-mips.org>, <treding@nvidia.com>, <digetx@gmail.com>,
	<d-gerlach@ti.com>
Cc: <linus.walleij@linaro.org>, <michal.simek@xilinx.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [LINUX PATCH v12 1/2] dt-bindings: memory: Add pl353 smc controller devicetree binding information
Date: Wed, 5 Dec 2018 15:42:42 +0100	[thread overview]
Message-ID: <52d598c9-8e72-c30b-edc8-bb16e29b425a@xilinx.com> (raw)
In-Reply-To: <1543496257-5396-1-git-send-email-naga.sureshkumar.relli@xilinx.com>

On 29. 11. 18 13:57, Naga Sureshkumar Relli wrote:
> Add pl353 static memory controller devicetree binding information.
> 
> Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../bindings/memory-controllers/pl353-smc.txt      | 47 ++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> new file mode 100644
> index 0000000..d56615f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> @@ -0,0 +1,47 @@
> +Device tree bindings for ARM PL353 static memory controller
> +
> +PL353 static memory controller supports two kinds of memory
> +interfaces.i.e NAND and SRAM/NOR interfaces.
> +The actual devices are instantiated from the child nodes of pl353 smc node.
> +
> +Required properties:
> +- compatible		: Should be "arm,pl353-smc-r2p1", "arm,primecell".
> +- reg			: Controller registers map and length.
> +- clock-names		: List of input clock names - "memclk", "apb_pclk"
> +			  (See clock bindings for details).
> +- clocks		: Clock phandles (see clock bindings for details).
> +- address-cells		: Must be 2.
> +- size-cells		: Must be 1.
> +
> +Child nodes:
> + For NAND the "arm,pl353-nand-r2p1" and for NOR the "cfi-flash" drivers are
> +supported as child nodes.
> +
> +for NAND partition information please refer the below file
> +Documentation/devicetree/bindings/mtd/partition.txt
> +
> +Example:
> +	smcc: memory-controller@e000e000
> +			compatible = "arm,pl353-smc-r2p1", "arm,primecell";
> +			clock-names = "memclk", "apb_pclk";
> +			clocks = <&clkc 11>, <&clkc 44>;
> +			reg = <0xe000e000 0x1000>;
> +			#address-cells = <2>;
> +			#size-cells = <1>;
> +			ranges = <0x0 0x0 0xe1000000 0x1000000 //Nand CS Region
> +				  0x1 0x0 0xe2000000 0x2000000 //SRAM/NOR CS Region
> +				  0x2 0x0 0xe4000000 0x2000000>; //SRAM/NOR CS Region
> +			nand_0: flash@e1000000 {
> +				compatible = "arm,pl353-nand-r2p1"
> +				reg = <0 0 0x1000000>;
> +				(...)
> +			};
> +			nor0: flash@e2000000 {
> +				compatible = "cfi-flash";
> +				reg = <1 0 0x2000000>;
> +			};
> +			nor1: flash@e4000000 {
> +				compatible = "cfi-flash";
> +				reg = <2 0 0x2000000>;
> +			};
> +	};
> 

v11 was sent long time ago and also reviewed by Linus here
https://lore.kernel.org/patchwork/patch/961603/

I can't see changelog which you have in v11. And also recorded changes
if any.
Then this driver will go through arm-soc tree via me.

Thanks,
Michal


  reply	other threads:[~2018-12-05 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 12:57 Naga Sureshkumar Relli
2018-12-05 14:42 ` Michal Simek [this message]
2018-12-06  8:31   ` Naga Sureshkumar Relli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52d598c9-8e72-c30b-edc8-bb16e29b425a@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=d-gerlach@ti.com \
    --cc=digetx@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=ladis@linux-mips.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmayer@broadcom.com \
    --cc=naga.sureshkumar.relli@xilinx.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®