From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628E2C43387 for ; Wed, 9 Jan 2019 09:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B39920651 for ; Wed, 9 Jan 2019 09:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729896AbfAIJ4s (ORCPT ); Wed, 9 Jan 2019 04:56:48 -0500 Received: from foss.arm.com ([217.140.101.70]:39560 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729132AbfAIJ4s (ORCPT ); Wed, 9 Jan 2019 04:56:48 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82D5D80D; Wed, 9 Jan 2019 01:56:47 -0800 (PST) Received: from [172.16.1.159] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 65C363F70D; Wed, 9 Jan 2019 01:56:43 -0800 (PST) Subject: Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver To: "gregkh@linuxfoundation.org" Cc: Borislav Petkov , "Wiebe, Wladislav (Nokia - DE/Ulm)" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "nicolas.ferre@microchip.com" , "arnd@arndb.de" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mchehab@kernel.org" , "Sverdlin, Alexander (Nokia - DE/Ulm)" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190108104204.GA14243@zn.tnic> <20190108181206.GA3848@kroah.com> From: James Morse Message-ID: <52dc5125-9213-9ee4-eca6-cc8ffbc869f7@arm.com> Date: Wed, 9 Jan 2019 09:57:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190108181206.GA3848@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On 01/08/2019 06:12 PM, gregkh@linuxfoundation.org wrote: > On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: >>>> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c >>>> new file mode 100644 >>>> index 000000000000..26252568e961 >>>> --- /dev/null >>>> +++ b/drivers/edac/cortex_a15_l2_async_edac.c >>>> @@ -0,0 +1,134 @@ >>>> +// SPDX-License-Identifier: GPL-2.0 >>>> +/* >>>> + * Copyright (C) 2018 Nokia Corporation >> >> (boiler plate not needed with the SPDX header) > > Not true at all. Copyright is not the same thing as an SPDX license > identifier in any way, shape, or form. As-is, this is just fine. This looks funny because I removed the GPL license text that was here, but left this comment when trimming the reply. I should have left a few lines of it for context. (Originally: https://lore.kernel.org/lkml/20190108104204.GA14243@zn.tnic/T/#u) Thanks, James