From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966164AbcIYLSy (ORCPT ); Sun, 25 Sep 2016 07:18:54 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:34646 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938645AbcIYLSv (ORCPT ); Sun, 25 Sep 2016 07:18:51 -0400 Subject: Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces To: SF Markus Elfring , netdev@vger.kernel.org, Karsten Keil References: <06e7637c-f682-bfa2-82b6-47d071bd58c4@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Sergei Shtylyov Message-ID: <52dd5000-2bda-a1b6-aa97-1868e1193d35@cogentembedded.com> Date: Sun, 25 Sep 2016 14:18:47 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <06e7637c-f682-bfa2-82b6-47d071bd58c4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/25/2016 2:15 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 25 Sep 2016 12:50:21 +0200 > > Do not use curly brackets at eight source code places > where a single statement should be sufficient. > > Signed-off-by: Markus Elfring > --- > drivers/isdn/capi/capidrv.c | 30 +++++++++++------------------- > 1 file changed, 11 insertions(+), 19 deletions(-) > > diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c > index 83f756d..7f58644 100644 > --- a/drivers/isdn/capi/capidrv.c > +++ b/drivers/isdn/capi/capidrv.c [...] > @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg) > if (debugmode) > printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x (%s) cipmask=0x%x\n", > card->contrnr, cmsg->Info, capi_info2str(cmsg->Info), card->cipmask); > - if (cmsg->Info) { > + if (cmsg->Info) > listen_change_state(card, EV_LISTEN_CONF_ERROR); > - } else if (card->cipmask == 0) { > + else if (card->cipmask == 0) > listen_change_state(card, EV_LISTEN_CONF_EMPTY); > - } else { > + else Indented too much. [...] MBR, Sergei