From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38635E8FDBB for ; Tue, 3 Oct 2023 21:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241247AbjJCVdB (ORCPT ); Tue, 3 Oct 2023 17:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232084AbjJCVdA (ORCPT ); Tue, 3 Oct 2023 17:33:00 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D509B4; Tue, 3 Oct 2023 14:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=TmbG19q/l6/TFhKwKoaT2kkqg5Pf6ybIjYHQ4sb+b0E=; b=hMtsoqqkFPxb0Y+BJj5Rfp98pt fYY2xiiKLzIX2P50gjJTJShB8inGExSLn10LzC0NQfLJXnI0+oz6J7GDxeE45CwozSypKvp5c7kvy 25kQHRewyzXq/epzfTZlwu2UiEiigs8ZWDsxEWQAGabBlQ5cK9SfKmf1pPR+dF4BlbHM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qnn0T-0089lk-Ja; Tue, 03 Oct 2023 23:32:41 +0200 Date: Tue, 3 Oct 2023 23:32:41 +0200 From: Andrew Lunn To: =?utf-8?B?UGF3ZcWC?= Dembicki Cc: Vladimir Oltean , "Russell King (Oracle)" , netdev@vger.kernel.org, Dan Carpenter , Simon Horman , Linus Walleij , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 2/8] net: dsa: vsc73xx: convert to PHYLINK Message-ID: <52dd8a1c-e0f0-4a24-b6d7-6ba1c9482525@lunn.ch> References: <20230912122201.3752918-1-paweldembicki@gmail.com> <20230912122201.3752918-3-paweldembicki@gmail.com> <20230926230346.xgdsifdnka2iawiz@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I plan to make rgmii delays configurable from the device tree. Should I? > a. switch to phy_interface_is_rgmii in the current patch? > b. add another patch in this series? > c. wait with change to phy_interface_is_rgmii for patch with rgmii > delays configuration? Do you actually need this feature? Does the PHY you are using already support fine tuning of the delays? Andrew