From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbbFINjE (ORCPT ); Tue, 9 Jun 2015 09:39:04 -0400 Received: from mta02.ornl.gov ([128.219.177.12]:60102 "EHLO mta02.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbbFINiz convert rfc822-to-8bit (ORCPT ); Tue, 9 Jun 2015 09:38:55 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,581,1427774400"; d="scan'208";a="81585746" From: "Simmons, James A." To: "'Sudip Mukherjee'" , Dan Carpenter CC: "devel@driverdev.osuosl.org" , "Greg Kroah-Hartman" , Linux Kernel Mailing List , Oleg Drokin , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH v4 1/7] staging:lustre: move tcpip abstraction Thread-Topic: [lustre-devel] [PATCH v4 1/7] staging:lustre: move tcpip abstraction Thread-Index: AQHQnohb4BHvZ7gJck2ufgNVnOslIp2cN7oAgAADJYCAB/qsUA== Date: Tue, 9 Jun 2015 13:38:53 +0000 Message-ID: <52dddbd6f58e475981a9e19985008ce7@EXCHCS32.ornl.gov> References: <1433361433-24976-1-git-send-email-jsimmons@infradead.org> <1433361433-24976-2-git-send-email-jsimmons@infradead.org> <20150604053554.GB6376@sudip-PC> <20150604073420.GA28762@mwanda> <20150604074535.GA6781@sudip-PC> In-Reply-To: <20150604074535.GA6781@sudip-PC> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Thu, Jun 04, 2015 at 10:34:20AM +0300, Dan Carpenter wrote: >> On Thu, Jun 04, 2015 at 11:05:54AM +0530, Sudip Mukherjee wrote: >> > On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: >> > > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c >> > looks like you have not just renamed the file, but there was also a change >> > in the #include which is not mentioned in the commit message. >> > >> >> That's obviously going to be part of moving the file. >yes. path changed for libcfs.h. so that was updated. >but there was also a new line >#include "../../include/linux/lnet/lib-lnet.h" > >should that be part of moving the file also? That is handle the move of some of the LNet function declarations in libcfs.h to lib-lnet.h. That happens in patch number 4 of this series. I was trying to minimize the diff between the tip of the Lustre development branch and the upstream client.