From: Marc Zyngier <marc.zyngier@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: fix a migrating irq bug when hotplug cpu
Date: Thu, 10 Jan 2019 12:56:11 +0000 [thread overview]
Message-ID: <52e825c6-6704-c6b9-bbba-a87a0f5ec9cb@arm.com> (raw)
In-Reply-To: <20190110100922.20280-1-dietmar.eggemann@arm.com>
On 10/01/2019 10:09, Dietmar Eggemann wrote:
> Arm TC2 fails cpu hotplug stress test.
>
> This issue was tracked down to a missing copy of the new affinity
> cpumask for the vexpress-spc interrupt into struct
> irq_common_data.affinity when the interrupt is migrated in
> migrate_one_irq().
>
> Fix it by replacing the arm specific hotplug cpu migration with the
> generic irq code.
>
> This is the counterpart implementation to commit 217d453d473c ("arm64:
> fix a migrating irq bug when hotplug cpu").
>
> Tested with cpu hotplug stress test on Arm TC2 (multi_v7_defconfig plus
> CONFIG_ARM_BIG_LITTLE_CPUFREQ=y and CONFIG_ARM_VEXPRESS_SPC_CPUFREQ=y).
> The vexpress-spc interrupt (irq=22) on this board is affine to CPU0.
> Its affinity cpumask now changes correctly e.g. from 0 to 1-4 when
> CPU0 is hotplugged out.
>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2019-01-10 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 10:09 Dietmar Eggemann
2019-01-10 12:56 ` Marc Zyngier [this message]
2019-01-18 13:31 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2015-08-29 13:07 [PATCH] ARM: " Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52e825c6-6704-c6b9-bbba-a87a0f5ec9cb@arm.com \
--to=marc.zyngier@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®