From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365AbdJWQAJ (ORCPT ); Mon, 23 Oct 2017 12:00:09 -0400 Received: from foss.arm.com ([217.140.101.70]:40528 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932338AbdJWQAI (ORCPT ); Mon, 23 Oct 2017 12:00:08 -0400 Cc: Rob Herring , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Frank Rowand Subject: Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from of_platform_default_populate_init() To: Arnd Bergmann References: <1506595562-10592-1-git-send-email-sudeep.holla@arm.com> <1506595562-10592-2-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <52ed3abb-6b05-89c9-5ab4-31b37ffa1db9@arm.com> Date: Mon, 23 Oct 2017 16:59:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 17/10/17 14:02, Rob Herring wrote: > On Thu, Sep 28, 2017 at 5:45 AM, Sudeep Holla wrote: >> Since "/firmware" does not have its own "compatible" property as it's >> just collection of nodes representing firmware interface, it's sub-nodes >> are not populated during system initialization. >> >> Currently different firmware drivers search the /firmware/ node and >> populate the sub-node devices selectively. Instead we can populate >> the /firmware/ node during init to avoid more drivers continuing to >> populate the devices selectively. >> >> To generalize the solution this patch populates the /firmware/ node >> explicitly from of_platform_default_populate_init(). >> You had concernsin the past and I mentioned that firmware interface to user-space *has* to continue in /sys/firmware, but he platform_device management is internal to kernel. Can we proceed with this change at-least for qcom and meson firmware which are platform device already ? I can drop optee related changes. -- Regards, Sudeep