From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Merck Hung <merckhung@gmail.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023
Date: Fri, 25 Oct 2024 10:55:20 +0200 [thread overview]
Message-ID: <52f67b29-551b-4ccb-8c26-c49dcacea5a1@oss.qualcomm.com> (raw)
In-Reply-To: <61308a22-f63d-403f-bed7-c082bf716bce@oldschoolsolutions.biz>
On 25.10.2024 7:35 AM, Jens Glathe wrote:
>
> On 18.10.24 16:38, Konrad Dybcio wrote:
>> On 13.10.2024 1:54 PM, Jens Glathe via B4 Relay wrote:
>>> From: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
>>>
>>> Device tree for the Microsoft Windows Dev Kit 2023. This work
>>> is based on the initial work of Merck Hung <merckhung@gmail.com>.
>>>
>>> The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp.
>>> Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/
>> [...]
>>
>>> +
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&wcd_default>;
>> property-n
>> property-names
>>
>> (all throughout the file)
>>
>> [...]
>>
>>> + pmic-glink {
>>> + compatible = "qcom,sc8280xp-pmic-glink", "qcom,pmic-glink";
>>> +
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + orientation-gpios = <&tlmm 166 GPIO_ACTIVE_HIGH>,
>>> + <&tlmm 49 GPIO_ACTIVE_HIGH>;
>>> +
>>> + connector@0 {
>> Could you add a comment describing which connector is which (see e.g.
>> x1e80100-microsoft-romulus.dtsi)
>>
>> [...]
>>
>>> +&gpu {
>>> + status = "okay";
>>> +
>>> + zap-shader {
>>> + memory-region = <&gpu_mem>;
>>> + firmware-name = "qcom/sc8280xp/MICROSOFT/blackrock/qcdxkmsuc8280.mbn";
>> "microsoft" lowercase would be consistent with other DTs in arm64/qcom
> Hmm what about Lenovo X13s. I'll change it to lower case.
rg microsoft/ -i arch/arm64/boot/dts/qcom
yields lowercase, so let's not step out of the line
Konrad
next prev parent reply other threads:[~2024-10-25 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 11:54 [PATCH v3 0/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for Windows Dev Kit 2023 Jens Glathe via B4 Relay
2024-10-13 11:54 ` [PATCH v3 1/3] dt-bindings: arm: qcom: Add Microsoft " Jens Glathe via B4 Relay
2024-10-14 7:20 ` Krzysztof Kozlowski
2024-10-13 11:54 ` [PATCH v3 2/3] firmware: qcom: scm: Allow QSEECOM for " Jens Glathe via B4 Relay
2024-10-13 11:54 ` [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023 Jens Glathe via B4 Relay
2024-10-14 3:37 ` Krishna Kurapati
2024-10-18 14:34 ` Konrad Dybcio
2024-10-18 14:38 ` Konrad Dybcio
2024-10-25 5:35 ` Jens Glathe
2024-10-25 8:55 ` Konrad Dybcio [this message]
2024-10-14 14:05 ` [PATCH v3 0/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for Windows Dev Kit 2023 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f67b29-551b-4ccb-8c26-c49dcacea5a1@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=merckhung@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®