From: "Rangoju, Raju" <raju.rangoju@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
sanju.mehta@amd.com, krishnamoorthi.m@amd.com,
akshata.mukundshetty@amd.com
Subject: Re: [PATCH 7/9] spi: spi_amd: Enhance SPI-MEM support functions
Date: Tue, 24 Sep 2024 20:55:04 +0530 [thread overview]
Message-ID: <52f6b06a-ba0d-c736-81d2-cdf5a3802b66@amd.com> (raw)
In-Reply-To: <ZuvmIG5h2hnicIjQ@finisterre.sirena.org.uk>
On 9/19/2024 2:21 PM, Mark Brown wrote:
> On Wed, Sep 18, 2024 at 04:20:35PM +0530, Raju Rangoju wrote:
>
>> AMD SPI0 controller supports quad mode only for read operations and has
>> limited support for quad mode writes. And, the AMD HID2 SPI controller
>> supports DMA read, allowing for up to 4 KB of data to be read in single
>> transaction. Update the SPI-MEM support functions to reflect these hardware
>> capabilities.
>
>> /* bus width is number of IO lines used to transmit */
>> - if (op->cmd.buswidth > 1 || op->addr.buswidth > 4 ||
>> - op->data.buswidth > 4 || op->data.nbytes > AMD_SPI_MAX_DATA)
>
> So this code you added earlier in the series is clearly buggy... this
> whole change should've been part of that patch, and the addidion of the
> patch adding the new HID.
Sure, I will take care of this in V2.
next prev parent reply other threads:[~2024-09-24 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 10:50 [PATCH 0/9] spi: spi_amd: Performance Optimization Patch Series Raju Rangoju
2024-09-18 10:50 ` [PATCH 1/9] spi: spi_amd: Sort headers alphabetically Raju Rangoju
2024-09-18 10:50 ` [PATCH 2/9] spi: spi_amd: Enable dual and quad I/O modes Raju Rangoju
2024-09-19 8:43 ` Mark Brown
2024-09-24 15:23 ` Rangoju, Raju
2024-09-18 10:50 ` [PATCH 3/9] spi: spi_amd: Replace ioread/iowrite calls Raju Rangoju
2024-09-18 10:50 ` [PATCH 4/9] spi: spi_amd: Updates to set tx/rx count functions Raju Rangoju
2024-09-18 10:50 ` [PATCH 5/9] spi: spi_amd: Optimize IO operations Raju Rangoju
2024-09-18 10:50 ` [PATCH 6/9] spi: spi_amd: Add support for HID2 SPI controller Raju Rangoju
2024-09-18 10:50 ` [PATCH 7/9] spi: spi_amd: Enhance SPI-MEM support functions Raju Rangoju
2024-09-19 8:51 ` Mark Brown
2024-09-24 15:25 ` Rangoju, Raju [this message]
2024-09-18 10:50 ` [PATCH 8/9] spi: spi_amd: Set controller address mode Raju Rangoju
2024-09-18 10:50 ` [PATCH 9/9] spi: spi_amd: Add HIDDMA basic read support Raju Rangoju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f6b06a-ba0d-c736-81d2-cdf5a3802b66@amd.com \
--to=raju.rangoju@amd.com \
--cc=akshata.mukundshetty@amd.com \
--cc=broonie@kernel.org \
--cc=krishnamoorthi.m@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sanju.mehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome