From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 552A51AA7A5 for ; Wed, 4 Dec 2024 09:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733304316; cv=none; b=mK9gUg6zBUn/wMIBbybcYBOAa+m8xRA7MX8M6tl7mGXYUPeT1aP0C9YqGhdyOou8lVxbZir8n4IsWWjKPi/32suDMJ+oNY9TuqY9lulHutDVyrevkp2on220HGxvycdb5mkdPCah7GyDLXa9oG37PVCw6+gcCh421d3pWrYQfz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733304316; c=relaxed/simple; bh=IOioREQ7k18L3jP39Gc/HqqFJ0dRj9fDrGSgDDoODFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cKlU0X4hc0Jm+TiRbh61IEGwJxPu+6hzVWRWuSvykFaIRc+dCl3TuPtO5JQA17ogF7penYC1mdqThHJF96pMWzNccZdKUqj1bv72cLmmJEkEwGniiOriX6CqV1+CyE3ZQuL+RAU4tfzRVQM6J6xJjRbCm5AkXIIjEs6yMCVSk/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uEAUnB0T; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uEAUnB0T" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-434a12d106dso6639485e9.2 for ; Wed, 04 Dec 2024 01:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733304312; x=1733909112; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=m8DaQdDkfEfGBJ2lNaIrewpoCtOfg7AdvFQ8X4rPfJ8=; b=uEAUnB0TJ+0M/cZiPi30tL11ZRoZ8P8KUSnv9VP99ZKv3+gTAycXSavhg9PprWP70h tLzsE6CXVDYyh/7Slarn9Pbnbp9WOnGQhPqT/e+0I11yWag/mV7Pvg7iFqaDs1MSE7+x 57fHsCBYHNKhx+1W5lBCk6pDzqtHR3w3e5+UDji2f5Y8eKkjbj9hYmpE23WUa6EBNfQl t0czJeafnVPWUufeqCFTJgWCmg8IwdV2d1Hhn+QQoIBzW8r5zOk5gimmeWOuDg9kJv+u qy4VyeJUVoP+x3S24mJupYsYaaHfllYB4ekYXl6EgPlTMdHP1b8UJ3X6pHt3YNwplQmT 9NyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733304312; x=1733909112; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m8DaQdDkfEfGBJ2lNaIrewpoCtOfg7AdvFQ8X4rPfJ8=; b=v6Rw0PFNSGdeT05Ez3UZELsg9OHP89yKgG5YoIlnPd7nlJtUA8jJN3KEjhGHuo+Rt+ sPhfbrPnaKS6EajYfylk2AKJAgm34xFOr/wOeD81xuGnxYOq0LqlLSkIP72b6rBFBZKG UOhaBeDNWzCLN4BxNFPbYeI8o350oNLq8waIRUCNusdC1oWlyYr9bbGqvNrFKaz8a/z+ YJe+tgA155Ud+nV6FW8hK2/mZr0hnDRb2Bwt3WkL1t0SUx5/ZnWPeIpMYBdmV3EE1GEp 983HpAcnE8hj3srzvDMNCpuCumyQOpfOVKVmiKVY4XQWf2pbvhe9T+G0Z0At2X/20wW2 TO0g== X-Forwarded-Encrypted: i=1; AJvYcCXs7lSmPnIrnnDwKV5PRrNeAqsr7CZcoqOlUULJZXHRVKM0OTR1aGI4BhNnSezsPnsvIIrHtf2dv6YEjE0=@vger.kernel.org X-Gm-Message-State: AOJu0YwNY8Yl3iykLziE5fAlzEjUZMzOyWFgsyTWcxhv2ibQ52TYkucB 7AEYROku16ghSIZ8QHiwEZgNR1FI8CMsXzyNaGsyx20MyWQU5XqZBWt/IYizcQA= X-Gm-Gg: ASbGnctlihjNf82AF0Um8fOoQEQEd8QKjPJVKx2TggLQynGc/sAtUkpn7jJRXGsNIgY IWKydmWNkzPZxtQWeIKS7VLMCwIxkIEXcg8hEWOuu8x93RczSbK8hzz+RUKUZfzYsL7RMDjiYE3 DZ6G7ZIuT5Ea/j5d6w4bKPOvhtOHl1EoKxAmqCtIMlTb4H8DZiCSTAGd7T+4uZKTxxBnam8Lzxn EzXBeAEGBrvMUwP/nHm8O9mvw2m09Zeq1ucnsWvDotiFd8SBAIeUxOEUU/0TC9eb+s1Og== X-Google-Smtp-Source: AGHT+IFPDrgwPysTQNJ4gCRHmPmwekHSCTmDhMf33Hj14KtYSarTwzVoBNgKPkKaUfDyt0l7DW5IFw== X-Received: by 2002:a05:600c:46cf:b0:42c:aeee:e603 with SMTP id 5b1f17b1804b1-434d0a1f397mr18009855e9.7.1733304311559; Wed, 04 Dec 2024 01:25:11 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d526b312sm18208205e9.6.2024.12.04.01.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 01:25:11 -0800 (PST) Message-ID: <52f7ce30-0159-4779-982d-7714d0b45ae3@linaro.org> Date: Wed, 4 Dec 2024 10:25:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: qcom: clk-alpha-pll: Add Pongo PLL To: Stephen Boyd , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Michael Turquette , Neil Armstrong , Rob Herring Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241128-sm8750-dispcc-v1-0-120705a4015c@linaro.org> <20241128-sm8750-dispcc-v1-2-120705a4015c@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/12/2024 23:07, Stephen Boyd wrote: >> - for (count = 200; count > 0; count--) { >> + /* Pongo PLLs using a 32KHz reference can take upwards of 1500us to lock. */ >> + for (count = 1500; count > 0; count--) { >> ret = regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val); >> if (ret) >> return ret; >> @@ -378,6 +403,13 @@ static int wait_for_pll(struct clk_alpha_pll *pll, u32 mask, bool inverse, >> udelay(1); >> } >> >> + /* Called with clocks already registered ... */ >> + if (pll->clkr.hw.core) >> + name = clk_hw_get_name(&pll->clkr.hw); >> + else >> + /* or before registering, when init data is present */ >> + name = pll->clkr.hw.init->name; > > This is sad. Why can't we enable the PLL from the clk prepare/enable > path? PLLs are typically calibrated during clk_prepare(). I don't know. I'll move it to prepare() and see what happens. > >> + >> WARN(1, "%s failed to %s!\n", name, action); >> return -ETIMEDOUT; >> } >> @@ -2524,6 +2556,129 @@ const struct clk_ops clk_alpha_pll_reset_lucid_evo_ops = { >> }; >> EXPORT_SYMBOL_GPL(clk_alpha_pll_reset_lucid_evo_ops); >> >> +static int alpha_pll_pongo_elu_enable(struct clk_hw *hw) >> +{ >> + struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); >> + struct regmap *regmap = pll->clkr.regmap; >> + int ret; >> + >> + /* Check if PLL is already enabled */ >> + if (trion_pll_is_enabled(pll, regmap)) >> + return 0; >> + >> + ret = regmap_update_bits(regmap, PLL_MODE(pll), PLL_RESET_N, PLL_RESET_N); >> + if (ret) >> + return ret; >> + >> + /* Set operation mode to RUN */ >> + regmap_write(regmap, PLL_OPMODE(pll), PLL_RUN); >> + >> + ret = wait_for_pll_enable_lock(pll); >> + if (ret) >> + return ret; >> + >> + /* Enable the global PLL outputs */ >> + ret = regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, PLL_OUTCTRL); >> + if (ret) >> + return ret; >> + >> + /* Ensure that the write above goes through before returning. */ >> + mb(); >> + >> + return ret; >> +} >> + >> +static void alpha_pll_pongo_elu_disable(struct clk_hw *hw) >> +{ >> + struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); >> + struct regmap *regmap = pll->clkr.regmap; >> + int ret; >> + >> + /* Disable the global PLL output */ >> + ret = regmap_update_bits(regmap, PLL_MODE(pll), PLL_OUTCTRL, 0); >> + if (ret) >> + return; >> + >> + /* Place the PLL mode in STANDBY */ >> + regmap_write(regmap, PLL_OPMODE(pll), PLL_STANDBY); >> +} >> + >> +static unsigned long alpha_pll_pongo_elu_recalc_rate(struct clk_hw *hw, >> + unsigned long parent_rate) >> +{ >> + struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); >> + struct regmap *regmap = pll->clkr.regmap; >> + u32 l; >> + >> + if (regmap_read(regmap, PLL_L_VAL(pll), &l)) >> + return 0; >> + >> + l &= PONGO_PLL_L_VAL_MASK; >> + >> + return alpha_pll_calc_rate(parent_rate, l, 0, pll_alpha_width(pll)); >> +} >> + >> +const struct clk_ops clk_alpha_pll_pongo_elu_ops = { >> + .enable = alpha_pll_pongo_elu_enable, >> + .disable = alpha_pll_pongo_elu_disable, >> + .recalc_rate = alpha_pll_pongo_elu_recalc_rate, >> +}; >> +EXPORT_SYMBOL(clk_alpha_pll_pongo_elu_ops); > > GPL please. Ack (and one more as well) Best regards, Krzysztof