From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbdGaEQE (ORCPT ); Mon, 31 Jul 2017 00:16:04 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:31543 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdGaEQC (ORCPT ); Mon, 31 Jul 2017 00:16:02 -0400 Subject: Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices To: Axel Lin , Lee Jones References: <20170730105815.26728-1-axel.lin@ingics.com> CC: From: Keerthy Message-ID: <52f7eb7d-80d9-3261-5cff-ff6537715b6b@ti.com> Date: Mon, 31 Jul 2017 09:45:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170730105815.26728-1-axel.lin@ingics.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 30 July 2017 04:28 PM, Axel Lin wrote: > This fixes missing mfd_remove_devices() call when unload the module. Reviewed-by: Keerthy > > Signed-off-by: Axel Lin > --- > drivers/mfd/lp87565.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c > index 340ad0c..32d2a07 100644 > --- a/drivers/mfd/lp87565.c > +++ b/drivers/mfd/lp87565.c > @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client, > > i2c_set_clientdata(client, lp87565); > > - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells, > - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL); > - > - return ret; > + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, > + lp87565_cells, ARRAY_SIZE(lp87565_cells), > + NULL, 0, NULL); > } > > static const struct i2c_device_id lp87565_id_table[] = { >