From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755788AbdKGBMb (ORCPT ); Mon, 6 Nov 2017 20:12:31 -0500 Received: from mail5.windriver.com ([192.103.53.11]:38374 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717AbdKGBM2 (ORCPT ); Mon, 6 Nov 2017 20:12:28 -0500 Subject: Re: [PATCH] selftests: memfd_test.c: fix compilation warning. To: Shuah Khan References: <1509879400-26061-1-git-send-email-Lei.Yang@windriver.com> <6a76f65a-a484-ba72-6cc5-85010666359c@osg.samsung.com> CC: , , Shuah Khan From: lei yang Message-ID: <52f83b6e-0472-bf5b-6a00-571c56b6732d@windriver.com> Date: Tue, 7 Nov 2017 09:11:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <6a76f65a-a484-ba72-6cc5-85010666359c@osg.samsung.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [128.224.163.162] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年11月07日 07:46, Shuah Khan wrote: > On 11/05/2017 03:56 AM, Lei Yang wrote: >> Replace '%d' by '%zu' to fix the following compilation warning. >> >> memfd_test.c:517:3: warning: format ‘%d’ expects argument of >> type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=] >> printf("malloc(%d) failed: %m\n", mfd_def_size * 8); >> ^ >> memfd_test.c: In function ‘mfd_fail_grow_write’: >> memfd_test.c:537:3: warning: format ‘%d’ expects argument >> of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=] >> printf("malloc(%d) failed: %m\n", mfd_def_size * 8); >> >> Signed-off-by: Lei Yang >> --- >> tools/testing/selftests/memfd/memfd_test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c >> index f94c6d1..95df9e6 100644 >> --- a/tools/testing/selftests/memfd/memfd_test.c >> +++ b/tools/testing/selftests/memfd/memfd_test.c >> @@ -514,7 +514,7 @@ static void mfd_assert_grow_write(int fd) >> >> buf = malloc(mfd_def_size * 8); >> if (!buf) { >> - printf("malloc(%d) failed: %m\n", mfd_def_size * 8); >> + printf("malloc(%zu) failed: %m\n", mfd_def_size * 8); >> abort(); >> } >> >> @@ -534,7 +534,7 @@ static void mfd_fail_grow_write(int fd) >> >> buf = malloc(mfd_def_size * 8); >> if (!buf) { >> - printf("malloc(%d) failed: %m\n", mfd_def_size * 8); >> + printf("malloc(%zu) failed: %m\n", mfd_def_size * 8); >> abort(); >> } >> >> > Relates to gcc version perhaps. What's your gcc version? $ cat /proc/version Linux version 3.16.0-30-generic (buildd@kissel) (gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) ) #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC 2015 Lei > thanks, > -- Shuah