From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37DE0263F44; Tue, 17 Feb 2026 07:12:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771312368; cv=none; b=paG/QGtmcdNBH33xGC37ErlQwUCC4z/iZZkmF9B1fT1G2odRVL0eN21AXwKyS33fCiNGUUco41yxh60SshsLZsrCyqnj7qdT/rfP9E0Sxqf6cccTkVuLEae7bShncRDC8GUkyYKeydJ7vNuUThJkLDyF/0inhNOl+w/93uGrOZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771312368; c=relaxed/simple; bh=6+s4JBK+CggRvSFesWlOOA/6Z+GGRCbcScDCm4A/cUk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RjE/J2UefJCm0MZ/II4BYS/rqpdGCer06g9gfVwNwehNDjcZLKhdz8VuMFsmA9xSEGgIpEgAPYssgBJZGeGYIYGth2MlqxSzLTYNqt7Z/IvjUYmw9i1Bf2X67av6vRwC7nxSRrRdhlK4FyyqBTn8XuZ1EjD6rGbfya4cxHJlvB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Js5ko99Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Js5ko99Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56576C4CEF7; Tue, 17 Feb 2026 07:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771312367; bh=6+s4JBK+CggRvSFesWlOOA/6Z+GGRCbcScDCm4A/cUk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Js5ko99ZLjvo9Zy7tfuyP5DSv9dF+szhLIcHkH2S0TTZabHrZkHPiZ6Vf3WJ9XHEK qIO2CUaFZRmcjkNQvxSe1/56r6eHksaorjeKPbsPc8u43DQVIf98Ck5zT4obNF4ID3 IwOgM2/4xr2qYWamMGWVndTRBdIa6p+/JQrVuF2fKYNLI3Bw+j/BXXHSkyU/FLGW9P bj7V+16v7LE0aDHKvf17e3FIR+wHJzyL4CcNlrAm105dXcFr+v/akw74RZVvqxaBWe kYZMJIJ9zmWmXjkjTGVTPBfQsEkJ1l0YazsnhXyNVbNdUY+0X8/oKQMjeEK9Wfx+28 ucp9DLqC+6lyA== Message-ID: <52f9b04a-256a-4559-b3e6-28fe695e1b6d@kernel.org> Date: Tue, 17 Feb 2026 08:12:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: watchdog: Add NPCM reset status support To: Tomer Maimon Cc: andrew@codeconstruct.com.au, avifishman70@gmail.com, tali.perry1@gmail.com, wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, venture@google.com, yuenn@google.com, benjaminfair@google.com, joel@jms.id.au, openbmc@lists.ozlabs.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260210133843.1078463-1-tmaimon77@gmail.com> <20260210133843.1078463-2-tmaimon77@gmail.com> <92197c45-2921-47ad-9680-7339d6308b8f@kernel.org> <1522cec8-8259-4404-86fa-18bd91473087@kernel.org> <20260216-prompt-boisterous-worm-fed8d9@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/02/2026 07:53, Tomer Maimon wrote: > On Mon, 16 Feb 2026 at 20:03, Krzysztof Kozlowski wrote: > >> On Mon, Feb 16, 2026 at 04:59:18PM +0200, Tomer Maimon wrote: >>> On Mon, 16 Feb 2026 at 16:48, Krzysztof Kozlowski >> wrote: >>>>>>>>> + syscon: >>>>>>>> >>>>>>>> First iteration. See "How to Get Your DT Schema Bindings Accepted >> in >>>>>>>> Less Than 10 Iterations" >>>>>>>> >>>>>>> Thanks, it was very helpful. >>>>>>> the syscon property is already found in the WD node >>>>>>> in nuvoton-common-npcm8xx.dtsi file, what should I do: >>>>>> >>>>>> How is that file related to this binding? >>>>>> >>>>>> Either you document existing ABI or you add new (for new device). >> Commit >>>>>> msg MUST be explicit about it and provide the reasons. If wrong >> (e.g. >>>>>> discouraged) ABI was already used then it depends how and when it >> got >>>>>> into the kernel, e.g. if someone bypassed DT completely just to get >> it >>>>>> inside. >>>>>> >>>>> The syscon property is already used in the upstream NPCM8xx DTSI >> watchdog >>>>> node, so I will document it as existing ABI and mark it deprecated. I >>>> will >>>> >>>> And how it is used? I cannot find its usage, so I do not agree on >>>> documenting it. Property should be removed or at least provide the >>>> justification/impact of removal, if you need it to stay. >>>> >>>> Understood. The syscon phandle is used by the watchdog driver to read >> and >> >> You messed up quotes. >> >> Can you point me to the line? I REALLY want to be sure that we are not >> wasting each other time, e.g. me looking at wrong code or you telling me >> some bollocks from downstream. >> > The syscon property is not used in the current upstream npcm_wdt driver. > It is used *in this patch set*, which introduces the function Why would that matter for the ABI? So no, your buggy DTS sneaked into the kernel before submitting bindings is not acceptable thus ABI which was NEVER reviewed must be removed. Best regards, Krzysztof