From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7003740E8CE for ; Thu, 9 Jul 2026 11:48:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783597713; cv=none; b=SeuIcFCmyN5G/NiuRW7SdmeLFdFC1s34szpVq2ZBJCUJ4bZg6CBHNfDQAJvQK34wLFQ0ocW6K+JOuUY1enr9VVcga5xGr0SOwID2C4Wv+0LRQovjXHmR5Xj5FuURLHJaS+A+2SkkqNshwgJz4v3vhMpRWszgjMSbs2NHtcatiK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783597713; c=relaxed/simple; bh=YcrbCGbp9yVb3kD+7VwZ981MYBaNshwP+EjRjcaw6ew=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PQVLSsqgS8GlxZE049cJVeGDFNpxRZz//x/Wp2ZFGJiamXe2oSUBcytrCPzuPiIm4jOkFeZzmGYAm5qmifa6IY3NBow28vdIVqXOKQNTGOAr7asLSEaMjB4lM5qKpksLiiiZRULLdOVTvbP31I5uMlZZk0x/AWEgZK4g2vS7Oz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=PaFBy+x+; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="PaFBy+x+" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-493b966dd74so7211955e9.3 for ; Thu, 09 Jul 2026 04:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783597711; x=1784202511; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/xhIPKXuDtakaGagT1mNyUeziKP6acuLSpzf74bewak=; b=PaFBy+x+7SHjflPNCa+CDICA8wvgiDxnvtDKWQjjeU9EhcvOyejEfUI6r98O1nJGFu NVp5Zk80Qk2OF9/raQgIZYDp/STvbfY4aZSFRWHHufLmGF3IxiadXQwR86YptPyrH2T/ H1ZNEWqd80EM2J5EzfWGSLiJVo9DAiH4p5e9gtldTY15wBjlO2iHakylbjvlJVPIwmK9 VGvg1RvG+wfLcWm/OlAjROU+uiNNbakrhyWYcLUffwgf9ALB+0Rt3gD0K5aKIR0TAF46 sjqpbW3Z6Jji0OqvCxF2DvGmcDAKtEVkWCIssowaYD+ujzQun4MHVRx2nUyKFaqarEmE CQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783597711; x=1784202511; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/xhIPKXuDtakaGagT1mNyUeziKP6acuLSpzf74bewak=; b=X1SvV0kpeNyGg8RI0E6MUE9WugMydi2ZRKVNUiQCuFzPZJTEhIJuDuO6mhsCdvL/Tu 4MDgGl7XF7C2ocNOVQM2rCwCf/PpoubL/uvRrC7X/zJz+tlYeEl2KWxSIEMcrPCu4Tes RuBoFTsThnv+do43s2aBJMspcbXAUu82DJaY13rJtWr6FLmNAUlFY/DX71hFlBbLwN7r qlxF0lq1iNgOglCcEh+TM4OruzQbJKfxd8gj0ASAtRFFZUbobHHA1jCY4d4AGzY5i+Yy QzzRvryaDKnJym0ZYWfl6pmLPahDLFIEftcueF/eIT35bgzYN+qrfdyxjj14Zez+qIBm km/Q== X-Forwarded-Encrypted: i=1; AHgh+RqZbnzqn/85o5+DaDSdMoebZgHLyjU9SXhyBKXp6XwLfKTRWVzRYZdJOfWMl1lxD2U0PFvHwTIJkMUD/vA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3nsDEry8vQJDcwfOHEyXLInxHN8yGwm84tHw/Oo5yL2n5QvJ0 0MJJg5eOMOpRtKx87nkGOPn175//jElBve2D8NXhRQKIPtxiSW2G/S1ia9xPDmTELRQ= X-Gm-Gg: AfdE7cm8S57d59WcNvfpTcf+TsR5JxJYdf44AtAsk81Bd3WljeUz/j9bzO5CdmMABjs 67sEKnzFhBzzSDEafYCKzleubBiBK1ZDesACjavk3F1z22NNOrf6+g6i8zqWl5PkWVg+y0cEAUM JRggeRS8AXvxMiGxiioz1Av5nmmUMRqTnne/J26uVbgltoSPCtyNAZQFbxI0gpDinWIHan2sk1+ FoGy9TjVORuSnaUardXzE/P1uR59PKubYaea48N5dQqrGj6oUKbpGwvNdalDCrAyEmtCwk4nmry xk4E2OhzkoF/yeYGH7rzi5mCfWnQjTd6raJPt971YX743fnK5BQotprityPd6y32/ZLvcUgqfHb RoxPRW0SGOPJyZ4sCOTfUtF1ie9bfJoYzh4TgdjB3gB9ov20qrByE+cvFHWdSoukMLD9Whq1i0N U+q51bgBoOY0COTxAJb+YXurLQhVLEYGnUxg== X-Received: by 2002:a05:600c:3e07:b0:493:de89:61b with SMTP id 5b1f17b1804b1-493e6868766mr66384865e9.26.1783597710634; Thu, 09 Jul 2026 04:48:30 -0700 (PDT) Received: from [192.168.42.79] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6df417sm55696575e9.8.2026.07.09.04.48.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 04:48:30 -0700 (PDT) Message-ID: <52feb9b1-2073-4fcf-b2d1-a7f42f1e72a5@suse.com> Date: Thu, 9 Jul 2026 13:48:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] rust: module_param: return value by copy from `value` To: Andreas Hindborg , Miguel Ojeda Cc: Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Danilo Krummrich , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20260601-modules-value-ref-v2-1-12ebbf0510c9@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260601-modules-value-ref-v2-1-12ebbf0510c9@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/1/26 12:17 PM, Andreas Hindborg wrote: > For `Copy` parameter types it is more ergonomic to retrieve the > parameter value by copy than through a shared reference. Change > `ModuleParamAccess::value` to return `T` by copy when `T: Copy`, > and rename the previous reference-returning accessor to > `value_ref`. Update the in-tree caller in `rust_minimal`. > > Suggested-by: Alice Ryhl > Signed-off-by: Andreas Hindborg Reviewed-by: Petr Pavlu @Miguel, please let me know if I should take this patch on modules-next, or if you'd prefer for it to go through the Rust tree. -- Thanks, Petr