From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759249AbcHaKWQ (ORCPT ); Wed, 31 Aug 2016 06:22:16 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:59272 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbcHaKWO (ORCPT ); Wed, 31 Aug 2016 06:22:14 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] regulator: hi6421: mark hi6421_regulator_ldo_get_optimum_mode() static Date: Wed, 31 Aug 2016 12:01:34 +0200 Message-ID: <5303623.mSi73Wy9ko@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472635831-20290-1-git-send-email-baoyou.xie@linaro.org> References: <1472635831-20290-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xDY2PSJMrsqb9rderTVtjQIkWvWKfBP9J8eIc3Kukcpg5f9e+bm IpmK80hTy2sEsX1cdaftVDecwmrmWxVqIPKz8AkaQiFoObFNnFB0OzHC8Iy52IzAlAoQ6VW 326v3tzrJ+SbcHrhhd0lS5VKtSmX81d2FCmaagAg5VkXAtqA4fGpruT7LSXgPSTej+1fW5m a1/J/WaRmMci7dqlVaHuA== X-UI-Out-Filterresults: notjunk:1;V01:K0:2p7s5jnj2mY=:j8L9a+gQK8RctD39iSqgxb NhY4WTZj9h7L6RXWigGoZP0nEcrrS6vo2IpJnTVMM3Ui6jf3P3pg2shAEYSuqVGPHNN4AcxeA 2405XT3icLaHRM8PBErp32sMDFKHNFEs7mOWDAuzkLWbQ4F70nSurE2N89XMhV9X+FrH6NbN3 O2YP9/LRdHRvf3xSzM4iJtvHgw8AhW6LbgW1P0jAqyTQHcAJ8RTsuGC7sz3x/oPqooUTl+UO8 GIpXt20/IezhDzsAaHrnRIc9CBMvKe7EZvCYqc1TbufSM0MfwSEM05sBkWD8thXulA/ocPWQs qeV6bVfw/V2C6fuxYO/VhEiXcx9yOmR/u8HRPzHvsy+tDBl1JZuyP1H4AGf9GTO1DWZsHwaVc Zr5BQ59ZvzQwWw0fY0qejzzjJzazoFdT63sewvnvKvjiCt208/5m/szNfXCViQ9DUKS1QUI0d b2P1ExYOj6vW+nigMXPXAlhqeY/pIgxyq7xAoFtclUq7FHM0iRxHd8ju0Uro/6vqlfeg0lXHV oVBeaZQHiEYLXNxn+C3K6A8/+x0RjsVOZPucsKbXD/U89Uk1WZ/QOx5yU+hdcVnhkPGugtIg6 hqKodmZ5vuzfQwp1wzj17lDa1sxvCvLMxEUYI7sOcD91I4jqIghg92HyhF+bTkcQIEPo/Wtd0 w4LqGXO3vi/kka0bjE9Tul2TKgoDbcmxQGyoRLXtbY8VcKPK8bjzRj0k1RrKvMpvTzMkCDeH9 ng8poBLdk2euYjl3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 5:30:31 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/regulator/hi6421-regulator.c:480:14: warning: no previous prototype for > 'hi6421_regulator_ldo_get_optimum_mode' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann