From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B4327CCF0 for ; Wed, 11 Mar 2026 13:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773234112; cv=none; b=bmXEbJaSbp7fiz7c/P39WOpAs40PUinEsEiw/2v2WGZ4i4bw++/6FokpZyxuyiUXz0tLoVjIhEG0z0pqTvKX3EAjMD0kkc9jNdxSpWtZPD/8/XUfDuQSr3qekt+8S7tpl16xpz84oibUtvgLpxzZBYAhbgIlCupB5ym47W5PjYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773234112; c=relaxed/simple; bh=w3DdBqnwYzlppHJlA0FKUqhcUqEniEi+aCNpmhpnk/Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a5GKggacgbE39BA544wGWF8yF+JWd6CsQqW6TGw8Zo0Bz0tDZl6UQJ3YxAXiJkxSu4AND52MnEJLf0I9nMhJlrU7uXpfCQzzTyoBEtsZTEmEpw5+NRglbMUWwXJ0Vym9t9En1fTAidc4VDecaAuR2eK9AA2+vhMqNRDp7AgAoQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ksKYSHzQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ze3iS3RC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ksKYSHzQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ze3iS3RC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B7brQ01265877 for ; Wed, 11 Mar 2026 13:01:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WXcLvHbkZw0uXVaZr0o1vWk4BkeOU64L8yo+XGnvNBE=; b=ksKYSHzQ3430mJLW 24gLPMOMJuhdnhQqN+ZLprglRvOIqbSetPAYh0jznUcwwoNm6LTMYPn2mEH4rBMl sjUg3vdeElCRgRXiTHmWq7Lj/5NfST7wTETyr34xKIUGMvg8w4tJbu7LFqV2uq+A yyOi52tFqO9Nr+e/6z8f2p/AgU7Ff2GkbR+XGOhe6PJlrkD9+P0ZGjei9ytJkuqw yZYaKF0aPTXObYlKAHtamWRSMSy4t6pVqS8KsVTP6vcMi5+rTY+arLLBCGY2JOTY RcJ6fMGSW4NJ2iNot9v2hfWhcUWrltaoiaSjXupPNzk05IADSXbBwrVN9XmgkRW+ fBEgdg== Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctpkfm2hv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 13:01:50 +0000 (GMT) Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-4173d956b60so3852471fac.0 for ; Wed, 11 Mar 2026 06:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773234110; x=1773838910; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WXcLvHbkZw0uXVaZr0o1vWk4BkeOU64L8yo+XGnvNBE=; b=Ze3iS3RCB4eGJvGseGehpLu9vCWP+yyug91wYMcknqxrlNsOtKrakO/V41xeKRWw0l Sp9Ap0ayg5EaAasqs6SJlL/b2KR9pA5PPVf5V01pkjcr3K2HMlaVNXfr9pwSHy/QlPld rsq2ca92J1qaJiR99WQ//UXhUhSJ6JyHiRTP9kRJe1WER1cEnfGcnc/aW16JJHSL9bL6 ZEXrD48ix1a7ddfWNQxGpI2lWIi32m2Y1SjNsL9IL5w/SOShFB7ptLwrkFe30yS/6rTr JqnyXUf1ZIw2oLaDZffRf/eHCR+YYgxjF7HFHNEdUcCSIHsnPTo9M+QXolYhhXhIL4SW yQ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773234110; x=1773838910; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WXcLvHbkZw0uXVaZr0o1vWk4BkeOU64L8yo+XGnvNBE=; b=RrrkqCpJSM/X2Sbj920kfNeOnEPUq35XMDleYU94EgG6mFvt9GySdiw9L2O1wlMPtH gwalPLKta+crb5AT9UZCvnZ6OLOfmhw+JmDf0zy+3thgCnpluy+Esk2hSlr5tL1igNzx 9XaGyVtevYudmuae+/r9V8y9Yix4NfbxXPY3NA9kafqg/i+oKQrKphXY+S+ERNQlj1ie EkSMWH4w8Ufi3O/XsevvFzJJ77dnI5J1CCpQzeoQAQs0HUzpEpBgE1A5dY76HmU8J4nv KxAtJq/MHidSpN1TkFaWPG8kXEyIzeUoLR4JP8sx+1idvQ/ebAS6hsCHd+IRRe01I+z+ JOWA== X-Forwarded-Encrypted: i=1; AJvYcCW1Ot24GH3a4WNJPFDiXX8nJoBFupzTK6UXrA4IaMOJJ+VffNdd3tlzOdh4wXejzqC0iMT+4Fcfk75oxSA=@vger.kernel.org X-Gm-Message-State: AOJu0YyW2uW7/gQpth2AWV0iygxYA9KeFIbNZQGxKjIZdquBwkZknHlW i3Bp1fziejmrMHeWgJx/2s+w4VCVv0lkDMrW/y2IbsO473awG4yPGNzBRoBTuBl0M8Nw2BnWbTv DpZSjrxiBeTpi71ctNzTSAf1FD3WIaoe4xQe4HI+E7GsM35RYOBIKscELaVm9nDiEzoc= X-Gm-Gg: ATEYQzx8NgHHbi4vefwOcWbl0SMb4RZicgYcuBNkRtSyfZhnaffZq1GbN0nYVUgIm3W kB6inj/lTWKwTEt1tOQ+nruEB4ZIg6OA1mt3A3GPKqG2YOemNqlzUjnRHVLl/FVtK+UFHj4TjHg 3pzXIUPnT4ooQ7f2X/UB24l40Wc+VY/QWKh4NCXKjgM8Q53Gx8RPSVFqFpNP9U26NJNIS3VhZ3t xhiPepDCXJgdk6v+iH4S32q70s96P5uVQgWzO+51CwAr7twPBF7Q5yGrpRY28i82Ud//FG9oBv6 XrrI5cJmzBDiVGiqAZu8VHc7jWXNPeIq7ww7em6ZKYNjFhEf2JlbjYdjAARqWgK/EMNDt1FHAJ9 SEDhoIjfQApqUbpl85DmeR2BGwY/5fD18nVtT3dX5c5dun9BZ7FhQ7NYAR4PvD3PJeLDHc8o83n m6E9U= X-Received: by 2002:a05:6870:a199:b0:408:a779:41a7 with SMTP id 586e51a60fabf-4177c9fd737mr1130453fac.7.1773234108102; Wed, 11 Mar 2026 06:01:48 -0700 (PDT) X-Received: by 2002:a05:6870:a199:b0:408:a779:41a7 with SMTP id 586e51a60fabf-4177c9fd737mr1130324fac.7.1773234105957; Wed, 11 Mar 2026 06:01:45 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6631532db0dsm524054a12.32.2026.03.11.06.01.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 06:01:44 -0700 (PDT) Message-ID: <5304144a-0907-4b7e-8c65-d0d37e74e9f8@oss.qualcomm.com> Date: Wed, 11 Mar 2026 14:01:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] usb: typec: qcom: Add support for shared USBIN VBUS detection To: Alexander Koskovich , Bryan O'Donoghue , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260308-qcom-typec-shared-vbus-v1-0-7d574b91052a@pm.me> <20260308-qcom-typec-shared-vbus-v1-2-7d574b91052a@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260308-qcom-typec-shared-vbus-v1-2-7d574b91052a@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: RzfUjHO2SdbJoAAm41OEV9Nalw00WEwA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDExMCBTYWx0ZWRfX+zkDC7/TKtGN rXbMP3k3EIzLz/YbiPS+JB8Jrdu3Y102LsEha1UpuITBFRaxboURlbUnGq/sXZpSMvqHCkEx/Xz g+sGCcM4pKfTsXrtyfNDuMLJqFVlVH4N8ZylEDq52esCoXsyfOmtrs0/vG2kUB6ftF58+3FnClZ xO1TLBWj3B/3LYUPxDeiFRYgy6Z52eAFQnyl2brm7ZemrP1jBXy6hGP187McS0yBBxCHX7HSJjr wYikirumpTIrUnexN6tAA+AJBg9/EoVQ0ddnjPwdWhbA/hw4f9y3jgVRe0z7bbBwXGV6DrqUhbp xlTai+8deyYsR3VxFTz0PvIrcmvy0bRGl6Anlly0yWOxQKnpCGnehKQCpkHb2doieWhCm35PlbB U1xqMuy5G3tv0Mpwzlwm012N+p9W4MOUITXFGiiKJ3lo7DK0G4a4Siew+UQ3tSCLZLsyFUyfBsp 9kutm3+tumgJhL8puYA== X-Proofpoint-ORIG-GUID: RzfUjHO2SdbJoAAm41OEV9Nalw00WEwA X-Authority-Analysis: v=2.4 cv=Gq5PO01C c=1 sm=1 tr=0 ts=69b167be cx=c_pps a=zPxD6eHSjdtQ/OcAcrOFGw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=A_zI2UM3U9TYkvnQF4QA:9 a=QEXdDO2ut3YA:10 a=y8BKWJGFn5sdPF1Y92-H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110110 On 3/9/26 12:20 AM, Alexander Koskovich wrote: > On devices with multiple USB-C ports whose VBUS lines are wired to a > single shared USBIN input on the PM8150B PMIC (e.g. ASUS ROG Phone 3), the > Type-C port controller cannot distinguish which port is providing VBUS. > > In practice this shows up as being unable to use the affected Type-C port > while the other port is connected to a device providing VBUS such as a PC > or charger. > > Add support for an optional vbus-detect-gpios property that allows the > Type-C port controller to read VBUS state from a per-port GPIO instead of > the shared USBIN input. When present, the driver also bypasses VSAFE0V > checks and switches DRP toggling to TRY_SRC to avoid false source > detection caused by VBUS present on USBIN from another port. > > Signed-off-by: Alexander Koskovich > --- [...] > + if (pmic_typec_port->vbus_detect_gpio) { > + vbus = gpiod_get_value_cansleep(pmic_typec_port->vbus_detect_gpio); > + return vbus; "return gpiod_..." [...] > + /* > + * On devices with multiple USB-C ports sharing USBIN, bypass > + * VSAFE0V so SRC attachment can complete despite VBUS being > + * present on USBIN from another port. > + */ > + if (pmic_typec_port->vbus_detect_gpio) { > + ret = regmap_update_bits(pmic_typec_port->regmap, > + pmic_typec_port->base + TYPEC_EXIT_STATE_CFG_REG, > + BYPASS_VSAFE0V_DURING_ROLE_SWAP, > + BYPASS_VSAFE0V_DURING_ROLE_SWAP); regmap_set_bits() > + if (ret) > + goto done; > + } > + > pmic_typec_port->tcpm_port = tcpm_port; > > for (i = 0; i < pmic_typec_port->nr_irqs; i++) > @@ -724,6 +760,12 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev, > if (IS_ERR(pmic_typec_port->vdd_vbus)) > return PTR_ERR(pmic_typec_port->vdd_vbus); > > + pmic_typec_port->vbus_detect_gpio = devm_gpiod_get_optional(dev, "vbus-detect", > + GPIOD_IN); I thought the intent here was to have 2 GPIOs, one per port - could you please shed some light on this? Konrad