From: Lan Tianyu <tianyu.lan@intel.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Tejun Heo <tj@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()
Date: Fri, 21 Feb 2014 10:34:22 +0800 [thread overview]
Message-ID: <5306BB2E.7010007@intel.com> (raw)
In-Reply-To: <20140220151721.GB32719@redhat.com>
On 02/20/2014 11:17 PM, Oleg Nesterov wrote:
> On 02/20, Oleg Nesterov wrote:
>>
>> On 02/20, Lan Tianyu wrote:
>>>
>>> @@ -1096,7 +1112,6 @@ int acpi_processor_set_throttling(struct acpi_processor *pr,
>>> return -ENODEV;
>>> }
>>>
>>> - cpumask_copy(saved_mask, ¤t->cpus_allowed);
>>
>> Yes, but the patch forgets to kill alloc_cpumask_var(&saved_mask)
>> and saved_mask itself ;
>
> And it seems that acpi_processor_set_throttling() doesn't need
> online_throttling_cpus at all. It could use
> for_each_cpu_and(cpu_online_mask, p_throttling->shared_cpu_map).
>
Yes, oops and will update soon. Thanks.
> Oleg.
>
--
Best Regards
Tianyu Lan
next prev parent reply other threads:[~2014-02-21 2:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140213124059.GA2908@krava.brq.redhat.com>
2014-02-17 17:19 ` Oleg Nesterov
2014-02-18 22:49 ` Tejun Heo
2014-02-20 13:28 ` Lan Tianyu
2014-02-20 14:31 ` Jiri Olsa
2014-02-20 14:45 ` Lan Tianyu
2014-02-20 14:53 ` Jiri Olsa
2014-02-20 15:13 ` Oleg Nesterov
2014-02-20 15:17 ` Oleg Nesterov
2014-02-21 2:34 ` Lan Tianyu [this message]
2014-02-21 5:35 ` [PATCH] ACPI/Processor: Rework processor throttling with work_on_cpu() Lan Tianyu
2014-02-21 10:06 ` Jiri Olsa
2014-02-21 17:07 ` Jiri Olsa
2014-02-24 9:27 ` Lan Tianyu
2014-02-26 1:23 ` Rafael J. Wysocki
2014-02-26 1:08 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306BB2E.7010007@intel.com \
--to=tianyu.lan@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome