From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Michael Walle <mwalle@kernel.org>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 11/41] mtd: spi-nor: drop .parse_sfdp
Date: Wed, 6 Sep 2023 15:55:06 +0100 [thread overview]
Message-ID: <530942be-4175-43d5-a111-c433be7eff72@linaro.org> (raw)
In-Reply-To: <20230807-mtd-flash-info-db-rework-v2-11-291a0f39f8d8@kernel.org>
On 8/22/23 08:09, Michael Walle wrote:
> Drop the size parameter to indicate we need to do SFDP, we can do that
> because it is guaranteed that the size will be set by SFDP and because
> PARSE_SFDP forced the SFDP parsing it must be overwritten.
>
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
> drivers/mtd/spi-nor/core.c | 3 +--
> drivers/mtd/spi-nor/core.h | 23 ++++++++++++++++-------
> drivers/mtd/spi-nor/eon.c | 3 +--
> drivers/mtd/spi-nor/gigadevice.c | 3 +--
> drivers/mtd/spi-nor/issi.c | 4 +---
> drivers/mtd/spi-nor/macronix.c | 1 -
> drivers/mtd/spi-nor/spansion.c | 12 ------------
> drivers/mtd/spi-nor/sst.c | 1 -
> drivers/mtd/spi-nor/winbond.c | 7 ++-----
> 9 files changed, 22 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 368851ff9f40..4ba1778eda4b 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2017,7 +2017,6 @@ static const struct spi_nor_manufacturer *manufacturers[] = {
>
> static const struct flash_info spi_nor_generic_flash = {
> .name = "spi-nor-generic",
> - .parse_sfdp = true,
> };
>
> static const struct flash_info *spi_nor_match_id(struct spi_nor *nor,
> @@ -3069,7 +3068,7 @@ static int spi_nor_init_params(struct spi_nor *nor)
>
> spi_nor_init_default_params(nor);
>
> - if (nor->info->parse_sfdp) {
> + if (spi_nor_needs_sfdp(nor)) {
> ret = spi_nor_parse_sfdp(nor);
> if (ret) {
> dev_err(nor->dev, "BFPT parsing failed. Please consider using SPI_NOR_SKIP_SFDP when declaring the flash\n");
> diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
> index fba3ea8536a5..9e6ad02b03b0 100644
> --- a/drivers/mtd/spi-nor/core.h
> +++ b/drivers/mtd/spi-nor/core.h
> @@ -460,9 +460,6 @@ struct spi_nor_fixups {
> * @page_size: (optional) the flash's page size. Defaults to 256.
> * @addr_nbytes: number of address bytes to send.
> *
> - * @parse_sfdp: true when flash supports SFDP tables. The false value has no
> - * meaning. If one wants to skip the SFDP tables, one should
> - * instead use the SPI_NOR_SKIP_SFDP sfdp_flag.
> * @flags: flags that indicate support that is not defined by the
> * JESD216 standard in its SFDP tables. Flag meanings:
> * SPI_NOR_HAS_LOCK: flash supports lock/unlock via SR
> @@ -521,7 +518,6 @@ struct flash_info {
> u8 n_banks;
> u8 addr_nbytes;
>
> - bool parse_sfdp;
> u16 flags;
> #define SPI_NOR_HAS_LOCK BIT(0)
> #define SPI_NOR_HAS_TB BIT(1)
> @@ -598,9 +594,6 @@ struct flash_info {
> .n_regions = (_n_regions), \
> },
>
> -#define PARSE_SFDP \
> - .parse_sfdp = true, \
> -
> #define FLAGS(_flags) \
> .flags = (_flags), \
>
> @@ -740,6 +733,22 @@ static inline struct spi_nor *mtd_to_spi_nor(struct mtd_info *mtd)
> return container_of(mtd, struct spi_nor, mtd);
> }
>
> +/**
> + * spi_nor_needs_sfdp() - returns true if SFDP parsing is used for this flash.
> + *
> + * Return: true if SFDP parsing is needed
> + */
> +static inline bool spi_nor_needs_sfdp(const struct spi_nor *nor)
> +{
> + /*
> + * The flash size is one property parsed by the SFDP. We use it as an
> + * indicator whether we need SFDP parsing for a particular flash. I.e.
> + * non-legacy flash entries in flash_info will have a size of zero iff
> + * SFDP should be used.
> + */
> + return nor->info->size;
the condition looks broken. the method returns bool, but here you return
size_t probably. And when size is zero one shall parse sfdp, not the
other way around.
maybe return (nor->info->size == 0)?
> +}
> +
> #ifdef CONFIG_DEBUG_FS
> void spi_nor_debugfs_register(struct spi_nor *nor);
> void spi_nor_debugfs_shutdown(void);
> diff --git a/drivers/mtd/spi-nor/eon.c b/drivers/mtd/spi-nor/eon.c
> index 50a11053711f..434aaf155856 100644
> --- a/drivers/mtd/spi-nor/eon.c
> +++ b/drivers/mtd/spi-nor/eon.c
> @@ -25,8 +25,7 @@ static const struct flash_info eon_nor_parts[] = {
> { "en25qh64", INFO(0x1c7017, 0, 64 * 1024, 128)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ) },
> { "en25qh128", INFO(0x1c7018, 0, 64 * 1024, 256) },
> - { "en25qh256", INFO(0x1c7019, 0, 64 * 1024, 512)
> - PARSE_SFDP },
> + { "en25qh256", INFO(0x1c7019, 0, 64 * 1024, 0) },
> { "en25s64", INFO(0x1c3817, 0, 64 * 1024, 128)
> NO_SFDP_FLAGS(SECT_4K) },
> };
> diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c
> index d57ddaf1525b..7cf142c75529 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -62,8 +62,7 @@ static const struct flash_info gigadevice_nor_parts[] = {
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> - { "gd25q256", INFO(0xc84019, 0, 64 * 1024, 512)
> - PARSE_SFDP
> + { "gd25q256", INFO(0xc84019, 0, 64 * 1024, 0)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6)
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> .fixups = &gd25q256_fixups },
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index accdf7aa2bfd..9d22b799ce94 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -62,8 +62,7 @@ static const struct flash_info issi_nor_parts[] = {
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ) },
> { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ) },
> - { "is25lp256", INFO(0x9d6019, 0, 64 * 1024, 512)
> - PARSE_SFDP
> + { "is25lp256", INFO(0x9d6019, 0, 64 * 1024, 0)
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> .fixups = &is25lp256_fixups },
> { "is25wp032", INFO(0x9d7016, 0, 64 * 1024, 64)
> @@ -73,7 +72,6 @@ static const struct flash_info issi_nor_parts[] = {
> { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "is25wp256", INFO(0x9d7019, 0, 0, 0)
> - PARSE_SFDP
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> FLAGS(SPI_NOR_QUAD_PP)
> .fixups = &is25lp256_fixups },
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
> index eb149e517c1f..0f3bd3ed8eff 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -83,7 +83,6 @@ static const struct flash_info macronix_nor_parts[] = {
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
> { "mx25uw51245g", INFOB(0xc2813a, 0, 0, 0, 4)
> - PARSE_SFDP
> FLAGS(SPI_NOR_RWW) },
> { "mx25v8035f", INFO(0xc22314, 0, 64 * 1024, 16)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 709822fced86..e6468569f178 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -849,59 +849,47 @@ static const struct flash_info spansion_nor_parts[] = {
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
> { "s25fs256t", INFO6(0x342b19, 0x0f0890, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25fs256t_fixups },
> { "s25hl512t", INFO6(0x342a1a, 0x0f0390, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> { "s25hl01gt", INFO6(0x342a1b, 0x0f0390, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> { "s25hl02gt", INFO6(0x342a1c, 0x0f0090, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> FLAGS(NO_CHIP_ERASE)
> .fixups = &s25hx_t_fixups },
> { "s25hs512t", INFO6(0x342b1a, 0x0f0390, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> { "s25hs01gt", INFO6(0x342b1b, 0x0f0390, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> { "s25hs02gt", INFO6(0x342b1c, 0x0f0090, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> FLAGS(NO_CHIP_ERASE)
> .fixups = &s25hx_t_fixups },
> { "cy15x104q", INFO6(0x042cc2, 0x7f7f7f, 512 * 1024, 1)
> FLAGS(SPI_NOR_NO_ERASE) },
> { "s28hl512t", INFO(0x345a1a, 0, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> { "s28hl01gt", INFO(0x345a1b, 0, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> { "s28hs512t", INFO(0x345b1a, 0, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> { "s28hs01gt", INFO(0x345b1b, 0, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> { "s28hs02gt", INFO(0x345b1c, 0, 0, 0)
> - PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index 197d2c1101ed..57df68eab6aa 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -115,7 +115,6 @@ static const struct flash_info sst_nor_parts[] = {
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ) },
> { "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> - PARSE_SFDP
> .fixups = &sst26vf_nor_fixups },
> { "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index cd99c9a1c568..c21fed842762 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -126,8 +126,7 @@ static const struct flash_info winbond_nor_parts[] = {
> { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> .fixups = &w25q256_fixups },
> - { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512)
> - PARSE_SFDP },
> + { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 0) },
> { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> @@ -135,10 +134,8 @@ static const struct flash_info winbond_nor_parts[] = {
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> { "w25q512nwq", INFO(0xef6020, 0, 0, 0)
> - PARSE_SFDP
> OTP_INFO(256, 3, 0x1000, 0x1000) },
> - { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024)
> - PARSE_SFDP
> + { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 0)
> OTP_INFO(256, 3, 0x1000, 0x1000) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>
next prev parent reply other threads:[~2023-09-06 14:55 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:09 [PATCH v2 00/41] mtd: spi-nor: clean the flash_info database up Michael Walle
2023-08-22 7:09 ` [PATCH v2 01/41] mtd: spi-nor: remove catalyst 'flashes' Michael Walle
2023-08-24 7:55 ` Tudor Ambarus
2023-08-24 8:33 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 02/41] mtd: spi-nor: remove Fujitsu MB85RS1MT support Michael Walle
2023-08-24 7:56 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 03/41] mtd: spi-nor: xilinx: use SPI_NOR_ID() in S3AN_INFO() Michael Walle
2023-08-24 7:59 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 04/41] mtd: spi-nor: xilinx: remove addr_nbytes from S3AN_INFO() Michael Walle
2023-08-24 8:13 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 05/41] mtd: spi-nor: convert .n_sectors to .size Michael Walle
2023-08-24 8:25 ` Tudor Ambarus
2023-09-01 11:00 ` Michael Walle
2023-08-22 7:09 ` [PATCH v2 06/41] mtd: spi-nor: default page_size to 256 bytes Michael Walle
2023-08-24 8:36 ` Tudor Ambarus
2023-09-01 11:03 ` Michael Walle
2023-08-22 7:09 ` [PATCH v2 07/41] mtd: spi-nor: store .n_banks in struct spi_nor_flash_parameter Michael Walle
2023-08-24 8:41 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 08/41] mtd: spi-nor: default .n_banks to 1 Michael Walle
2023-08-24 8:42 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 09/41] mtd: spi-nor: push 4k SE handling into spi_nor_select_uniform_erase() Michael Walle
2023-09-05 14:59 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 10/41] mtd: spi-nor: make sector_size optional Michael Walle
2023-09-06 5:44 ` Tudor Ambarus
2023-09-06 6:52 ` Michael Walle
2023-08-22 7:09 ` [PATCH v2 11/41] mtd: spi-nor: drop .parse_sfdp Michael Walle
2023-09-06 6:01 ` Tudor Ambarus
2023-09-06 6:55 ` Michael Walle
2023-09-06 14:55 ` Tudor Ambarus [this message]
2023-09-07 6:55 ` Michael Walle
2023-08-22 7:09 ` [PATCH v2 12/41] mtd: spi-nor: introduce (temporary) INFO0() Michael Walle
2023-09-06 6:04 ` Tudor Ambarus
2023-09-06 7:04 ` Michael Walle
2023-08-22 7:09 ` [PATCH v2 13/41] mtd: spi-nor: move the .id and .id_len into an own structure Michael Walle
2023-09-06 6:12 ` Tudor Ambarus
2023-09-06 7:13 ` Michael Walle
2023-09-06 7:15 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 14/41] mtd: spi-nor: rename .otp_org to .otp and make it a pointer Michael Walle
2023-09-06 7:25 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 15/41] mtd: spi-nor: add SNOR_ID() and SNOR_OTP() Michael Walle
2023-09-06 7:28 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 16/41] mtd: spi-nor: remove or move flash_info comments Michael Walle
2023-09-06 7:28 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 17/41] mtd: spi-nor: atmel: convert flash_info to new format Michael Walle
2023-09-06 7:35 ` Tudor Ambarus
2023-09-06 7:38 ` Michael Walle
2023-09-07 8:13 ` Michael Walle
2023-09-07 9:45 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 18/41] mtd: spi-nor: eon: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 19/41] mtd: spi-nor: esmt: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 20/41] mtd: spi-nor: everspin: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 21/41] mtd: spi-nor: gigadevice: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 22/41] mtd: spi-nor: intel: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 23/41] mtd: spi-nor: issi: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 24/41] mtd: spi-nor: macronix: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 25/41] mtd: spi-nor: micron-st: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 26/41] mtd: spi-nor: spansion: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 27/41] mtd: spi-nor: sst: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 28/41] mtd: spi-nor: winbond: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 29/41] mtd: spi-nor: xilinx: use new macros in S3AN_INFO() Michael Walle
2023-08-22 7:09 ` [PATCH v2 30/41] mtd: spi-nor: xmc: convert flash_info to new format Michael Walle
2023-08-22 7:09 ` [PATCH v2 31/41] mtd: spi-nor: atmel: sort flash_info database Michael Walle
2023-08-22 7:09 ` [PATCH v2 32/41] mtd: spi-nor: eon: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 33/41] mtd: spi-nor: gigadevice: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 34/41] mtd: spi-nor: issi: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 35/41] mtd: spi-nor: macronix: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 36/41] mtd: spi-nor: micron-st: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 37/41] mtd: spi-nor: spansion: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 38/41] mtd: spi-nor: sst: " Michael Walle
2023-08-22 7:09 ` [PATCH v2 39/41] mtd: spi-nor: winbond: sort flash_info entries Michael Walle
2023-09-06 7:36 ` Tudor Ambarus
2023-09-07 8:14 ` Michael Walle
2023-09-07 9:42 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 40/41] mtd: spi-nor: atmel: drop duplicate entry Michael Walle
2023-09-06 7:39 ` Tudor Ambarus
2023-08-22 7:09 ` [PATCH v2 41/41] mtd: spi-nor: core: get rid of the INFOx() macros Michael Walle
2023-09-06 7:40 ` Tudor Ambarus
2023-09-06 7:43 ` [PATCH v2 00/41] mtd: spi-nor: clean the flash_info database up Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530942be-4175-43d5-a111-c433be7eff72@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®