From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH] libfdt: check return value of fdt_num_mem_rsv() in fdt_pack()
Date: Tue, 2 Jul 2024 22:27:19 +0200 [thread overview]
Message-ID: <530a2dcf-82ad-4e59-a162-5d3080766e6c@canonical.com> (raw)
In-Reply-To: <8b083a48-5e56-493a-b235-60afaf794fd7@web.de>
On 7/2/24 14:54, Markus Elfring wrote:
>> fdt_num_mem_rsv() may return -FDT_ERR_TRUNCATED.
>> In this case fdt_pack() should propagate the error code.
>
> 1. Please choose imperative wordings for an improved change description.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94
The current subject is an imperative?
>
> 2. Would you like to add any tags (like “Fixes” and “Cc”)?
d5db5382c5e5 ("libfdt: Safer access to memory reservations") introduced
the check that returns the error code. But before that we could simply
overrun the buffer. I would not know which patch to blame.
Whom do you want to Cc?
>
> 3. How do you think about to use a summary phrase like “Complete error handling
> in fdt_pack()”?
>
Why should I choose a less specific subject?
Best regards
Heinrich
next prev parent reply other threads:[~2024-07-02 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 21:54 [PATCH 1/1] " Heinrich Schuchardt
2024-07-02 12:54 ` [PATCH] " Markus Elfring
2024-07-02 20:27 ` Heinrich Schuchardt [this message]
2024-07-03 8:43 ` Markus Elfring
2024-07-02 17:31 ` [PATCH 1/1] " Rob Herring
2024-07-02 20:31 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530a2dcf-82ad-4e59-a162-5d3080766e6c@canonical.com \
--to=heinrich.schuchardt@canonical.com \
--cc=Markus.Elfring@web.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®