From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62668C433F5 for ; Thu, 28 Apr 2022 07:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244881AbiD1HJ1 (ORCPT ); Thu, 28 Apr 2022 03:09:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244801AbiD1HJT (ORCPT ); Thu, 28 Apr 2022 03:09:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 958377CDD6 for ; Thu, 28 Apr 2022 00:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651129564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RX0IluUFjyFGJB9XgIGY/YNKpJD21MjW7iyGoQ/bciQ=; b=MgCRQOR0bXRwCG/n9wB3V/1V5KF7AWuuzIMVPknPI4vVCSoQUbZH5PD17M/bicFwyCK9zd U/c+O6emWUPdgwPJC0U7hmZdBHcKzCzJPpiiZKIqxmIpg0F+bxXZzlHF14bswCE95j41Bt KWQsumSgUPpfKbM7Lxgo1yrCyjPR6xo= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-260-uIZMLnaMMkSTSVrOnAexow-1; Thu, 28 Apr 2022 03:06:03 -0400 X-MC-Unique: uIZMLnaMMkSTSVrOnAexow-1 Received: by mail-qt1-f199.google.com with SMTP id i3-20020ac813c3000000b002f202d9471dso2725855qtj.15 for ; Thu, 28 Apr 2022 00:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=RX0IluUFjyFGJB9XgIGY/YNKpJD21MjW7iyGoQ/bciQ=; b=eGMOW9f+tIZYaFMuyRugZb2DccstpHb2t2Zunk1GBV4gBgeogMyS9KWlrqe9D3RbNm EKdamZyrlNS53ULBLaRBfDHNU7PGbNMQzepX5UJPi/JdBYUZ08RHJh7O8Ce4lT87FxBN RSAFjJtDEFHUr27zE/i0Ymoc0BVUYyB7aMQCb4P9pwTGwm+67v7bqAEYD6zn4fob05IQ ilInjrWzBw9VnM57ny+ngOImWMZ5ZGKseRgnG6VqmmGZYUcqtZFKu8cqxd7h22SWoM++ KQ5UnbabnaWCua5hnOnK4TVpNf3t4K/BDP/mxNY07j5fvCu9gBLer/Fb1OcZRkTaGOZE OgWQ== X-Gm-Message-State: AOAM531anJCi4HI8x9brZwA/JEwcRBRXDvXi43njjikwv8ZQuIt1qDyA DJ1FIhqn2IqrCVOgfHzBP9aXMsKxlctkFdPVVquKfUtCkNM/5MNsa28AZGXn4dCWl32cjuxhito 0Wpt3fbEyuFmym32q1v52lCAp X-Received: by 2002:ac8:5fcb:0:b0:2f3:4799:1649 with SMTP id k11-20020ac85fcb000000b002f347991649mr22339580qta.522.1651129562779; Thu, 28 Apr 2022 00:06:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU2oeLrstNHTLoVNiOiYqy8PCp5qFcyD0PvqMZ6dBrsfSJtI6yAgZINx2lBg+bbQaYrXCEkQ== X-Received: by 2002:ac8:5fcb:0:b0:2f3:4799:1649 with SMTP id k11-20020ac85fcb000000b002f347991649mr22339552qta.522.1651129562541; Thu, 28 Apr 2022 00:06:02 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-117-160.dyn.eolo.it. [146.241.117.160]) by smtp.gmail.com with ESMTPSA id p13-20020a05622a048d00b002e1ce0c627csm11706888qtx.58.2022.04.28.00.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 00:06:02 -0700 (PDT) Message-ID: <530adc71b52e774c92c53d235701710dbc9866a9.camel@redhat.com> Subject: Re: [PATCH net 1/1] net: stmmac: disable Split Header (SPH) for Intel platforms From: Paolo Abeni To: Tan Tee Min , Kurt Kanzenbach Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Michael Sit Wei Hong , Xiaoliang Yang , Wong Vee Khee , Ling Pei Lee , Bhupesh Sharma , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Voon Wei Feng , Song Yoong Siang , Ong@vger.kernel.org, Boon Leong , Tan Tee Min Date: Thu, 28 Apr 2022 09:05:57 +0200 In-Reply-To: <20220428015538.GC26326@linux.intel.com> References: <20220426074531.4115683-1-tee.min.tan@linux.intel.com> <8735i0ndy7.fsf@kurt> <20220428015538.GC26326@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, 2022-04-28 at 09:55 +0800, Tan Tee Min wrote: > On Tue, Apr 26, 2022 at 03:58:56PM +0200, Kurt Kanzenbach wrote: > > Hi, > > > > On Tue Apr 26 2022, Tan Tee Min wrote: > > > Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation > > > of Split Header (SPH) feature is not supported for Ipv4 fragmented packet. > > > This SPH limitation will cause ping failure when the packets size exceed > > > the MTU size. For example, the issue happens once the basic ping packet > > > size is larger than the configured MTU size and the data is lost inside > > > the fragmented packet, replaced by zeros/corrupted values, and leads to > > > ping fail. > > > > > > So, disable the Split Header for Intel platforms. > > > > Does this issue only apply on Intel platforms? > > According to Synopsys IP support, they have confirmed the header-payload > splitting for IPv4 fragmented packets is not supported for the Synopsys > Ether IPs. > > Intel platforms are integrating with GMAC EQoS IP which is impacted by the > limitation above, so we are changing the default SPH setting to disabled > for Intel Platforms only. > > If anyone can confirm on their platform also having the same issues, > then we would change the SPH default to disable across the IPs. Could you please provide a Fixes tag here? Thanks! Paolo