mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: Andi Kleen <ak@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: <tglx@linutronix.de>, <dave.hansen@intel.com>,
	<jpoimboe@redhat.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: Fix potential pte_unmap_unlock pte error
Date: Thu, 14 Jan 2021 10:51:24 +0800	[thread overview]
Message-ID: <530deddf-705e-045d-f7c6-521531dced71@huawei.com> (raw)
In-Reply-To: <20210110171443.GC1914459@tassilo.jf.intel.com>

Hi:
On 2021/1/11 1:14, Andi Kleen wrote:
> On Sat, Jan 09, 2021 at 03:01:18AM -0500, Miaohe Lin wrote:
>> Since commit 42e4089c7890 ("x86/speculation/l1tf: Disallow non privileged
>> high MMIO PROT_NONE mappings"), when the first pfn modify is not allowed,
>> we would break the loop with pte unchanged. Then the wrong pte - 1 would
>> be passed to pte_unmap_unlock.
> 
> Thanks.
> 
> While the fix is correct, I'm not sure if it actually is a real bug. Is there
> any architecture that would do something else than unlocking the underlying
> page?  If it's just the underlying page then it should be always the same
> page, so no bug.
> 

It's just a theoretical issue via code inspection.

> That said of course the change is the right thing for main line, but probably doesn't
> need to be backported.
> 

So it should not be backported. Should I resend a patch or Andrew would kindly do this?

> -Andi
> .
> 

Many thanks for review and reply.

  reply	other threads:[~2021-01-14  2:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09  8:01 Miaohe Lin
2021-01-10 17:14 ` Andi Kleen
2021-01-14  2:51   ` Miaohe Lin [this message]
2021-01-22  8:27     ` Miaohe Lin
2021-01-24  2:01       ` Andrew Morton
2021-01-25  2:04         ` Miaohe Lin
  -- strict thread matches above, loose matches on Subject: below --
2020-10-15 12:15 [PATCH] mm: fix " Shijie Luo
2020-10-15 12:58 ` osalvador
2020-10-15 13:19   ` Shijie Luo
2020-10-16 12:31 ` Michal Hocko
2020-10-16 12:37   ` osalvador
2020-10-16 13:11     ` Michal Hocko
2020-10-16 13:15       ` Michal Hocko
2020-10-16 13:42         ` Michal Hocko
2020-10-16 14:05           ` osalvador
2020-10-17  1:55             ` Shijie Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530deddf-705e-045d-f7c6-521531dced71@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®