From: <Claudiu.Beznea@microchip.com>
To: <Horatiu.Vultur@microchip.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<Nicolas.Ferre@microchip.com>, <UNGLinuxDriver@microchip.com>,
<maxime.chevallier@bootlin.com>
Subject: Re: [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291
Date: Tue, 19 Jul 2022 07:55:56 +0000 [thread overview]
Message-ID: <530ef4f3-26ce-5a90-f2f7-d6163124bfec@microchip.com> (raw)
In-Reply-To: <20220718212921.1506984-3-horatiu.vultur@microchip.com>
On 19.07.2022 00:29, Horatiu Vultur wrote:
> On pcb8291, can0 and the network driver share some of the GPIOs so only
> 1 device can be active. Therefore disable can0 as we want to enable the
> network driver.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 02fbf7371a8d..2cb532aa33f0 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -30,18 +30,6 @@ fc3_b_pins: fc3-b-pins {
> pins = "GPIO_52", "GPIO_53";
> function = "fc3_b";
> };
> -
> - can0_b_pins: can0-b-pins {
> - /* RX, TX */
> - pins = "GPIO_35", "GPIO_36";
> - function = "can0_b";
> - };
> -};
> -
> -&can0 {
> - pinctrl-0 = <&can0_b_pins>;
> - pinctrl-names = "default";
> - status = "okay";
You can just delete the status line here or change it to "disabled" and
leave the rest for reference. For evaluation one could just enable it here
afterwards. On the other AT91 specific boards we are using status =
"disabled"; and a short comment after like this:
status = "disabled"; /* Conflict with gmac0. */
> };
>
> &flx3 {
next prev parent reply other threads:[~2022-07-19 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 21:29 [PATCH 0/3] ARM: dts: lan966x: Extend pcb8291 Horatiu Vultur
2022-07-18 21:29 ` [PATCH 1/3] ARM: dts: lan966x: Add gpio-restart Horatiu Vultur
2022-07-19 7:52 ` Claudiu.Beznea
2022-07-19 20:02 ` Horatiu Vultur - M31836
2022-07-18 21:29 ` [PATCH 2/3] ARM: dts: lan966x: Disable can0 on pcb8291 Horatiu Vultur
2022-07-19 7:55 ` Claudiu.Beznea [this message]
2022-07-19 20:03 ` Horatiu Vultur - M31836
2022-07-18 21:29 ` [PATCH 3/3] ARM: dts: lan966x: Enable network driver " Horatiu Vultur
2022-07-19 7:58 ` Claudiu.Beznea
2022-07-19 20:03 ` Horatiu Vultur - M31836
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530ef4f3-26ce-5a90-f2f7-d6163124bfec@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®