mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Xen <xen-devel@lists.xenproject.org>
Subject: Re: [patch 4/5] xen: Validate online cpus in set_affinity
Date: Wed, 5 Mar 2014 10:36:57 +0000	[thread overview]
Message-ID: <5316FE49.1020203@citrix.com> (raw)
In-Reply-To: <20140304203100.978031089@linutronix.de>

On 04/03/14 20:43, Thomas Gleixner wrote:
> The user space interface does not filter out offline cpus. It merily
> verifies that the mask contains at least one online cpu. So the
> selector in the irq chip implementation needs to make sure to pick
> only an online cpu because otherwise:
> 
>      Offline Core 1
>      Set affinity to 0xe
>      Selector will pick first set bit, i.e. core 1

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

Thanks.

David

  reply	other threads:[~2014-03-05 10:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 20:43 [patch 0/5] genirq: Sanitize irq_set_affinity callbacks Thomas Gleixner
2014-03-04 20:43 ` [patch 1/5] ia64: Validate online cpus in irq_set_affinity() callbacks Thomas Gleixner
2014-03-12 12:15   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2014-03-04 20:43 ` [patch 2/5] mips: " Thomas Gleixner
2014-03-05 11:20   ` Peter Zijlstra
2014-03-05 14:54     ` Thomas Gleixner
2014-03-12 12:15   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2014-03-04 20:43 ` [patch 4/5] xen: Validate online cpus in set_affinity Thomas Gleixner
2014-03-05 10:36   ` David Vrabel [this message]
2014-03-12 12:15   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2014-03-04 20:43 ` [patch 3/5] parisc: Validate online cpus in irq_set_affinity() callbacks Thomas Gleixner
2014-03-12 12:16   ` [tip:irq/core] " tip-bot for Thomas Gleixner
2014-03-04 20:43 ` [patch 5/5] irqchip: armanda: Sanitize set_irq_affinity() Thomas Gleixner
2014-03-06 19:05   ` Jason Cooper
2014-03-07 16:02     ` Gregory CLEMENT
2014-03-07 17:17       ` Thomas Gleixner
2014-03-18 14:06         ` Gregory CLEMENT
2014-03-18 20:55           ` Thomas Gleixner
2014-03-18 21:04             ` Gregory CLEMENT
2014-04-24 16:04               ` Gregory CLEMENT
2014-04-25 11:15                 ` Jason Cooper
2014-04-28 19:05                   ` Thomas Gleixner
2014-04-28 19:33   ` [tip:irq/urgent] " tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5316FE49.1020203@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome