From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99BCD3FC5A1 for ; Thu, 20 Aug 2026 13:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231240; cv=none; b=TN0MszZUCPixw3qgY4zrpEB9Jp6Wa3kFIUS4Hy4QrTWLnK8kcH/3b4wkx1yKTSJrwX8GPTGVCgEaHyMlixKlO+S8aCyB2LbSmXoR3iZWh1jpk64Wdva1JEUvNSjlmM5b0Gh/d1WM++TLWovtD8PSVrNGsn7eaUYpzjwi1HGNghQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231240; c=relaxed/simple; bh=r+O40+jJn36t1mYYkZBI2G6CBbYv0T/fUPRph1eKGlA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xq2KMfUHSzXXn/DPnyCJ/3PYD+XwtDWQIjYAhQ7bea8Pr/SdQ/K9OGwvEixzpNjyD+k1ayB2WBE6cWoWDzeIFl9OZVqtS5mjkIb4Xdp2Pr8FMhMlnSXz/IjLngmmqG3+/gWTrcl/dEVP9++dwPgm4nCLNC2kmRsvqEXwdLm1W4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ui1Qyx+r; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ldv1zDWz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ui1Qyx+r"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ldv1zDWz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787231238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5WeVXudguVsuHtNFC2uAD4H7Hns3vZwhNpfP4RIg3Bw=; b=Ui1Qyx+rMvOgh+ry54SG48VC8ZD9F7JlsN/KigtYTcSQ3AjxEwtuT6kDiVWfktJeEhwqpS COCw3XpCujiZ0N2Bp4+KLjPjD4Qviken9C3pCXN3Ta/NlTGzjUdWXX5FBopH1vbuaG1Zof dkaVumIsPKZEhWtl2eIZ8s5nyQXleL8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-0DteJ_OePEuK_xMCbSPExA-1; Thu, 20 Aug 2026 09:07:17 -0400 X-MC-Unique: 0DteJ_OePEuK_xMCbSPExA-1 X-Mimecast-MFC-AGG-ID: 0DteJ_OePEuK_xMCbSPExA_1787231236 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-47f810c8aebso1414724f8f.2 for ; Thu, 20 Aug 2026 06:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787231236; x=1787836036; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5WeVXudguVsuHtNFC2uAD4H7Hns3vZwhNpfP4RIg3Bw=; b=ldv1zDWzQH4ML+FF0TUkmDEHx4wsA55wTfupkKIIfejd2+HLtUDazdNqyXxmkrPOg5 kXpSMSi/7JgraZ+HTMyM8xU5TVH8EhcMFx1X0ZpNPd0wQO5oNZBAtWcu4FwmfaIm2EIy kX21vYaLycUydG4TquzZWOC1XKhWOgyrlQVi018ojCBrlDUZbJ0SXG4MLJIpbSXDB7m/ XjU8FQ9enRZQKBReiM/nZiAZr/V/n3MEdJgwv0yGMWbsin1d/So9bTkwQnZ3TRu12Jd7 lm2t7/H4a6wwsuArZe7DarvhelQEh2v2jWSK1nnqJBh718OUfCt296EzDvEBY4tHEgd3 7jTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787231236; x=1787836036; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5WeVXudguVsuHtNFC2uAD4H7Hns3vZwhNpfP4RIg3Bw=; b=NPnlO2ZyCQjDfeXXhQGOIU3F5dME6Xbo6kUewYlk/daMS4Bawt63Lkfm2RbwxxLXPZ c0Yos3kjxkgAnTsheJomflPr2ftQ8gM9n2UrGfAA6Nd/KSR3fcI5OxUs9JGvzwH80Wzl /QzxPMuJNHi6ZcfBtGBUDqd5nqLmVffx55lfWyuzxgwpnevMjPohzxrJdmvOEP6GkZZC f9tBJu6FupaE+t1bfKJ5A/BRbxBigF3mn2rojqWI3BFyxeWwmU14fqFsu9CSZhHBw3mD yvfylTW15kyBpUaujc9I96agR5VszSJsn/cMxlsiP0RUVkJ/rFVFiCUnOx/16wuB/eop Aqpw== X-Forwarded-Encrypted: i=1; AHgh+RrpB4inpjGMEYJjkJwVMN2PlVofFypqs18Ck2Ve2tCvKksR7EknP8/jpOcTxzgwIWGxAclSSM0664Z40+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7SpaszzN2lTjCfIUkgUoWN/5UzEbNnUBcnRQ5TAcToqA38uK+ QeiuAWCaR2L9vt7q+VDLd0afBqKMzEot1TKRLtVl5lVEf35NISCc587+uQhe21gSssLmu1Y4Yfz +mM7Ie9izJ8jG/Z66zOfj+DpUDR7IgmQUUZ2/XlqzgDX+IUaMxVAEQSTj92p4+teMais9fRzBAg == X-Gm-Gg: AR+sD10ydOBNFkV1psJKNMVj0bQrleW8uJiJr2eY4QUOTgbgkK93QpnnIiaEKN+tugW riovRlYZD4yR1tsPrUEn7TZ1/+Eo8hbI8LbweIMMBNQIb4aGRXyLn2eVl/7etP1LeP0Z/9c/qjX pxuzZ3R7wJGDQQ3/a/BYWLHRvLqP1hPlsFRuNHg8Kbl6JvI3C5Reqf83t5zc0YdMuUAwHhKW+GO mgKFONDO8Cb/1vU0Ghp/14CHJbmIUTmFNzZxWSySvxiZR4T/z2M1D5l1w5woiRH3aBTiAIF+wEJ 5WsXNFTjIztZRLp5Q0aBS8P6T9I6mfrAf5PRAyDlZdSutxtxnM+XdHW8TGI8MGCU8YOfuE+e1EX h3Tb8kRjMWiKp/1Tcf1gXRM4zEpfgyPvE1UfqjfzOMFlY4trf7ruI+N6QvqhWFZ1MDuLVNnJ2Q8 Q= X-Received: by 2002:a05:600c:8b81:b0:499:8ff5:8ec4 with SMTP id 5b1f17b1804b1-499aa1802a9mr248051955e9.3.1787231236036; Thu, 20 Aug 2026 06:07:16 -0700 (PDT) X-Received: by 2002:a05:600c:8b81:b0:499:8ff5:8ec4 with SMTP id 5b1f17b1804b1-499aa1802a9mr248050695e9.3.1787231235530; Thu, 20 Aug 2026 06:07:15 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aaef1665sm148727235e9.5.2026.08.20.06.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 06:07:14 -0700 (PDT) Message-ID: <531993fb-2485-41fe-8ae0-dfa170a9001a@redhat.com> Date: Thu, 20 Aug 2026 15:07:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling To: ooonea , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260816012109.2865223-1-ooonea@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260816012109.2865223-1-ooonea@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/16/26 3:21 AM, ooonea wrote: > CAKE's autorate-ingress path intends to limit shaper reconfiguration to > once per 250 ms, but last_reconfig_time is only checked and never updated. > Since the field stays zero, every qualifying capacity-estimate window can > call cake_reconfigure(), causing avoidable rate churn and scheduler work > under bursty traffic. > > Store the current timestamp when autorate actually reconfigures the qdisc > so the guard enforces the intended interval. > > Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") > Assisted-by: Codex:gpt-5.5 > Signed-off-by: ooonea The SoB must contain your real full name, and not a nick. /P