mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "PaX Team" <pageexec@freemail.hu>
To: behanw@converseincode.com, Sergei Antonov <saproj@gmail.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
	davem@davemloft.net,
	linux-wireless <linux-wireless@vger.kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	dwmw2@infradead.org, "Jan-Simon Möller" <dl9pf@gmx.de>,
	"Vinícius Tinti" <viniciustinti@gmail.com>,
	"Mark Charlebois" <charlebm@gmail.com>
Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211
Date: Sat, 08 Mar 2014 23:01:48 +0100	[thread overview]
Message-ID: <531B934C.31666.37555A14@pageexec.freemail.hu> (raw)
In-Reply-To: <CABikg9y_j-SDOsMj1C5uogP0HNj6bsB_ySVFtAh_oNgZ0swd=g@mail.gmail.com>

On 8 Mar 2014 at 21:29, Sergei Antonov wrote:

> > -       memset(&aead_req, 0, sizeof(aead_req));
> > +       char aead_req_data[sizeof(struct aead_request) +
> > +                               crypto_aead_reqsize(tfm) +
> > +                               CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR;
                                                     ^^^^^^^^^^^^^^^^^^^^
wouldn't the underlined attribute ensure the required alignment?

> Bad trick with regards to alignment.
> The alignment requirement for struct aead_request is stronger than
> what an array of chars may have.




  parent reply	other threads:[~2014-03-08 22:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 19:52 [PATCH] " behanw
2014-03-07  7:24 ` Johannes Berg
2014-03-08  1:26   ` [PATCH v2] " behanw
2014-03-08  1:56     ` Joe Perches
2014-03-08  2:15       ` Behan Webster
2014-03-08  2:27         ` Joe Perches
2014-03-08 20:17           ` Behan Webster
2014-03-08 14:53         ` Stanislaw Gruszka
2014-03-08 21:36           ` Behan Webster
2014-03-08 20:29     ` Sergei Antonov
2014-03-08 20:42       ` Behan Webster
2014-03-08 22:01       ` PaX Team [this message]
2014-03-08 23:00         ` Sergei Antonov
2014-03-08 23:41           ` Jan-Simon Möller
2014-03-09  1:58           ` Behan Webster
2014-03-19  3:32           ` [PATCH v3] " behanw
2014-03-19 13:51             ` Johannes Berg
2014-03-19 14:25               ` Behan Webster
2014-03-21  6:39               ` [PATCH v4] " behanw
2014-03-21 11:59                 ` Johannes Berg
2014-03-19 14:09             ` [PATCH v3] " David Laight
2014-03-09  0:01       ` [PATCH v2] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531B934C.31666.37555A14@pageexec.freemail.hu \
    --to=pageexec@freemail.hu \
    --cc=behanw@converseincode.com \
    --cc=charlebm@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dl9pf@gmx.de \
    --cc=dwmw2@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=saproj@gmail.com \
    --cc=viniciustinti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®