From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755675AbaCKW7U (ORCPT ); Tue, 11 Mar 2014 18:59:20 -0400 Received: from mailout32.mail01.mtsvc.net ([216.70.64.70]:49262 "EHLO n23.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754969AbaCKW7R (ORCPT ); Tue, 11 Mar 2014 18:59:17 -0400 Message-ID: <531F9540.4020906@hurleysoftware.com> Date: Tue, 11 Mar 2014 18:59:12 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Greg Kroah-Hartman , linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-sh list , One Thousand Gnomes Subject: Re: serial core: crash / race condition on unbind References: <531E7F81.20400@hurleysoftware.com> <531EF864.5020104@hurleysoftware.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-User: 990527 peter@hurleysoftware.com X-MT-ID: 8FA290C2A27252AACF65DBC4A42F3CE3735FB2A4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2014 11:35 AM, Geert Uytterhoeven wrote: > On Tue, Mar 11, 2014 at 12:49 PM, Peter Hurley wrote: >> On 03/11/2014 06:58 AM, Geert Uytterhoeven wrote: >>> On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley >>> wrote: >>>>> >>>>> >>>>> [...] >>>>> >>>>> /* >>>>> * Indicate that there isn't a port here anymore. >>>>> */ >>>>> uport->type = PORT_UNKNOWN; >>>>> >>>>> state->uart_port = NULL; >>>> >>>> >>>> How did this ever work? >>>> >>>> Detaching the ll driver from the tty port in this manner is not ok; >>>> as you already note, it blows up if consoles are still running. >>> >>> No one unbinds serial drivers using serial_core, as all these drivers are >>> for fixed hardware? >> >> Yep, never tested until now :) >> Do you need this to work? > > Well, "need" may be a bit strong. Crashes are not so nice. :) What I meant was, 'is this a debug situation that I can eventually get to?' or 'are you on the verge of shipping product and this is a priority?' Regards, Peter Hurley