From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh@kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: rockchip: Add HINLINK H28K
Date: Mon, 1 Dec 2025 14:25:41 +0100 [thread overview]
Message-ID: <531f4d52-a48d-498a-861c-f15d0f5b456c@kernel.org> (raw)
In-Reply-To: <20251201130106.236903-1-amadeus@jmu.edu.cn>
On 01/12/2025 14:01, Chukun Pan wrote:
> Hi,
>
>> Just squash these two binding patches. Way too much churn.
>
> However, they are different SBCs manufactured by different companies:
Does not matter, you update same file doing almost the same.
>
> HINLINK H28K - Shenzhen HINLINK manufactures
> MangoPi M28K - Beijing Widora manufactures
>
> So should I squash them into a patch?
>
>> Anyway, looks like duplicate - two devices with same model name.
>
> These two SBCs are indeed very similar, both in name and configuration.
> So I put them in one series. Perhaps splitting them into two series to
> avoid confusion would have been better?
No, even more confusion. Look what I wrote:
"You have entire commit msg to explain that."
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-01 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 10:00 [PATCH 0/4] arm64: dts: rockchip: Add H28K and M28K Chukun Pan
2025-12-01 10:00 ` [PATCH 1/4] dt-bindings: arm: rockchip: Add HINLINK H28K Chukun Pan
2025-12-01 10:12 ` Krzysztof Kozlowski
2025-12-01 13:01 ` Chukun Pan
2025-12-01 13:25 ` Krzysztof Kozlowski [this message]
2025-12-01 10:00 ` [PATCH 2/4] arm64: dts: " Chukun Pan
2025-12-01 10:00 ` [PATCH 3/4] dt-bindings: arm: rockchip: Add MangoPi M28K Chukun Pan
2025-12-01 10:00 ` [PATCH 4/4] arm64: dts: " Chukun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531f4d52-a48d-498a-861c-f15d0f5b456c@kernel.org \
--to=krzk@kernel.org \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®