mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kyle Moffett <mrmacman_g4@mac.com>
To: Joe Perches <joe@perches.com>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	holzheu <holzheu@linux.vnet.ibm.com>,
	Rob Landley <rob@landley.net>,
	Dick Streefland <dick.streefland@altium.nl>
Subject: Re: [RFC] New kernel-message logging API
Date: Sat, 22 Sep 2007 23:43:36 -0400	[thread overview]
Message-ID: <5320EF8C-B64A-4BA6-B5EB-D2AC2CC86E31@mac.com> (raw)
In-Reply-To: <1190508441.30132.15.camel@localhost>

On Sep 22, 2007, at 20:47:21, Joe Perches wrote:
> On Sat, 2007-09-22 at 20:40 -0400, Kyle Moffett wrote:
>> Severity is *exactly* "desirability of logging".
>
> Disagree.
>
> What's info to someone is an alert to someone else.  The problem is  
> the valuation of the reasoning.
>
> It's all opinion.

For starters, I think "its all opinion" is bogus; the value of each  
log level is pretty standardly defined for the kernel:
EMERG:   The system is completely failing right NOW.  Immediate admin  
action is definitely required
ALERT:   The system is about to fail or halfway-failing.  Immediate  
admin action may be required.
ERR:     Something went badly wrong.  We are able to continue without  
endangering the overall system.
NOTICE:  Something unusual happened but it's either not a device/code  
failure or it's an expected failure.
INFO:    Something useful happened, like a device probe or a major  
system-wide event
DEBUG:   Something happened that only a developer or somebody looking  
for bugs would care about.

All of those are basically defined as: "This is how much the admin  
probably wants to see this message".  If you find a message which  
doesn't seem to match the log level it's logged at, please submit a  
patch.

Even assuming its not a bogus argument, what you actually want is  
*NOT* "Show me INFO and DEBUG, but not EMERG, ALERT, ERR, or NOTICE",  
you actually want multiple metrics by which to measure things.  We  
already have multiple ways of filtering log messages:
   1)  Log-level (greater than $LEVEL).
   2)  Userspace textual post-processing filters and classifiers (EG:  
logcheck)
   3)  CONFIG_${SUBSYS}_DEBUG and CONFIG_${DRIVER}_DEBUG

Perhaps what you want is something like the syslog "facility" parameter?

The only real reason to add more kconfig options for logging is to  
decrease the size of the kernel binary; most anything else can be  
better done in userspace in something like logcheck.  If you're going  
to add new kconfig options then you aren't going to configure them  
generically since they're inherently subsystem/driver specific.  In  
that case you might add a per-driver "CONFIG_${DRIVER}_NOLOG" for the  
drivers you care about or a "CONFIG_MAX_LOG_LEVEL" to globally limit  
by severity but any other qualifiers inherently don't fit in a single  
scalar

Cheers,
Kyle Moffett


  reply	other threads:[~2007-09-23  3:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-22 19:27 Vegard Nossum
2007-09-23  0:13 ` Joe Perches
2007-09-23  0:40   ` Kyle Moffett
2007-09-23  0:47     ` Joe Perches
2007-09-23  3:43       ` Kyle Moffett [this message]
2007-09-23  8:39   ` Vegard Nossum
2007-09-23  8:45     ` Jan Engelhardt
2007-09-23  9:20       ` Vegard Nossum
2007-09-23  9:38         ` Jan Engelhardt
2007-09-23 19:23       ` Joe Perches
2007-09-23 19:25     ` Joe Perches
2007-09-23  1:05 ` Miguel Ojeda
2007-09-25  5:27   ` Vegard Nossum
2007-09-25 17:24     ` Miguel Ojeda
2007-09-23 20:05 ` Rob Landley
2007-09-24  9:22 ` Michael Holzheu
2007-09-24 15:19   ` Joe Perches
2007-09-24 16:43     ` Vegard Nossum
2007-09-24 17:00       ` Joe Perches
2007-09-24 20:37         ` Vegard Nossum
2007-09-25  1:18           ` Rob Landley
2007-09-24 23:51     ` Rob Landley
2007-09-25  0:10       ` Joe Perches
2007-09-25  1:46         ` Rob Landley
2007-09-25  8:57     ` Michael Holzheu
2007-09-24 18:26 ` Jesse Barnes
2007-09-25  4:58 linux
2007-09-25  6:54 ` Joe Perches
2007-09-25  7:50   ` linux
2007-09-25  8:06   ` Vegard Nossum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5320EF8C-B64A-4BA6-B5EB-D2AC2CC86E31@mac.com \
    --to=mrmacman_g4@mac.com \
    --cc=dick.streefland@altium.nl \
    --cc=holzheu@linux.vnet.ibm.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®