From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbaCMMRm (ORCPT ); Thu, 13 Mar 2014 08:17:42 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:40572 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbaCMMRk (ORCPT ); Thu, 13 Mar 2014 08:17:40 -0400 Message-ID: <5321A1C5.8020501@ti.com> Date: Thu, 13 Mar 2014 14:17:09 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: George Cherian , , , , CC: , , , , , , , , , , Subject: Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue References: <1394193422-18242-1-git-send-email-george.cherian@ti.com> <1394193422-18242-2-git-send-email-george.cherian@ti.com> <53218944.7000102@ti.com> <53219970.6060002@ti.com> In-Reply-To: <53219970.6060002@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2014 01:41 PM, George Cherian wrote: > On 3/13/2014 4:02 PM, Roger Quadros wrote: >> Hi George, >> >> On 03/07/2014 01:56 PM, George Cherian wrote: >>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver. >>> >>> Signed-off-by: George Cherian >>> --- >>> Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt >>> index 38b2fae..38d9bb8 100644 >>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt >>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt >>> @@ -44,7 +44,9 @@ Board specific device node entry >>> }; >>> OMAP DWC3 GLUE >>> - - compatible : Should be "ti,dwc3" >>> + - compatible : Should be >>> + * "ti,dwc3" for OMAP5 and DRA7 >>> + * "ti,am437x-dwc3" for AM437x >> Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient? > > There is change in register offsets for AM437x as comapred to Omap5 and dra7x. > The compatible is already added in dwc3-omap.c This patch just updates the Documentation. Oh ok. Then it is fine. You can add my. Acked-by: Roger Quadros cheers, -roger >> >>> - ti,hwmods : Should be "usb_otg_ss" >>> - reg : Address and length of the register set for the device. >>> - interrupts : The irq number of this device that is used to interrupt the >>> >> cheers, >> -roger > >