mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Koral Ilgun <koralilgun@gmail.com>, netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org, fw@strlen.de, phil@nwl.cc,
	coreteam@netfilter.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Koral Ilgun <koral.ilgun@adtran.com>
Subject: Re: [PATCH nf-next v2] netfilter: nft_flow_offload: do not offload multicast
Date: Fri, 30 Oct 2026 11:02:16 +0100	[thread overview]
Message-ID: <53223bf8-8871-4b24-82c4-a86a26b50904@suse.de> (raw)
In-Reply-To: <20261029220144.2474139-1-koralilgun@gmail.com>

On 10/29/26 11:01 PM, Koral Ilgun wrote:
> From: Koral Ilgun <koral.ilgun@adtran.com>
> 
> A flow holds one output per direction, which it resolves when it is
> added. The outputs of a multicast route change when listeners join
> or leave. So a multicast flow in the flowtable continues to send to
> the output that it resolved, also after the last listener left, and
> the counters of the multicast routing stop.
> 
> A ruleset can keep multicast out with a match before the flow
> offload statement. Without one, IPv4 multicast stays out of the
> flowtable only because the reverse route lookup in nft_flow_route()
> refuses a multicast source address. The IPv6 route lookup has no such
> check, so IPv6 multicast that ip6mr forwards goes into the flowtable.
> 
> Skip a multicast destination for both families in the flow offload
> expression itself, so that the result no longer depends on the
> ruleset or on the route lookup.
> 
> Signed-off-by: Koral Ilgun <koral.ilgun@adtran.com>

Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>

Thanks!

      reply	other threads:[~2026-10-30 10:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 22:01 Koral Ilgun
2026-10-30 10:02 ` Fernando Fernandez Mancera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53223bf8-8871-4b24-82c4-a86a26b50904@suse.de \
    --to=fmancera@suse.de \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=koral.ilgun@adtran.com \
    --cc=koralilgun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®